From: Andrew Cagney <cagney@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk@sourceware.org
Subject: Re: [SCM] master: Use libunwind cursor to get at CFA.
Date: Tue, 04 Dec 2007 14:42:00 -0000 [thread overview]
Message-ID: <47556743.7080606@redhat.com> (raw)
In-Reply-To: <1196714939.3072.67.camel@dijkstra.wildebeest.org>
Mark Wielaard wrote:
> Nice catch. Well that is somewhat of a bummer. Then we must fall back on
> the unwind one frame trick and get the SP again.
>
That isn't as bad as it seems; computing the cfa requires running the
unwind-program anyway.
I think having a method (perhaps called .getInnerCFA() though?) to
differentiate between the sp and cfa is definitly a good idea. Also, if
possible, can the start code address of the CFI block be made
available? There's the theoretical possibility of further tuning the
stepping code to use that to construct a quick-and-dirty
frame-identifier when single stepping (letting us delay the request for
the code's function).
(Your elimination of the uses of libunwind's lookup is wicked)
> What is somewhat worrying is that none of the tests caught this. So I
> added one that does fail with my change, and passes with that commit
> reverted.
>
>
Yes. Scary. There's always one that gets away :-) Nice simple
portable test.
Andrew
prev parent reply other threads:[~2007-12-04 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071203105946.11374.qmail@sourceware.org>
2007-12-03 16:19 ` Andrew Cagney
2007-12-03 20:49 ` Mark Wielaard
2007-12-04 14:42 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47556743.7080606@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).