public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Petr Machata <pmachata@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk <frysk@sourceware.org>
Subject: Re: [patch] Make source compile with older gcj
Date: Wed, 16 Jan 2008 13:49:00 -0000	[thread overview]
Message-ID: <478E0B37.50802@redhat.com> (raw)
In-Reply-To: <1200487750.6395.11.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Mark Wielaard wrote:
> Some older versions of gcj (GCC) 4.1.2 20070626 (Red Hat 4.1.2-14) fell
> over the creative usage of anonymous inner classes inside methods
> calling inner class methods defined in the outer method they were
> defined in.

Huh, you lost me at "outer methods".  But in general, since gcj seems to
have all sorts of problems with classes defined in methods, it's
probably for the best simply to avoid them...

> The patch isn't very nice (sorry Petr), but since this is a test class
> anyway I thought I could get away with it.

Absolutely.

> It also removes the unresolved bug #5053 since I couldn't reproduce that
> on any setup. It PASSes fine for me (fedora 8, centos 5.1).

Very cool, especially the Centos 5.1 part; F 8 is my main devel
platform, so I'm not all that surprised that works :)

> Mark

PM


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      parent reply	other threads:[~2008-01-16 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 12:49 Mark Wielaard
2008-01-16 13:41 ` Chris Moller
2008-01-16 13:49 ` Petr Machata [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478E0B37.50802@redhat.com \
    --to=pmachata@redhat.com \
    --cc=frysk@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).