[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[dhazeghi@yahoo.com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021


dhazeghi@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
  GCC build triplet|                            |m68k-linux
   GCC host triplet|                            |m68k-linux
 GCC target triplet|                            |m68k-linux


------- Additional Comments From dhazeghi@yahoo.com  2003-06-02 17:47 -------
Roman,

is this bug still present in current sources? Thanks,

Dara



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[doko@cs.tu-berlin.de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From doko@cs.tu-berlin.de  2003-06-02 19:39 -------
Subject: Re:  [3.3/3.4 regression] [m68k] alias problem during loop pass

dhazeghi@yahoo.com writes:
> Roman,
> 
> is this bug still present in current sources? Thanks,

it is present in the released 3.3. Didn't check against 3.4 yet.




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[dhazeghi@yahoo.com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021


dhazeghi@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-06-02 20:13:04
               date|                            |


------- Additional Comments From dhazeghi@yahoo.com  2003-06-02 20:13 -------
Confirmed as still present, at least on 3.3 branch.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[pinskia@physics.uc.edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021


pinskia@physics.uc.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |3.3.1

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[wilson at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From wilson at gcc dot gnu dot org  2003-06-30 08:18 -------
true_dependence fails when its arguments are (mem (plus sp -64)) and (mem (reg
1143)).  The failure happens in base_alias_check.  The base of the first is
ADDRESS sp, and the base of the second is REG 1143.  Since one has a base in the
stack and the other don't, we indicate that they don't alias.  The problem here
is that reg_base_value should never be a register.  The comments say it can only
be a ADDRESS, SYMBOL_REF, or LABEL_REF.  This takes us to find_base_value, which
when given a reg with no known base_value, it returns the reg.  This contradicts
the comments at the top of the file.  Returning 0 for a unknown reg instead of
itself seems to be the correct solution.  I haven't looked into this very
closely as yet though.

While looking at this, I also noticed that ARRAY_REFs were resulting in MEMs
that did not have the MEM_IN_STRUCT_P bit set.  The problem here is in
set_mem_attribute_minus_bitpos.  It has code at the end to check to see if the
argument t is an ARRAY_REF.  Unfortunately, in the middle, it has a loop that
modifies the argument t.  This can be fixed by creating a temporary t2.

The resulting patch seems to solve this testcase, since there is no longer any
load hoisting.  However, I haven't checked to see if this is disabling too much
optimization yet.

I will put the patch in an attachment.

Jim

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[sirl at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From sirl at gcc dot gnu dot org  2003-06-30 08:24 -------
This may be related to <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9745>

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[marcus at jet dot franken dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From marcus at jet dot franken dot de  2003-06-30 11:26 -------
The patch cures the testcase from 9745 for 3.4 prerelease.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[doko at cs dot tu-berlin dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From doko at cs dot tu-berlin dot de  2003-07-01 16:58 -------
Subject: Re:  [3.3/3.4 regression] [m68k] alias problem during loop pass

sirl at gcc dot gnu dot org writes:
> This patch was bootstrapped (without ada) and tested without regressions
> against the current gcc-3_3-branch on i686-linux-gnu.

bootstrapped on i386-linux and tested without regressions against  the
current gcc-3_3-branch.

on m68k-linux the bootstrap succeeded, the testsuite just started ...

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[sirl at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From sirl at gcc dot gnu dot org  2003-07-01 18:40 -------
The 3_3 patch bootstrapped and tested without regressions on powerpc-linux-gnu 
with the current gcc-3_3-branch. The PR9745 libmcrypt miscompilation is fixed 
as well.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[doko at cs dot tu-berlin dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From doko at cs dot tu-berlin dot de  2003-07-03 23:09 -------
Subject: Re:  [3.3/3.4 regression] [m68k] alias problem during loop pass

doko at cs dot tu-berlin dot de writes:
> sirl at gcc dot gnu dot org writes:
> > This patch was bootstrapped (without ada) and tested without regressions
> > against the current gcc-3_3-branch on i686-linux-gnu.
> 
> bootstrapped on i386-linux and tested without regressions against  the
> current gcc-3_3-branch.
> 
> on m68k-linux the bootstrap succeeded, the testsuite just started ...

the m68k-linux finished with no new regressions. current CVS does show
a wrong warning

../../src/gcc/loop.c:9802: warning: `load_mems' defined but not used

which does not occur with the patched gcc.

Please not, that I actually included two m68k patches in my bootstrap:

  2003-06-30  James E Wilson  <wilson@tuliptree.org>
  
        * alias.c (find_base_value, case REG): Return 0 not src if no base
        found.
        * emit-rtl.c (set_mem_attribute_minus_bitpos): When handle ARRAY_REF,
        loop over new variable t2 instead of t.

  2003-06-27  James E Wilson  <wilson@tuliptree.org>
  
        * rtl.h (mem_for_const_double): Delete prototype.
        * varasm.c (mem_for_const_double): Delete function.
        * config/m68k/hp320.h, config/m68k/linux.h, config/m68k/m68kelf.h,
        config/m68k/m68kv4.h, config/m68k/netbsd-elf.h
        (LEGITIMATE_PIC_OPERAND_P): Delete duplicate definitions.
        * config/m68k/m68k.h (LEGITIMATE_CONSTANT_P): Disallow XFmode.
        (LEGITIMATE_PIC_OPERAND_P): Delete CONST_DOUBLE tests.
        * config/m68k/m68k.md (movxf): Add reload_in_progress guard.  Add
        comment about confused support for XFmode constants.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-07-09 00:18 -------
Subject: Bug 10021

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	wilson@gcc.gnu.org	2003-07-09 00:18:20

Modified files:
	gcc            : ChangeLog emit-rtl.c 

Log message:
	partial fix for PR target/10021
	* emit-rtl.c (set_mem_attribute_minus_bitpos): When handle ARRAY_REF,
	loop over new variable t2 instead of t.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.406&r2=2.407
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/emit-rtl.c.diff?cvsroot=gcc&r1=1.341&r2=1.342

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-07-09 00:30 -------
Subject: Bug 10021

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	wilson@gcc.gnu.org	2003-07-09 00:30:23

Modified files:
	gcc            : ChangeLog emit-rtl.c 

Log message:
	partial fix for PR target/10021
	* emit-rtl.c (set_mem_attribute_minus_bitpos): When handle ARRAY_REF,
	loop over new variable t2 instead of t.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.642&r2=1.16114.2.643
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/emit-rtl.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.303.2.1&r2=1.303.2.2

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[wilson at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From wilson at gcc dot gnu dot org  2003-07-11 06:54 -------
The patch that fixed PR 9745 did not fix this one. It is a closely related
problem, but there are multiple problems here. See
http://gcc.gnu.org/ml/gcc/2003-07/msg00668.html
for a discussion of various issues related to this problem.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-08-03 16:02 -------
Postponed until GCC 3.3.2.

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.1                       |3.3.2

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-12 05:26 -------
Subject: Bug 10021

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	wilson@gcc.gnu.org	2003-08-12 05:26:15

Modified files:
	gcc            : ChangeLog alias.c 

Log message:
	PR optimization/11319
	PR target/10021
	* alias.c (find_base_value, case REG): Return 0 not src if no base
	found.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.706&r2=1.16114.2.707
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/alias.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.181.2.2&r2=1.181.2.3

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-12 05:28 -------
Subject: Bug 10021

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	wilson@gcc.gnu.org	2003-08-12 05:28:45

Modified files:
	gcc            : ChangeLog alias.c 

Log message:
	PR optimization/11319
	PR target/10021
	* alias.c (find_base_value, case REG): Return 0 not src if no base
	found.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.769&r2=2.770
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/alias.c.diff?cvsroot=gcc&r1=1.198&r2=1.199

[Bug target/10021] [3.3/3.4 regression] [m68k] alias problem during loop pass

[wilson at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10021


wilson at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE


------- Additional Comments From wilson at gcc dot gnu dot org  2003-08-28 07:36 -------
Patches checked in to fix it on mainline and for 3.3.2.  Further comments in PR
11319.

*** This bug has been marked as a duplicate of 11319 ***