[Bug c/11992] New: [Regression 3.3.1]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[Bug c/11992] New: [Regression 3.3.1]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[heinrich dot brand at fujitsu-siemens dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992

           Summary: [Regression 3.3.1]Wrong built-in code for memcmp with
                    length 1<<24 only (1<<24)-1 possible for CLCL-
                    Instruction
           Product: gcc
           Version: 3.3.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: heinrich dot brand at fujitsu-siemens dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: LINUX S390 on FSC S180
  GCC host triplet: LINUX S390 on FSC S180
GCC target triplet: LINUX S390 on FSC S180

Please look in file config/s390/s390.c function s390_expand_cmpstr. There 


is a difference to 3.3. which could be the cause of the problem:


#if 0


  /* Deactivate for now as profile code cannot cope with


     CC being live across basic block boundaries.  */




A test:




#include <stdio.h>


#include <string.h>




#define L1 ((1<<24)-0)0




int foo (char *p, char *q) {


    return memcmp (p, q, L1); 


}


main() {


 int c;


 char x[L1],y[L1];


 char *p,*q;


 p=&x[0];


 q=&y[0];


 q[0] = 1;


 p[0] = 0;


 c=foo(p,q);


 printf(" c = %d\n",c);


 if (c < 0) 


  printf("SUCCESSFUL\n");


    else 


  printf("FAILED\n");


 exit (0);




}

[Bug target/11992] [3.3.1 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
          Component|c                           |target
  GCC build triplet|LINUX S390 on FSC S180      |s390-linux-gnu
   GCC host triplet|LINUX S390 on FSC S180      |s390-linux-gnu
 GCC target triplet|LINUX S390 on FSC S180      |s390-linux-gnu
           Keywords|                            |wrong-code
            Summary|[Regression 3.3.1]Wrong     |[3.3.1 Regression]Wrong
                   |built-in code for memcmp    |built-in code for memcmp
                   |with length 1<<24 only      |with length 1<<24 only
                   |(1<<24)-1 possible for CLCL-|(1<<24)-1 possible for CLCL-
                   |Instruction                 |Instruction
   Target Milestone|3.4                         |3.3.2

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.3.1 Regression]Wrong     |[3.3.1/3.4 Regression]Wrong
                   |built-in code for memcmp    |built-in code for memcmp
                   |with length 1<<24 only      |with length 1<<24 only
                   |(1<<24)-1 possible for CLCL-|(1<<24)-1 possible for CLCL-
                   |Instruction                 |Instruction

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.2                       |3.3.3


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-10-02 22:25 -------
S390 is not a primary evaluation platform, so I've postponed this PR.

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2003-12-12 08:16 -------
Ulrich, would you mind taking a look at this bug? Is it still present?


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uweigand at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[uweigand at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-12-16 19:26:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-12-17 21:52 -------
Subject: Bug 11992

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	uweigand@gcc.gnu.org	2003-12-17 21:51:59

Modified files:
	gcc            : ChangeLog 
	gcc/config/s390: s390.md 

Log message:
	PR target/11992
	* config/s390/s390.md ("*cmpmem_long_64"): Use CLCLE instruction
	instead of CLCL.
	("*cmpmem_long_31"): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.2022&r2=2.2023
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/s390/s390.md.diff?cvsroot=gcc&r1=1.88&r2=1.89



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-12-17 21:54 -------
Subject: Bug 11992

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	uweigand@gcc.gnu.org	2003-12-17 21:54:14

Modified files:
	gcc            : ChangeLog 
	gcc/config/s390: s390.md 

Log message:
	PR target/11992
	* config/s390/s390.md ("*cmpmem_long_64"): Use CLCLE instruction
	instead of CLCL.
	("*cmpmem_long_31"): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.847&r2=1.16114.2.848
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/s390/s390.md.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.41.2.9&r2=1.41.2.10



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992

[Bug target/11992] [3.3.1/3.4 Regression]Wrong built-in code for memcmp with length 1<<24 only (1<<24)-1 possible for CLCL-Instruction

[uweigand at gcc dot gnu dot org]

------- Additional Comments From uweigand at gcc dot gnu dot org  2003-12-17 21:57 -------
Fixed by using CLCLE instead of CLCL. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11992