[Bug bootstrap/11313] New: #pragma weak and static inline functions

[Bug bootstrap/11313] New: #pragma weak and static inline functions

[georgaj at navcanada dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313

           Summary: #pragma weak and static inline functions
           Product: gcc
           Version: 3.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: georgaj at navcanada dot ca
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: hppa64-hp-hpux11.00
  GCC host triplet: hppa64-hp-hpux11.00
GCC target triplet: hppa64-hp-hpux11.00

When bootstrapping with pthread support, the compiler complains that 
pthread_create() must be public in order to be declared as a weak symbol using 
#pragma weak. The problem is that the sys/pthread.h that comes with HPUX11.00 
has the following code in it:

	static int pthread_create( 
				  pthread_t *tid, 
				  const pthread_attr_t *attr,
                                  void *(*start_routine)(void *), 
				  void *arg)
	    { return(__pthread_create_system(tid, attr, start_routine, arg)); }

This function just redirects to the "real" pthread creation function.

Removing the static modifier gets rid of the visibility error, but then the 
compiler complains that the weak declaration must precede the function 
definition.

Hack: I commented out the "#pragma weak" line for pthread_create() in 
gthr-posix.h, but I'm not sure what the consequences of this are.

I'm kind of missing the point of these pragmas. Are they there so gcc, 
configured for pthread support, will bootstrap whether or not the host actually 
has pthread support?

[Bug libstdc++/11313] [3.3 only] #pragma weak and static inline functions

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geoffk at apple dot com
             Status|UNCONFIRMED                 |NEW
          Component|bootstrap                   |libstdc++
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-24 12:47:44
               date|                            |
            Summary|#pragma weak and static     |[3.3 only] #pragma weak and
                   |inline functions            |static inline functions
   Target Milestone|3.4                         |3.3.2


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-24 12:47 -------
I think this is fixed on the mainline by:
2003-07-22  Geoffrey Keating

        * c-decl.c (start_decl): Don't call maybe_apply_pragma_weak here.
        (finish_decl): Call maybe_apply_pragma_weak here.
        (grokdeclarator): Check that DECL_ASSEMBLER_NAME isn't set before
        TREE_PUBLIC and TREE_STATIC are decided.
        (start_function): Move call to maybe_apply_pragma_weak.  Check that
        DECL_ASSEMBLER_NAME isn't set too early.

Keating would you mind asking for 3.3.2 inclusion?

[Bug libstdc++/11313] [3.3 only] #pragma weak and static inline functions

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


geoffk at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2003-07-24 12:47:44         |2003-07-24 18:20:57
               date|                            |


------- Additional Comments From geoffk at gcc dot gnu dot org  2003-07-24 18:20 -------
Yes, I'll try to get the relevant bit of the patch into 3.3.

[Bug middle-end/11313] [3.3 only] #pragma weak and static inline functions

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313



------- Additional Comments From geoffk at gcc dot gnu dot org  2003-07-29 17:57 -------
Actually, it was this change:

        * c-pragma.c (maybe_apply_pragma_weak): Don't get DECL_ASSEMBLER_NAME
        when it's not needed.

[Bug middle-end/11313] [3.3 only] #pragma weak and static inline functions

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-01 20:47 -------
Subject: Bug 11313

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	geoffk@gcc.gnu.org	2003-08-01 20:47:37

Modified files:
	gcc            : ChangeLog c-pragma.c 

Log message:
	PR 11313
	* c-pragma.c (maybe_apply_pragma_weak): Don't get DECL_ASSEMBLER_NAME
	when it's not needed.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.687&r2=1.16114.2.688
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-pragma.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.54.14.1&r2=1.54.14.2

[Bug middle-end/11313] [3.3 only] #pragma weak and static inline functions

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


geoffk at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.3.2                       |3.3.1


------- Additional Comments From geoffk at gcc dot gnu dot org  2003-08-01 20:53 -------
Mark let me put the fix into 3.3.1!

[Bug middle-end/11313] #pragma weak and static inline functions

[georgaj at navcanada dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


georgaj at navcanada dot ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
            Summary|[3.3 only] #pragma weak and |#pragma weak and static
                   |static inline functions     |inline functions
            Version|3.3                         |3.3.1


------- Additional Comments From georgaj at navcanada dot ca  2003-08-12 20:12 -------
hmmm..... I'm still getting the same bootstrap error with 3.3.1
Is there something else I need to do here?

[Bug middle-end/11313] #pragma weak and static inline functions

[georgaj at navcanada dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


georgaj at navcanada dot ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From georgaj at navcanada dot ca  2003-08-12 20:27 -------
Cancel last: The first stage of the bootstrap uses the gcc3.3 already installed 
on my system. hehe. I'll build 3.3.1 with the altered gthr-posix.h so gcc3.3 can 
deal with it, and use that to test a clean bootstrap.

[Bug middle-end/11313] #pragma weak and static inline functions

[georgaj at navcanada dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


georgaj at navcanada dot ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


------- Additional Comments From georgaj at navcanada dot ca  2003-08-12 23:42 -------
Ok, I've tried a clean bootstrap of gcc-3.3.1, using gcc-3.3.1, and the original 
bug is still present.

[Bug middle-end/11313] #pragma weak and static inline functions

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.1                       |3.3.2

[Bug middle-end/11313] #pragma weak and static inline functions

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


geoffk at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|geoffk at gcc dot gnu dot   |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|REOPENED                    |NEW


------- Additional Comments From geoffk at gcc dot gnu dot org  2003-09-05 22:21 -------
It looks like my patch doesn't fix this, so I'll return it to the pool.

[Bug middle-end/11313] #pragma weak and static inline functions

[zack at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11313


zack at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From zack at gcc dot gnu dot org  2003-09-19 00:38 -------
Believed fixed with this change:

2003-08-25  Zack Weinberg  <zack@codesourcery.com>

        * config.gcc (hppa*-*-hpux11*, ia64*-*-hpux*): Remove
        commented-out logic to use DCE threads (if present), add
        support for POSIX threads.
        * config/ia64/hpux.h: Define CPP_SPEC to set appropriate
        #defines for -pthread.  Add -lpthread to LIB_SPEC when
        -pthread.  In both cases take -mt as a synonym for -pthread
        for acc compatibility.
        Define GTHREAD_USE_WEAK to 0.
        * config/pa/pa-hpux11.h: Likewise for CPP_SPEC and LIB_SPEC.
        Remove old logic for DCE threads from LIB_SPEC.
        * config/pa/pa64-hpux.h: Define GTHREAD_USE_WEAK to 0.