public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libobjc/12155] New: Memory leak in libobjc(selector.c)
@ 2003-09-03 15:39 fedor at gnu dot org
  2003-09-07  3:05 ` [Bug libobjc/12155] " pinskia at gcc dot gnu dot org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: fedor at gnu dot org @ 2003-09-03 15:39 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12155

           Summary: Memory leak in libobjc(selector.c)
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: libobjc
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: fedor at gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: any
  GCC host triplet: any
GCC target triplet: any

This patch fixes a minor memory leak in libobjc:

2003-08-31  Adam Fedor  <fedor@gnu.org>

        * selector.c (__objc_register_instance_methods_to_class): Free
        new_list if not used.

Index: selector.c
===================================================================
RCS file: /cvsroot/gnustep/gnustep/dev-libs/libobjc/selector.c,v
retrieving revision 1.3
diff -u -p -r1.3 selector.c
--- selector.c  23 Feb 2003 03:48:41 -0000      1.3
+++ selector.c  1 Sep 2003 03:36:06 -0000
@@ -148,6 +148,8 @@ void __objc_register_instance_methods_to
       new_list->method_next = class->class_pointer->methods;
       class->class_pointer->methods = new_list;
     }
+  else
+    objc_free(new_list);
 
     __objc_update_dispatch_table_for_class (class->class_pointer);
 }


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libobjc/12155] Memory leak in libobjc(selector.c)
  2003-09-03 15:39 [Bug libobjc/12155] New: Memory leak in libobjc(selector.c) fedor at gnu dot org
@ 2003-09-07  3:05 ` pinskia at gcc dot gnu dot org
  2003-10-11  3:05 ` pinskia at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2003-09-07  3:05 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12155



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-07 03:05 -------
Can you post this patch to gcc-patches@  __after__  reading <http://gcc.gnu.org/
contribute.html>.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libobjc/12155] Memory leak in libobjc(selector.c)
  2003-09-03 15:39 [Bug libobjc/12155] New: Memory leak in libobjc(selector.c) fedor at gnu dot org
  2003-09-07  3:05 ` [Bug libobjc/12155] " pinskia at gcc dot gnu dot org
@ 2003-10-11  3:05 ` pinskia at gcc dot gnu dot org
  2003-10-16 13:33 ` d dot ayers at inode dot at
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2003-10-11  3:05 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12155


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-10-11 03:05:00
               date|                            |


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libobjc/12155] Memory leak in libobjc(selector.c)
  2003-09-03 15:39 [Bug libobjc/12155] New: Memory leak in libobjc(selector.c) fedor at gnu dot org
  2003-09-07  3:05 ` [Bug libobjc/12155] " pinskia at gcc dot gnu dot org
  2003-10-11  3:05 ` pinskia at gcc dot gnu dot org
@ 2003-10-16 13:33 ` d dot ayers at inode dot at
  2004-01-15  1:49 ` cvs-commit at gcc dot gnu dot org
  2004-01-15  1:50 ` pinskia at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: d dot ayers at inode dot at @ 2003-10-16 13:33 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12155



------- Additional Comments From d dot ayers at inode dot at  2003-10-16 13:33 -------
Boostrapped and tested on i686-pc-linux-gnu with mainline:
gcc (GCC) 3.4 20031016 (experimental)
No regressions.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libobjc/12155] Memory leak in libobjc(selector.c)
  2003-09-03 15:39 [Bug libobjc/12155] New: Memory leak in libobjc(selector.c) fedor at gnu dot org
                   ` (2 preceding siblings ...)
  2003-10-16 13:33 ` d dot ayers at inode dot at
@ 2004-01-15  1:49 ` cvs-commit at gcc dot gnu dot org
  2004-01-15  1:50 ` pinskia at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-01-15  1:49 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-01-15 01:49 -------
Subject: Bug 12155

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2004-01-15 01:49:41

Modified files:
	libobjc        : ChangeLog selector.c 

Log message:
	2004-01-14  Adam Fedor  <fedor@gnu.org>
	
	PR libobjc/12155
	* selector.c (__objc_register_instance_methods_to_class): Free
	new_list if not used.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/ChangeLog.diff?cvsroot=gcc&r1=1.105&r2=1.106
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/selector.c.diff?cvsroot=gcc&r1=1.6&r2=1.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12155


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libobjc/12155] Memory leak in libobjc(selector.c)
  2003-09-03 15:39 [Bug libobjc/12155] New: Memory leak in libobjc(selector.c) fedor at gnu dot org
                   ` (3 preceding siblings ...)
  2004-01-15  1:49 ` cvs-commit at gcc dot gnu dot org
@ 2004-01-15  1:50 ` pinskia at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-01-15  1:50 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-15 01:50 -------
Fixed for 3.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12155


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-01-15  1:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-03 15:39 [Bug libobjc/12155] New: Memory leak in libobjc(selector.c) fedor at gnu dot org
2003-09-07  3:05 ` [Bug libobjc/12155] " pinskia at gcc dot gnu dot org
2003-10-11  3:05 ` pinskia at gcc dot gnu dot org
2003-10-16 13:33 ` d dot ayers at inode dot at
2004-01-15  1:49 ` cvs-commit at gcc dot gnu dot org
2004-01-15  1:50 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).