[Bug c/12738] New: Missing function with 'static' declaration inside function.

[Bug c/12738] New: Missing function with 'static' declaration inside function.

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738

           Summary: Missing function with 'static' declaration inside
                    function.
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: geoffk at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: powerpc-darwin
  GCC host triplet: powerpc-darwin
GCC target triplet: powerpc-darwin

The following testcase:

void
flarm(void)
{
  static void foo();

  foo();
}

static void
foo(void)
{
}

produces a linker error when compiled with -funit-at-a-time and IMA, because 'foo' is not output 
although a reference to it is.  Interestingly, it *does* work if you disable either of these.

The actual command-line I used was
./xgcc -B./ ~/t.c ~/t2.c -S -O -o t.s -funit-at-a-time

with 't.c' containing the above, and 't2.c' containing:
int xxx;

and the assembler output I got was:

.text
        .align 2
        .globl _flarm
_flarm:
        mflr r0
        stw r31,-4(r1)
        stw r0,8(r1)
        stwu r1,-80(r1)
        bl _foo.1
        addi r1,r1,80
        lwz r0,8(r1)
        mtlr r0
        lwz r31,-4(r1)
        blr
.comm _xxx,4

No 'foo' :-(.

(This syntax is a GCC extension, and not a very good one; but I bet there's some other case that 
can trip the underlying bug.)

I expect at least part of the problem is that we have DECL_EXTERNAL and ! TREE_PUBLIC.

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738


geoffk at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-10-23 00:46:33
               date|                            |
            Summary|Missing function with       |Missing function with
                   |'static' declaration inside |'static' block-scope
                   |function.                   |declaration; unit-at-a-time;
                   |                            |and IMA.

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-23 01:07 -------
Here is a related test-case:
int
flarm(void)
{
  extern int i;
  return i;
}
static int i;

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[rth at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738



------- Additional Comments From rth at gcc dot gnu dot org  2003-10-30 01:20 -------
Can we agree that this is a Very Bad Extension and kill it?

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[geoffk at geoffk dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738



------- Additional Comments From geoffk at geoffk dot org  2003-10-30 19:31 -------
Subject: Re:  Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

> Date: 30 Oct 2003 01:20:05 -0000
> From: "rth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>

> Can we agree that this is a Very Bad Extension and kill it?

Well, it turns out that it happens fairly often, mostly because GCC
didn't give any warnings by default, and as we all know "if the
compiler doesn't warn about it, it must be correct".  I've found
24 instances in Apple's source base.

However, I would suggest that we should deprecate this GCC extension.
At the very least, the warning should be on by default.

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[wilson at specifixinc dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738



------- Additional Comments From wilson at specifixinc dot com  2003-10-31 01:39 -------
Subject: Re:  Missing function with 'static' block-scope declaration;
 unit-at-a-time; and IMA.

geoffk at geoffk dot org wrote:
> However, I would suggest that we should deprecate this GCC extension.
> At the very least, the warning should be on by default.

I suspect there is an interaction with nested functions here.  If you 
allow static functions to be defined within a block, and we do, then you 
must also allow static declarations of functions within a block. 
However, we could give a warning if a block contains a static function 
declaration, but no matching nested static function definition.  We 
would not be able to give this warning until the end of the block, since 
the function definition could appear anywhere within the block. (I'm 
thinking ISO C99 rules here).

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[wilson at specifixinc dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738



------- Additional Comments From wilson at specifixinc dot com  2003-10-31 02:06 -------
Subject: Re:  Missing function with 'static' block-scope declaration;
 unit-at-a-time; and IMA.

pinskia at gcc dot gnu dot org wrote:
> int
> flarm(void)
> {
>   extern int i;
>   return i;


> }
> static int i;

This is a rather different testcase.  ISO C says that functions declared 
within a block may not be declared static, so Geoff's example is 
immediately invalid.

This one is trickier though.  An extern int declaration within a block 
is certainly valid.  And the scope of a declaration within a block ends 
at the end of the block, so there are no conflicting declarations that 
require a diagnositic.  ISO C does say that if the same identifier is 
defined within different linkage within a module that the effect is 
undefined, so this testcase does have undefined effect, but we aren't 
required to emit a diagnostic for it.

By the way, gcc did used to give a warning for this testcase with -Wall. 
  I wrote the code myself, it was the IDENTIFIER_LIMBO_VALUE stuff in 
c-decl.c.  This was removed by Zack in April this year.  gcc-3.3 does 
warn, but gcc-3.4 does not.  This might be an accidental misfeature of 
Zack's patch, as the patch itself claims to preserve the functionality 
of IDENTIFIER_LIMBO_VALUE, but implement it a different way.  I did not 
verify that Zack's patch is the problem though.  The problem could have 
been created by some other patch unrelated to Zack's changes.  I'd 
suggest looking at Zack's patch first though, if we care.  The patch is
     http://gcc.gnu.org/ml/gcc-patches/2003-04/msg00766.html

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[zack at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738



------- Additional Comments From zack at gcc dot gnu dot org  2003-10-31 02:42 -------
I certainly intended to preserve the warning for this construct.  However, I
never got to finish the revamp of c-decl.c that I had planned so it is possible
that this fell through the cracks.

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-15 04:59 -------
This was working correctly in 20040320:
[zhivago2:~/src/gccPRs] pinskia%  /Users/pinskia/fsf-clean/libexec/gcc/powerpc-apple-
darwin7.2.0/3.5.0/cc1 -quiet -v -D__DYNAMIC__ -D__APPLE_CC__=1 pr12738.c 
pr12738.1.c -fPIC -quiet -dumpbase pr12738.c -auxbase-strip - -O1 -version -funit-at-a-
time -fno-inline -fno-inline-functions -o -
ignoring nonexistent directory "/Users/pinskia/fsf-clean/lib/gcc/powerpc-apple-
darwin7.2.0/3.5.0/../../../../powerpc-apple-darwin7.2.0/include"
ignoring nonexistent directory "/Local/Library/Frameworks"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /Users/pinskia/fsf-clean/include
 /Users/pinskia/fsf-clean/lib/gcc/powerpc-apple-darwin7.2.0/3.5.0/include
 /usr/include
 /System/Library/Frameworks
 /Library/Frameworks
End of search list.
GNU C version 3.5.0 20040320 (experimental) (powerpc-apple-darwin7.2.0)
        compiled by GNU C version 3.5.0 20040320 (experimental).
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
.text
        .align 2
_foo.0:
        blr
        .align 2
        .globl _flarm
_flarm:
        blr
.comm _xx,4

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-08-27 14:42 -------
gcc 3.5.0 20040827 does error on Andrew's second testcase.  I think the right thing to do is to error on 
my original testcase, too.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |geoffk at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-08-30 22:19 -------
Subject: Bug 12738

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	geoffk@gcc.gnu.org	2004-08-30 22:19:24

Modified files:
	gcc            : ChangeLog c-decl.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/gcc.c-torture/compile: 920625-2.c 
	gcc/testsuite/gcc.c-torture/execute: 20010605-1.c nest-stdar-1.c 
	gcc/testsuite/gcc.dg: 20011130-1.c 20021014-1.c 20030331-2.c 
Added files:
	gcc/testsuite/gcc.dg: funcdef-storage-1.c 

Log message:
	2004-08-30  Geoffrey Keating  <geoffk@apple.com>
	
	PR 12738
	PR 17205
	Radar 3460526
	Radar 3775729
	* c-decl.c (grokdeclarator): Produce error for 'static' on local
	function declaration.
	
	Index: testsuite/ChangeLog
	2004-08-30  Geoffrey Keating  <geoffk@apple.com>
	
	* gcc.dg/funcdef-storage-1.c: New.
	* gcc.c-torture/compile/920625-2.c: Don't use 'static' to declare
	an extern function in local scope.
	* gcc.c-torture/execute/20010605-1.c: Don't use 'static inline' to
	declare an 'auto inline' function in local scope.
	* gcc.dg/20011130-1.c: Likewise.
	* gcc.c-torture/execute/nest-stdar-1.c: Don't use 'static' to declare
	an 'auto' function in local scope.
	* gcc.dg/20021014-1.c: Likewise.
	* gcc.dg/20030331-2.c: Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.5161&r2=2.5162
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&r1=1.565&r2=1.566
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4211&r2=1.4212
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/compile/920625-2.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/20010605-1.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/nest-stdar-1.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/funcdef-storage-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/20011130-1.c.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/20021014-1.c.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/20030331-2.c.diff?cvsroot=gcc&r1=1.3&r2=1.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-08-30 22:21 -------
Now gives error message on this testcase.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-08-30 22:25 -------
Yup, testcase does produce error.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738

[Bug c/12738] Missing function with 'static' block-scope declaration; unit-at-a-time; and IMA.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-01 22:12 -------
Subject: Bug 12738

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	apple-ppc-branch
Changes by:	geoffk@gcc.gnu.org	2004-09-01 22:12:16

Modified files:
	gcc            : c-decl.c 
	gcc/testsuite/gcc.c-torture/compile: 920625-2.c 
	gcc/testsuite/gcc.c-torture/execute: 20010605-1.c nest-stdar-1.c 
	gcc/testsuite/gcc.dg: 20011130-1.c 20021014-1.c 20030331-2.c 
Added files:
	gcc/testsuite/gcc.dg: funcdef-storage-1.c 

Log message:
	PR 12738
	PR 17205
	Radar 3460526
	Radar 3775729
	* c-decl.c (grokdeclarator): Produce error for 'static' on local
	function declaration.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.334.2.87.2.19&r2=1.334.2.87.2.20
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/compile/920625-2.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.2&r2=1.2.116.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/20010605-1.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.2&r2=1.2.92.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/execute/nest-stdar-1.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.2&r2=1.2.116.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/funcdef-storage-1.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=NONE&r2=1.2.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/20011130-1.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.1&r2=1.1.88.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/20021014-1.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.1.8.9&r2=1.1.8.9.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/20030331-2.c.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.2.4.1.8.1&r2=1.2.4.1.8.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12738