[Bug c/12690] New: Wrong comment in header

[Bug c/12690] New: Wrong comment in header

[ottavio at campana dot vi dot it]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690

           Summary: Wrong comment in header
           Product: gcc
           Version: 3.3
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ottavio at campana dot vi dot it
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i386-linux
  GCC host triplet: i386-linux
GCC target triplet: i386-linux

Ok, it's not very important, but it's an error. I was reading the file
/usr/lib/gcc-lib/i386-linux/3.3/include/mmintrin.h and I found this little error:

/* Creates a vector of four 16-bit values, all elements containing B.  */
static __inline __m64
_mm_set1_pi8 (char __b)
{
  unsigned int __w = (unsigned char)__b << 8 | (unsigned char)__b;
  unsigned int __i = __w << 16 | __w;
  return _mm_set1_pi32 (__i);
}

I don't think that the comment it's right. The __b gets duplicated in __w, then
__w gets duplicated in __i and get duplicated again in _mm_set1_pi32 . So the
comment should be:

/* Creates a vector of eight 8-bit values, all elements containing B.  */

[Bug c/12690] Wrong comment in header

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-10-20 15:30:35
               date|                            |


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-20 15:30 -------
Looks like a copy and paste error, can you send a patch to gcc-patches@ after reading http://
gcc.gnu.org/contribute.html?

[Bug c/12690] Wrong comment in header

[ottavio at campana dot vi dot it]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690



------- Additional Comments From ottavio at campana dot vi dot it  2003-10-20 16:50 -------
(From update of attachment 4964)
The patch is against 3.3.2 so that you can fix the last release

[Bug c/12690] Wrong comment in header

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690



------- Additional Comments From dhazeghi at yahoo dot com  2003-10-24 17:30 -------
Mind sending this patch to the gcc-patches@gcc.gnu.org list?

[Bug c/12690] Wrong comment in header

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-10-26 16:26 -------
Subject: Bug 12690

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	aj@gcc.gnu.org	2003-10-26 16:26:21

Modified files:
	gcc            : ChangeLog 
	gcc/config/i386: mmintrin.h 

Log message:
	2003-10-26  Ottavio Campana <ottavio@campana.vi.it>
	
	PR target/12690
	* config/i386/mmintrin.h (_mm_set1_pi8): Fix comment.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.789&r2=1.16114.2.790
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/i386/mmintrin.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.4.4.1&r2=1.4.4.2

[Bug c/12690] Wrong comment in header

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.4


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-26 16:26 -------
Fixed for 3.4.

[Bug target/12690] Wrong comment in header

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12690


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |target
   Target Milestone|3.4                         |3.3.3


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-26 16:29 -------
And fixed for 3.3.3.