[Bug libstdc++/13624] New: Unsafe delimiter in ostream_iterator

[Bug libstdc++/13624] New: Unsafe delimiter in ostream_iterator

[jlquinn at gcc dot gnu dot org]

An ostream_iterator constructed with a stream delimiter will break if the string
is destroyed since the class just stores a pointer to the constructor argument.
 I.e.

char *x = new char[4];
strcpy(x, "ugh");
ostream_iterator<int> it(cout, x);
delete[] x;
*it = 5;

A copy needs to be made for safety.  Present in 3.2, 3.3 as well.

-- 
           Summary: Unsafe delimiter in ostream_iterator
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jlquinn at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13624

[Bug libstdc++/13624] Unsafe delimiter in ostream_iterator

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-09 06:19 -------
I do not know if this is a bug (24.5.2.1 P2):
ostream_iterator(ostream_type& s, const charT* delimiter);
2 Effects: Initializes out_stream with s and delim with delimiter. 

What does it mean by "initializes".

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13624

[Bug libstdc++/13624] Unsafe delimiter in ostream_iterator

[peturr02 at ru dot is]

------- Additional Comments From peturr02 at ru dot is  2004-01-09 13:41 -------
> ostream_iterator(ostream_type& s, const charT* delimiter);
> 2 Effects: Initializes out_stream with s and delim with delimiter. 

Taken at face value, this means that the constructor should be defined
"as if":

  ostream_iterator(ostream_type& s, const charT* delimiter)
  : out_stream(s), delim(delimiter) { }

and since delim is of type const charT*, no copy will be made, so I
think the current implementation is correct. A conforming program *can*
find out if the string is copied (by modifying the charT array after
construction of the ostream_iterator), so there isn't much choice here.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13624

[Bug libstdc++/13624] Unsafe delimiter in ostream_iterator

[paolo at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 428 bytes --]


------- Additional Comments From paolo at gcc dot gnu dot org  2004-01-15 09:26 -------
Hi concur with Pétur, not a bug.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13624