[Bug c/13721] New: SEGV on inlune functions

[Bug c/13721] New: SEGV on inlune functions

[ysato at users dot sourceforge dot jp]

become SEGV when compile the this.

/* inline_test.c
   build option -O2 -mh -mint32 inline_test.c

   Result
    inline_test.c: In function `ice_func':
    inline_test.c:80: internal compiler error: Segmentation fault
*/

static __inline__ __attribute__((always_inline)) void set_bit(int nr, volatile void * addr) 
{
	volatile unsigned char *b_addr;
	b_addr = (volatile unsigned char *)addr + ((nr >> 3) ^ 3);
	nr &= 7;
	if (__builtin_constant_p (nr))					  
	{								  
		switch(nr)						  
		{							  
		case 0:							  
			__asm__("bset #0,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 1:		     					  
			__asm__("bset #1,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 2:		     					  
			__asm__("bset #2,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 3:		     					  
			__asm__("bset #3,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 4:		     					  
			__asm__("bset #4,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 5:		     					  
			__asm__("bset #5,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 6:		     					  
			__asm__("bset #6,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;	     					  
		case 7:		     					  
			__asm__("bset #7,%0" :"+m"(*b_addr) :"m"(*b_addr));
			break;						  
		}							  
	}								  
	else								  
	{								  
		__asm__("bset %w1,%0"					  
			:"+m"(*b_addr)					  
			:"g"(nr),"m"(*b_addr));				  
	}								  
}

static __inline__ __attribute__((always_inline)) int test_bit(int nr, const volatile void * addr)
{
	return (*((volatile unsigned char *)addr + ((nr >> 3) ^ 3)) & (1UL << (nr & 7))) != 0;
}

struct a {
        unsigned long a;
};

void dummy(struct a *a, int b);

int ice_func(struct a *a, int b)
{
  int c,d;
  unsigned int e;

  for(c=0;c<b;c++) {
    for(d=b; d <= b; d++) {
      if (!test_bit(d, &e)) {
        dummy(a, d * a->a);
        dummy(a, d * a->a);
        set_bit(d, &e);
      }
    }
    dummy(a, d * a->a);
  }

  return 0;
}

-- 
           Summary: SEGV on inlune functions
           Product: gcc
           Version: 3.3.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ysato at users dot sourceforge dot jp
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: linux i386
  GCC host triplet: linux i386
GCC target triplet: h8300-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug c/13721] SEGV on inlune functions

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug c/13721] SEGV on inlune functions

[dhazeghi at yahoo dot com]

------- Additional Comments From dhazeghi at yahoo dot com  2004-01-18 08:45 -------
Created an attachment (id=5513)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=5513&action=view)
slightly reduced testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug c/13721] SEGV on inline functions

[dhazeghi at yahoo dot com]

------- Additional Comments From dhazeghi at yahoo dot com  2004-01-18 08:47 -------
Still present on mainline. I do however get warned about the asm:

bash-2.05b$ gcc/cc1 -mh -mint32 -O2 -quiet foo.c 
foo.c: In function `ice_func':
foo.c:4: warning: read-write constraint does not allow a register
foo.c:4: warning: read-write constraint does not allow a register
foo.c:32: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

I'm not certain if the code is fully valid...

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-01-18 08:47:46
               date|                            |
            Summary|SEGV on inlune functions    |SEGV on inline functions


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug inline-asm/13721] SEGV on inline functions

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-18 09:25 -------
The warning is correct:
"+m"(*b_addr) :"m"(*b_addr)
really should be:
"=m"(*b_addr) :"m"(*b_addr)

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |inline-asm


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline functions

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-18 17:49 -------
Reduced source all the way:
void set_bit(int nr, char * addr)
{
  __asm__("bset %w1,%0"
          :"=m"(*addr)
          :"g"(nr),"m"(*addr));
}

The code is invalid, use "r" instead of "g" as "g" will place things in memory which causes this seg 
fault. 

w is described as:
'w' print as low byte of 32 bit value

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|inline-asm                  |target
           Keywords|ice-on-valid-code           |ice-on-invalid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[kazu at cs dot umass dot edu]

------- Additional Comments From kazu at cs dot umass dot edu  2004-01-27 00:19 -------
In this case, "m" is also incorrect because bit manipulation
instructions on h8 do not take addresses with offsets.  We can't use
"V" either because they don't take arbitrary symbols @_g.  So the only
good solution is probably to use "r" with @ in asm.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kazu at cs dot umass dot edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-02-09 17:23 -------
Subject: Bug 13721

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	kazu@gcc.gnu.org	2004-02-09 17:23:26

Modified files:
	gcc            : ChangeLog 
	gcc/config/h8300: h8300.c 

Log message:
	PR target/13721
	* config/h8300/h8300.c (byte_reg): Call abort() if asked to
	print a operand other than a register.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.2717&r2=2.2718
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/h8300/h8300.c.diff?cvsroot=gcc&r1=1.272&r2=1.273



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-02-09 17:25 -------
Subject: Bug 13721

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	kazu@gcc.gnu.org	2004-02-09 17:25:39

Modified files:
	gcc            : ChangeLog 
	gcc/config/h8300: h8300.c 

Log message:
	PR target/13721
	* config/h8300/h8300.c (byte_reg): Call abort() if asked to
	print a operand other than a register.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.163&r2=2.2326.2.164
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/h8300/h8300.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.262.2.1&r2=1.262.2.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[kazu at cs dot umass dot edu]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |kazu at cs dot umass dot edu
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[kazu at cs dot umass dot edu]

------- Additional Comments From kazu at cs dot umass dot edu  2004-02-09 17:27 -------
Just committed a fix.



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-02-09 18:28 -------
Kazu, you're bargaining an ICE with a segfault. From an user standpoint, it 
makes very little difference. GCC is expected to never ICE, whatever input is 
submitted.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-27 13:32 -------
Kazu use output_operand_lossage to point out the error, look into rs6000/rs6000.c for a 
simple usage.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2004-01-18 08:47:46         |2004-04-27 13:32:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
   Last reconfirmed|2004-04-27 13:32:21         |2004-07-27 02:55:39
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721

[Bug target/13721] SEGV on inline-asm

[prafullat at kpitcummins dot com]

------- Additional Comments From prafullat at kpitcummins dot com  2004-08-13 13:42 -------
Hi,

As suggested, I tried using "output_operand_lossage" in "print_operand" call as 
per the way it is done in rs6000/rs6000.c. The error message is displayed (not 
correctly though), but the problem is, it continues with creation of *.S file 
if compiled with option "-S". 
As this is an assembler error, no assembly output file is expected. Can anybody 
suggest why this file is being created in spite of error in assembly? 

I tried validating 'REG_P (x)' before every call to the "byte_reg" in 
function "print_operand" and if REG_P(x) is invalid (i.e. 
zero), "output_operand_lossage"  was called to display error.

Please comment.

Thanks and Regards,
Prafulla Thakare,
KPIT Cummins InfoSystems Ltd.
Pune, India

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas' SH and H8 Series.
The following site also offers free technical support to its users. 
Visit http://www.kpitgnutools.com for details. 
Latest versions of KPIT GNU tools are released on June 1, 2004.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |prafullat at kpitcummins dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13721