public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/30609] New: Calculating masks twice
@ 2007-01-27 15:30 tkoenig at gcc dot gnu dot org
2007-02-06 8:40 ` [Bug fortran/30609] " fxcoudert at gcc dot gnu dot org
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-01-27 15:30 UTC (permalink / raw)
To: gcc-bugs
In this, the expression a>0 is evaluated twice,
both in the *.original and the *.optimized dump:
function average(a, n)
real :: average
real :: a(n)
average = sum(a, a>0)/count(a>0)
end function average
$ cat average.f90.003t.original
average (a, n)
{
int4 ubound.0;
int4 size.1;
real4 __result_average;
int4 D.1012;
bit_size_type D.1013;
<unnamed type> D.1014;
ubound.0 = *n;
size.1 = NON_LVALUE_EXPR <ubound.0>;
size.1 = size.1 >= 0 ? size.1 : 0;
D.1012 = size.1 - 1;
D.1013 = (bit_size_type) (<unnamed type>) size.1 * 32;
D.1014 = (<unnamed type>) size.1 * 4;
{
int4 D.1008;
int4 count.4;
int4 D.1004;
int4 D.1003;
real4 val.2;
val.2 = 0.0;
D.1003 = ubound.0;
D.1004 = ubound.0;
{
int4 S.3;
S.3 = 1;
while (1)
{
if (S.3 > ubound.0) goto L.1;
if ((*a)[S.3 + -1] > 0.0)
{
val.2 = val.2 + (*a)[S.3 + -1];
}
S.3 = S.3 + 1;
}
L.1:;
}
count.4 = 0;
D.1008 = ubound.0;
{
int4 S.5;
S.5 = 1;
while (1)
{
if (S.5 > ubound.0) goto L.2;
if ((*a)[S.5 + -1] > 0.0)
{
count.4 = count.4 + 1;
}
S.5 = S.5 + 1;
}
L.2:;
}
__result_average = val.2 / (real4) count.4;
}
return __result_average;
}
$ cat average.f90.113t.optimized
;; Function average (average_)
Analyzing Edge Insertions.
average (a, n)
{
<unnamed type> ivtmp.49;
<unnamed type> ivtmp.44;
real4 prephitmp.36;
real4 val.2;
int4 count.4;
int4 size.1;
real4 D.1020;
<bb 2>:
size.1 = *n;
if (size.1 <= 0) goto <L39>; else goto <L37>;
<L39>:;
val.2 = 0.0;
prephitmp.36 = 0.0;
goto <bb 10> (L.2);
<L37>:;
val.2 = 0.0;
ivtmp.49 = 1;
<L4>:;
D.1020 = MEM[base: a, index: (<unnamed type>) ivtmp.49, step: 4, offset:
0x0fffffffc];
if (D.1020 > 0.0) goto <L5>; else goto <L6>;
<L5>:;
val.2 = val.2 + D.1020;
<L6>:;
ivtmp.49 = ivtmp.49 + 1;
if (size.1 < (int4) ivtmp.49) goto <L38>; else goto <L4>;
<L38>:;
count.4 = 0;
ivtmp.44 = 1;
<L9>:;
if (MEM[base: a, index: (<unnamed type>) ivtmp.44, step: 4, offset:
0x0fffffffc] > 0.0) goto <L10>; else goto <L11>;
<L10>:;
count.4 = count.4 + 1;
<L11>:;
ivtmp.44 = ivtmp.44 + 1;
if (size.1 < (int4) ivtmp.44) goto <L30>; else goto <L9>;
<L30>:;
prephitmp.36 = (real4) count.4;
L.2:;
return val.2 / prephitmp.36;
}
--
Summary: Calculating masks twice
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Keywords: missed-optimization
Severity: enhancement
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tkoenig at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30609
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/30609] Calculating masks twice
2007-01-27 15:30 [Bug fortran/30609] New: Calculating masks twice tkoenig at gcc dot gnu dot org
@ 2007-02-06 8:40 ` fxcoudert at gcc dot gnu dot org
2009-01-03 20:05 ` dfranke at gcc dot gnu dot org
2010-05-08 20:34 ` dfranke at gcc dot gnu dot org
2 siblings, 0 replies; 6+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-02-06 8:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from fxcoudert at gcc dot gnu dot org 2007-02-06 08:39 -------
Confirmed, although I'm not exactly sure how we could detect that. Maybe we
would need to add front-end optimization passes, between resolution and
translation...
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-02-06 08:39:59
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30609
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/30609] Calculating masks twice
2007-01-27 15:30 [Bug fortran/30609] New: Calculating masks twice tkoenig at gcc dot gnu dot org
2007-02-06 8:40 ` [Bug fortran/30609] " fxcoudert at gcc dot gnu dot org
@ 2009-01-03 20:05 ` dfranke at gcc dot gnu dot org
2010-05-08 20:34 ` dfranke at gcc dot gnu dot org
2 siblings, 0 replies; 6+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2009-01-03 20:05 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from dfranke at gcc dot gnu dot org 2009-01-03 20:04 -------
I wouldn't expect this to be optimized as 'a>0' creates temporary arrays in
different contexts. The same call used twice, as in PR22572, seems to be more
likely. WONTFIX?
--
dfranke at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dfranke at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30609
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/30609] Calculating masks twice
2007-01-27 15:30 [Bug fortran/30609] New: Calculating masks twice tkoenig at gcc dot gnu dot org
2007-02-06 8:40 ` [Bug fortran/30609] " fxcoudert at gcc dot gnu dot org
2009-01-03 20:05 ` dfranke at gcc dot gnu dot org
@ 2010-05-08 20:34 ` dfranke at gcc dot gnu dot org
2 siblings, 0 replies; 6+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2010-05-08 20:34 UTC (permalink / raw)
To: gcc-bugs
--
dfranke at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30609
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/30609] Calculating masks twice
[not found] <bug-30609-4@http.gcc.gnu.org/bugzilla/>
2012-12-01 10:32 ` tkoenig at gcc dot gnu.org
@ 2021-04-16 16:22 ` tkoenig at gcc dot gnu.org
1 sibling, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2021-04-16 16:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30609
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|tkoenig at gcc dot gnu.org |unassigned at gcc dot gnu.org
Status|ASSIGNED |NEW
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug fortran/30609] Calculating masks twice
[not found] <bug-30609-4@http.gcc.gnu.org/bugzilla/>
@ 2012-12-01 10:32 ` tkoenig at gcc dot gnu.org
2021-04-16 16:22 ` tkoenig at gcc dot gnu.org
1 sibling, 0 replies; 6+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2012-12-01 10:32 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30609
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |NEW
--- Comment #3 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2012-12-01 10:31:41 UTC ---
Probably something for front-end optimization,
or improved scalarization, or both.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-16 16:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-27 15:30 [Bug fortran/30609] New: Calculating masks twice tkoenig at gcc dot gnu dot org
2007-02-06 8:40 ` [Bug fortran/30609] " fxcoudert at gcc dot gnu dot org
2009-01-03 20:05 ` dfranke at gcc dot gnu dot org
2010-05-08 20:34 ` dfranke at gcc dot gnu dot org
[not found] <bug-30609-4@http.gcc.gnu.org/bugzilla/>
2012-12-01 10:32 ` tkoenig at gcc dot gnu.org
2021-04-16 16:22 ` tkoenig at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).