* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
@ 2007-10-09 22:25 ` bkoz at gcc dot gnu dot org
2007-10-09 22:38 ` bkoz at gcc dot gnu dot org
` (6 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2007-10-09 22:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from bkoz at gcc dot gnu dot org 2007-10-09 22:24 -------
Ah yes, this one.
I believe there is controversy around this implementation point on linux as
well.
Here's some info from previous discussions between myself, Ulrich, and
Johannes.
Me:
Include <sched.h> for sched_yield in <parallel/compatibility.h>. Should this be
pthread_yield or other approaches?
Uli:
Using sched_yield/pthread_yield is almost always wrong. I'd have to
look at the specific code. If you can summarize it I can easily answer
questions.
Johannes:
Well, it really helps for work-stealing algorithms, in particular if
they use more threads than there are processors available at the time,
which can change even during execution. It makes some decision based on
the current load on the machine, which requires some OS interaction.
That's the easiest and most robust way to do it.
It is probably time to resume this discussion.
--
bkoz at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |bkoz at gcc dot gnu dot org
|dot org |
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-10-09 22:24:54
date| |
Summary|libstdc++ parallel mode |__gnu_parallel::yield broken
|broken on mingw32 |on mingw32
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
2007-10-09 22:25 ` [Bug libstdc++/33578] __gnu_parallel::yield " bkoz at gcc dot gnu dot org
@ 2007-10-09 22:38 ` bkoz at gcc dot gnu dot org
2007-10-09 22:42 ` bkoz at gcc dot gnu dot org
` (5 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2007-10-09 22:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from bkoz at gcc dot gnu dot org 2007-10-09 22:38 -------
Created an attachment (id=14332)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14332&action=view)
Consistent use of _WIN32 define
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
2007-10-09 22:25 ` [Bug libstdc++/33578] __gnu_parallel::yield " bkoz at gcc dot gnu dot org
2007-10-09 22:38 ` bkoz at gcc dot gnu dot org
@ 2007-10-09 22:42 ` bkoz at gcc dot gnu dot org
2007-10-09 23:52 ` dannysmith at users dot sourceforge dot net
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2007-10-09 22:42 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from bkoz at gcc dot gnu dot org 2007-10-09 22:41 -------
Actually, I think that when I added sched.h, I forgot to look at the windows
stuff. Something seems off to me, WRT the current code. The includes don't
match the code...
Here's a patch to make the conditionals in the includes match the conditionals
in the code. I'm not quite sure how _MSC_VER fits into this, or SwitchToThread.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
` (2 preceding siblings ...)
2007-10-09 22:42 ` bkoz at gcc dot gnu dot org
@ 2007-10-09 23:52 ` dannysmith at users dot sourceforge dot net
2007-10-09 23:54 ` dannysmith at users dot sourceforge dot net
` (3 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: dannysmith at users dot sourceforge dot net @ 2007-10-09 23:52 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from dannysmith at users dot sourceforge dot net 2007-10-09 23:52 -------
Created an attachment (id=14334)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14334&action=view)
mingw32 compatibility patch
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
` (3 preceding siblings ...)
2007-10-09 23:52 ` dannysmith at users dot sourceforge dot net
@ 2007-10-09 23:54 ` dannysmith at users dot sourceforge dot net
2007-10-10 2:00 ` bkoz at gcc dot gnu dot org
` (2 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: dannysmith at users dot sourceforge dot net @ 2007-10-09 23:54 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from dannysmith at users dot sourceforge dot net 2007-10-09 23:54 -------
(In reply to comment #2)
> Created an attachment (id=14332)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14332&action=view) [edit]
> Consistent use of _WIN32 define
>
Thats not quite right. ___MINGW32__ defines _WIN32 but doesn't have an
intrin.h. I believe that is for MSVC compiler specific intrinsics. _MSC_VER
is a MSVC compiler builtin define.
Also, Cygwin __may__ define _W32 (with -mwin32 switch) but still should use
its own implementation of <sched.h> and sched_yield since it uses pthreads
I'll attach what I'm using currently. Putting more #ifdef's into this file
certainly doesn't make it any prettier. If wanted, I could prepare a patch that
gets rid of *all* the non-GNU (Windows) stuff and just put a __MINGW32__
specific definition of a __gnu_parallel::sched_yield() into os_defines.h.
FWIW, boost uses Sleep(1) -- not Sleep(0) -- for sched_yield() on windows,
while cygwin use SwitchToThread()
Dann\y
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
` (4 preceding siblings ...)
2007-10-09 23:54 ` dannysmith at users dot sourceforge dot net
@ 2007-10-10 2:00 ` bkoz at gcc dot gnu dot org
2007-10-10 23:39 ` dannysmith at gcc dot gnu dot org
2007-10-16 17:24 ` [Bug libstdc++/33578] __gnu_parallel::yield means what? bkoz at gcc dot gnu dot org
7 siblings, 0 replies; 11+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2007-10-10 2:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from bkoz at gcc dot gnu dot org 2007-10-10 02:00 -------
Danny, if this allows compilation of parallel_list.cc then please check your
patch in, as it doesn't change semantics.
Then we can figure out what we really want here....
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield broken on mingw32
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
` (5 preceding siblings ...)
2007-10-10 2:00 ` bkoz at gcc dot gnu dot org
@ 2007-10-10 23:39 ` dannysmith at gcc dot gnu dot org
2007-10-16 17:24 ` [Bug libstdc++/33578] __gnu_parallel::yield means what? bkoz at gcc dot gnu dot org
7 siblings, 0 replies; 11+ messages in thread
From: dannysmith at gcc dot gnu dot org @ 2007-10-10 23:39 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from dannysmith at gcc dot gnu dot org 2007-10-10 23:39 -------
Subject: Bug 33578
Author: dannysmith
Date: Wed Oct 10 23:39:30 2007
New Revision: 129219
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129219
Log:
PR libstdc++/33578
* include/parallel/compatibility.h. Use POSIX sched_yield on
__CYGWIN__
(Sleep): Add prototype for __MINGW32__.
Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/include/parallel/compatibility.h
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libstdc++/33578] __gnu_parallel::yield means what?
2007-09-28 0:41 [Bug libstdc++/33578] New: libstdc++ parallel mode broken on mingw32 dannysmith at users dot sourceforge dot net
` (6 preceding siblings ...)
2007-10-10 23:39 ` dannysmith at gcc dot gnu dot org
@ 2007-10-16 17:24 ` bkoz at gcc dot gnu dot org
7 siblings, 0 replies; 11+ messages in thread
From: bkoz at gcc dot gnu dot org @ 2007-10-16 17:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from bkoz at gcc dot gnu dot org 2007-10-16 17:24 -------
Changing this summary now that the mingw32 issue is fixed. Now, opening this
out to the implementation issues...
--
bkoz at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
GCC host triplet|i686-pc-mingw32 |all
GCC target triplet|i686-pc-mingw32 |all
Summary|__gnu_parallel::yield broken|__gnu_parallel::yield means
|on mingw32 |what?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33578
^ permalink raw reply [flat|nested] 11+ messages in thread