[Bug fortran/30802] New: out of bounds error in allocatable array not picked up with -fbounds-check

[Bug fortran/30802] New: out of bounds error in allocatable array not picked up with -fbounds-check

[glv at maths dot otago dot ac dot nz]

Hi All,

For the following code:
program test
real, allocatable :: pos(:,:)
allocate(pos(2,2))
pos = 0.0
print *,pos(5,:)
deallocate(pos)
end program test

when compiled with:
gfortran -fbounds-check test.f95 

the out of bounds array reference in the print command should be picked up, but
isn't.  

Also fails in the same way using g95.

Replacing pos(5,:) with pos(5,1) is picked up.

Thanks, Gareth


-- 
           Summary: out of bounds error in allocatable array not picked up
                    with -fbounds-check
           Product: gcc
           Version: 4.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: glv at maths dot otago dot ac dot nz
 GCC build triplet: x86_64-redhat-linux
  GCC host triplet: x86_64-redhat-linux
GCC target triplet: x86_64-redhat-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error in allocatable array not picked up with -fbounds-check

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |27766
              nThis|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|x86_64-redhat-linux         |
   GCC host triplet|x86_64-redhat-linux         |
 GCC target triplet|x86_64-redhat-linux         |
           Keywords|                            |diagnostic
      Known to fail|                            |4.1.2 4.2.0 4.3.0
   Last reconfirmed|0000-00-00 00:00:00         |2007-02-15 00:52:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error in allocatable array not picked up with -fbounds-check

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2007-03-07 07:23 -------
*** Bug 31059 has been marked as a duplicate of this bug. ***


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vivekrao4 at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error in allocatable array not picked up with -fbounds-check

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-02-15 00:52:59         |2007-05-09 08:09:27
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error in allocatable array not picked up with -fbounds-check

[fxcoudert at gcc dot gnu dot org]

------- Comment #2 from fxcoudert at gcc dot gnu dot org  2007-08-06 21:13 -------
It's not about being allocatable, it's the I/O operation that doesn't perform
the necessary check:

$ cat a.f90
  real :: x(2,2)
  x = 0.
  print *, x(5,:)
  x(5,:) = 1.
end
$ gfortran -fbounds-check a.f90 && ./a.out
   0.000000      5.8787666E-39
At line 4 of file a.f90
Fortran runtime error: Array reference out of bounds for array 'x', upper bound
of dimension 1  exceeded


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|fxcoudert at gcc dot gnu dot|unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[tkoenig at gcc dot gnu dot org]

------- Comment #3 from tkoenig at gcc dot gnu dot org  2007-12-17 22:23 -------
I think the problem is that we don't insert bounds checking
in gfc_conv_expr_descriptor.

Another test case:

$ cat index.f90 
module bar
contains
  subroutine foo(a)
  real, dimension(:) :: a
  a = 3.
  end subroutine foo
end module bar
program main
  use bar
  real, dimension(2,2) :: a
  n = 3
  call foo(a(n,:))
end program main
$ gfortran index.f90 
$ gfortran -fbounds-check index.f90 
$ ./a.out


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2010-04-18 15:31 -------
Re-confirmed.

We have no bounds checking code in fortran/io.c nor in the I/O library.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=97039

--- Comment #9 from anlauf at gcc dot gnu.org ---
(In reply to markeggleston from comment #8)
> Changing to allocated arrays and bounds checking does not work at compile
> time but does at runtime:
> 
> program test
> real, allocatable :: x(:)
> allocate(x(10))
> x = 0.0
> print *, x(0)
> deallocate(x)
> end program test
> 
> $ gfortran -fbounds-check pr30802.f90
> $ ./a.out
> 
> At line 5 of file pr30802.f90
> Fortran runtime error: Index '0' of dimension 1 of array 'x' below lower
> bound of 1
> 
> Error termination. Backtrace:
> #0  0x400ea1 in ???
> #1  0x400f6d in ???
> #2  0x4380b2 in ???
> #3  0x438471 in ???
> #4  0x400c69 in ???

I think the point is that bounds-checking does not work for sections of rank-2
arrays.  See also PR97039.

This is not I/O specific, but what Thomas said in comment#3.

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #10 from anlauf at gcc dot gnu.org ---
I am working on a patch.

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

--- Comment #11 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-September/059756.html

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:1cbf18978aa384bd0ed2dc29b107fc3423cf8e62

commit r14-4039-g1cbf18978aa384bd0ed2dc29b107fc3423cf8e62
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Fri Sep 15 19:13:38 2023 +0200

    Fortran: improve bounds-checking for array sections [PR30802]

    gcc/fortran/ChangeLog:

            PR fortran/30802
            * trans-array.cc (trans_array_bound_check): Add optional argument
            COMPNAME for explicit specification of array component name.
            (array_bound_check_elemental): Helper function for generating
            bounds-checking code for elemental dimensions.
            (gfc_conv_expr_descriptor): Use bounds-checking also for elemental
            dimensions, i.e. those not handled by the scalarizer.

    gcc/testsuite/ChangeLog:

            PR fortran/30802
            * gfortran.dg/bounds_check_fail_6.f90: New test.

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anthony.debeus at gmail dot com

--- Comment #13 from anlauf at gcc dot gnu.org ---
*** Bug 97039 has been marked as a duplicate of this bug. ***

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |14.0

--- Comment #14 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-14.

[Bug fortran/30802] out of bounds error array I/O not picked up with -fbounds-check

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30802

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:509352069d6f166d396f4b4a86e71ea521f2ca78

commit r14-9597-g509352069d6f166d396f4b4a86e71ea521f2ca78
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Mar 20 20:59:24 2024 +0100

    Fortran: improve array component description in runtime error message
[PR30802]

    Runtime error messages for array bounds violation shall use the following
    scheme for a coherent, abridged description of arrays or array components
    of derived types:
    (1) If x is an ordinary array variable, use "x"
    (2) if z is a DT scalar and x an array component at level 1, use "z%x"
    (3) if z is a DT scalar and x an array component at level > 1, or
        if z is a DT array and x an array (at any level), use "z...%x"
    Use a new helper function abridged_ref_name for construction of that name.

    gcc/fortran/ChangeLog:

            PR fortran/30802
            * trans-array.cc (abridged_ref_name): New helper function.
            (trans_array_bound_check): Use it.
            (array_bound_check_elemental): Likewise.
            (gfc_conv_array_ref): Likewise.

    gcc/testsuite/ChangeLog:

            PR fortran/30802
            * gfortran.dg/bounds_check_17.f90: Adjust pattern.
            * gfortran.dg/bounds_check_fail_8.f90: New test.