[Bug other/35250] New: gmp and mpfr are erroneously configured with --target

[Bug other/35250] New: gmp and mpfr are erroneously configured with --target

[nightstrike at gmail dot com]

When gmp and mpfr are in the build tree of gcc, they will be automatically
configured and build.  However, some of the options passed to configure are
incorrect according to the GMP manual:

[Begin quote] "Note that the `--target' option is not appropriate for
GMP. It's for use when building compiler tools, with `--host' being
where they will run, and `--target' what they'll produce code for.
Ordinary programs or libraries like GMP are only interested in the
`--host' part, being where they'll run. (Some past versions of GMP
used `--target' incorrectly.)" [End quote]


"--target" should be removed from both configure lines.  Here is the
Makefile.def that I was looking at:

host_modules= { module= gmp; lib_path=.libs; bootstrap=true;
               extra_configure_flags='--disable-shared';
               no_install= true;
               host="none-${host_vendor}-${host_os}";
               target="none-${host_vendor}-${host_os}"; };
host_modules= { module= mpfr; lib_path=.libs; bootstrap=true;
               extra_configure_flags='--disable-shared
--with-gmp-build=$$r/$(HOST_SUBDIR)/gmp';
               no_install= true;
               host="none-${host_vendor}-${host_os}";
               target="none-${host_vendor}-${host_os}"; };


Here is a patch:

Index: Makefile.def
===================================================================
--- Makefile.def        (revision 132380)
+++ Makefile.def        (working copy)
@@ -61,13 +61,11 @@ host_modules= { module= gettext; };
 host_modules= { module= gmp; lib_path=.libs; bootstrap=true;
                extra_configure_flags='--disable-shared';
                no_install= true;
-               host="none-${host_vendor}-${host_os}";
-               target="none-${host_vendor}-${host_os}"; };
+               host="none-${host_vendor}-${host_os}"; };
 host_modules= { module= mpfr; lib_path=.libs; bootstrap=true;
                extra_configure_flags='--disable-shared
--with-gmp-build=$$r/$(HOST_SUBDIR)/gmp';
                no_install= true;
-               host="none-${host_vendor}-${host_os}";
-               target="none-${host_vendor}-${host_os}"; };
+               host="none-${host_vendor}-${host_os}"; };
 host_modules= { module= gnuserv; };
 host_modules= { module= gprof; };
 host_modules= { module= gzip; };


-- 
           Summary: gmp and mpfr are erroneously configured with --target
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P3
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: nightstrike at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[nightstrike at gmail dot com]

------- Comment #1 from nightstrike at gmail dot com  2008-02-19 05:32 -------
Here is the email thread that started it all:

http://gcc.gnu.org/ml/gcc-help/2008-02/msg00197.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[nightstrike at gmail dot com]

------- Comment #2 from nightstrike at gmail dot com  2008-02-24 03:31 -------
This is a very simple fix.  Can someone add it?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[rwild at gcc dot gnu dot org]

------- Comment #3 from rwild at gcc dot gnu dot org  2008-02-24 09:06 -------
Can you post the patch to the gcc-patches list for review, including ChangeLog
entry and reference to this PR?

Note that, while I think it would be prudent if GMP did AC_MSG_WARN rather
than AC_MSG_ERROR for this, erroring out is in accordance with the GNU Coding
Standards which state:

|    The target type normally defaults to the host type.  Programs for
| which cross-operation is not meaningful need not accept the `--target'
| option, because configuring an entire operating system for
| cross-operation is not a meaningful operation.

(which may just as well mean that the GCS should be fixed?)


-- 

rwild at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Ralf dot Wildenhues at gmx
                   |                            |dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |build, patch
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-24 09:45:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[bonzini at gnu dot org]

------- Comment #4 from bonzini at gnu dot org  2008-03-11 13:53 -------
The patch does not remove the --target option.  It just causes the "real"
--target option (which is not equal to the host if we're building a cross) to
be passed down to gmp/mpfr.

Does this issue actually cause a build failure?  If not, there's no reason to
change.


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bonzini at gnu dot org
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[bonzini at gnu dot org]

------- Comment #5 from bonzini at gnu dot org  2008-03-11 13:56 -------
Also, I would like to understand what does the "Some past versions of GMP used 
`--target' incorrectly" part mean.  Does it mean that those past versions
changed their configuration according to `--target', instead of `--host'?  That
would actually be a reason to *leave* the --target option in, rather than
remove it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250

[Bug other/35250] gmp and mpfr are erroneously configured with --target

[bonzini at gnu dot org]

------- Comment #6 from bonzini at gnu dot org  2008-08-15 06:01 -------
if it ain't broken, don't fix it.


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35250