public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/46244] gfc_compare_derived_types is buggy Date: Sat, 30 Oct 2010 15:04:00 -0000 [thread overview] Message-ID: <20101030150400.4mEvfcBS4JaoEgNdq2GD9XThZh7j1paYfOXffu6gBnc@z> (raw) In-Reply-To: <bug-46244-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46244 --- Comment #3 from janus at gcc dot gnu.org 2010-10-30 15:04:29 UTC --- The test case in comment #1 can be fixed by: Index: gcc/fortran/interface.c =================================================================== --- gcc/fortran/interface.c (revision 166089) +++ gcc/fortran/interface.c (working copy) @@ -424,6 +424,11 @@ gfc_compare_derived_types (gfc_symbol *derived1, g match. */ for (;;) { + if (dt1 == NULL && dt2 == NULL) + break; + if (dt1 == NULL || dt2 == NULL) + return 0; + if (strcmp (dt1->name, dt2->name) != 0) return 0; @@ -459,11 +464,6 @@ gfc_compare_derived_types (gfc_symbol *derived1, g dt1 = dt1->next; dt2 = dt2->next; - - if (dt1 == NULL && dt2 == NULL) - break; - if (dt1 == NULL || dt2 == NULL) - return 0; } return 1;
next prev parent reply other threads:[~2010-10-30 15:04 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-30 14:24 [Bug fortran/46244] New: " janus at gcc dot gnu.org 2010-10-30 14:30 ` [Bug fortran/46244] " janus at gcc dot gnu.org 2010-10-30 14:54 ` janus at gcc dot gnu.org 2010-10-30 15:04 ` janus at gcc dot gnu.org [this message] 2010-10-30 15:11 ` janus at gcc dot gnu.org 2010-10-30 16:02 ` mikael at gcc dot gnu.org 2010-10-30 16:04 ` mikael at gcc dot gnu.org 2010-11-05 13:56 ` dominiq at lps dot ens.fr 2010-11-05 15:01 ` burnus at gcc dot gnu.org 2010-11-06 13:00 ` burnus at gcc dot gnu.org 2010-11-10 17:45 ` burnus at gcc dot gnu.org 2010-11-10 17:49 ` burnus at gcc dot gnu.org 2011-02-20 16:58 ` mikael at gcc dot gnu.org 2011-02-20 17:01 ` mikael at gcc dot gnu.org 2011-02-20 21:07 ` dominiq at lps dot ens.fr 2011-02-20 22:20 ` dominiq at lps dot ens.fr 2011-02-20 23:18 ` mikael at gcc dot gnu.org 2011-02-21 9:37 ` paul.richard.thomas at gmail dot com 2011-10-02 17:47 ` dominiq at lps dot ens.fr 2011-10-02 22:06 ` mikael at gcc dot gnu.org 2024-01-19 18:00 ` mikael at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101030150400.4mEvfcBS4JaoEgNdq2GD9XThZh7j1paYfOXffu6gBnc@z \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).