public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "paul.richard.thomas at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/46244] gfc_compare_derived_types is buggy
Date: Mon, 21 Feb 2011 09:37:00 -0000	[thread overview]
Message-ID: <bug-46244-4-VCeyCY9TAj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-46244-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46244

--- Comment #16 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> 2011-02-21 08:25:51 UTC ---
Dear Mikael,

....snip....

> Actually none of the gfc_compare_type/gfc_TK_compatible changes are absolutely
> necessary to fix this bug. It is just I found it odd that gfc_compare_type was
> calling gfc_type_compatible (compatible types are not necessary
> equal/equivalent), so I changed it so that gfc_type_compatible calls
> gfc_compare_type instead. And then the new gfc_TK_compatible function to not
> upset the testsuite.
>
> Maybe I just don't understand what "compare types" means. :-(

....snip....

> Hem, yes, who wrote this? ( I hope it's not me ;-) ).

There have been a number of contributors over the years.  Therein lies
the problem.  Quick fix has been piled on quick fix and the result is
something of a mess.

"It is just I found it odd that gfc_compare_type was calling
gfc_type_compatible (compatible types are not necessary
equal/equivalent), so I changed it so that gfc_type_compatible calls
gfc_compare_type instead."

That was indeed very peculiar.  I know who the culprit was but I am
not telling :-)

If you have time to put this right I, for one, would be very pleased.

A

Paul


  parent reply	other threads:[~2011-02-21  8:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-30 14:24 [Bug fortran/46244] New: " janus at gcc dot gnu.org
2010-10-30 14:30 ` [Bug fortran/46244] " janus at gcc dot gnu.org
2010-10-30 14:54 ` janus at gcc dot gnu.org
2010-10-30 15:04 ` janus at gcc dot gnu.org
2010-10-30 15:11 ` janus at gcc dot gnu.org
2010-10-30 16:02 ` mikael at gcc dot gnu.org
2010-10-30 16:04 ` mikael at gcc dot gnu.org
2010-11-05 13:56 ` dominiq at lps dot ens.fr
2010-11-05 15:01 ` burnus at gcc dot gnu.org
2010-11-06 13:00 ` burnus at gcc dot gnu.org
2010-11-10 17:45 ` burnus at gcc dot gnu.org
2010-11-10 17:49 ` burnus at gcc dot gnu.org
2011-02-20 16:58 ` mikael at gcc dot gnu.org
2011-02-20 17:01 ` mikael at gcc dot gnu.org
2011-02-20 21:07 ` dominiq at lps dot ens.fr
2011-02-20 22:20 ` dominiq at lps dot ens.fr
2011-02-20 23:18 ` mikael at gcc dot gnu.org
2011-02-21  9:37 ` paul.richard.thomas at gmail dot com [this message]
2011-10-02 17:47 ` dominiq at lps dot ens.fr
2011-10-02 22:06 ` mikael at gcc dot gnu.org
2024-01-19 18:00 ` mikael at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-46244-4-VCeyCY9TAj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).