public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/100056] [9/10/11 Regression] orr + lsl vs. [us]bfiz Date: Thu, 15 Apr 2021 08:48:01 +0000 [thread overview] Message-ID: <bug-100056-4-4iADC9Se1v@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100056-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100056 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:39d23b7960e4efb11bbe1eff056ae9da0884c539 commit r11-8188-g39d23b7960e4efb11bbe1eff056ae9da0884c539 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Apr 15 10:45:09 2021 +0200 aarch64: Fix several *<LOGICAL:optab>_ashl<mode>3 related regressions [PR100056] Before combiner added 2 to 2 combinations, the following testcase functions have been all compiled into 2 instructions, zero/sign extensions or and followed by orr with lsl, e.g. for the first function Trying 7 -> 8: 7: r96:SI=r94:SI<<0xb 8: r95:SI=r96:SI|r94:SI REG_DEAD r96:SI REG_DEAD r94:SI Successfully matched this instruction: (set (reg:SI 95) (ior:SI (ashift:SI (reg/v:SI 94 [ i ]) (const_int 11 [0xb])) (reg/v:SI 94 [ i ]))) is the important successful try_combine and so we end up with and w0, w0, 255 orr w0, w0, w0, lsl 11 in the body. With 2 to 2 combination, before that can trigger, another successful combination: Trying 2 -> 7: 2: r94:SI=zero_extend(x0:QI) REG_DEAD x0:QI 7: r96:SI=r94:SI<<0xb is replaced with: (set (reg/v:SI 94 [ i ]) (zero_extend:SI (reg:QI 0 x0 [ i ]))) and (set (reg:SI 96) (and:SI (ashift:SI (reg:SI 0 x0 [ i ]) (const_int 11 [0xb])) (const_int 522240 [0x7f800]))) and in the end results in 3 instructions in the body: and w1, w0, 255 ubfiz w0, w0, 11, 8 orr w0, w0, w1 The following combine splitters help undo that when combiner tries to combine 3 instructions - the zero/sign extend or and, the other insn from the 2 to 2 combination ([us]bfiz) and the logical op, the CPUs don't have an insn to do everything in one op, but we can split it back into the zero/sign extend or and followed by logical with lsl. 2021-04-15 Jakub Jelinek <jakub@redhat.com> PR target/100056 * config/aarch64/aarch64.md (*<LOGICAL:optab>_<SHIFT:optab><mode>3): Add combine splitters for *<LOGICAL:optab>_ashl<mode>3 with ZERO_EXTEND, SIGN_EXTEND or AND. * gcc.target/aarch64/pr100056.c: New test.
next prev parent reply other threads:[~2021-04-15 8:48 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 0:09 [Bug target/100056] New: [9/10/11 Regression] luc.vanoostenryck at gmail dot com 2021-04-13 8:07 ` [Bug target/100056] [9/10/11 Regression] orr + lsl vs. [us]bfiz jakub at gcc dot gnu.org 2021-04-13 8:21 ` rguenth at gcc dot gnu.org 2021-04-13 10:55 ` jakub at gcc dot gnu.org 2021-04-13 12:34 ` jakub at gcc dot gnu.org 2021-04-13 15:34 ` luc.vanoostenryck at gmail dot com 2021-04-13 15:51 ` luc.vanoostenryck at gmail dot com 2021-04-13 15:55 ` luc.vanoostenryck at gmail dot com 2021-04-13 16:03 ` luc.vanoostenryck at gmail dot com 2021-04-13 18:02 ` jakub at gcc dot gnu.org 2021-04-15 8:48 ` cvs-commit at gcc dot gnu.org [this message] 2021-04-15 8:49 ` [Bug target/100056] [9/10 " jakub at gcc dot gnu.org 2021-04-16 3:44 ` luc.vanoostenryck at gmail dot com 2021-06-01 8:20 ` rguenth at gcc dot gnu.org 2022-02-15 16:08 ` rsandifo at gcc dot gnu.org 2022-02-16 10:21 ` cvs-commit at gcc dot gnu.org 2022-05-27 9:45 ` [Bug target/100056] [10 " rguenth at gcc dot gnu.org 2022-06-28 10:44 ` jakub at gcc dot gnu.org 2023-07-07 9:34 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100056-4-4iADC9Se1v@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).