public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/100056] [9/10/11 Regression]  orr + lsl vs. [us]bfiz
Date: Tue, 13 Apr 2021 10:55:48 +0000	[thread overview]
Message-ID: <bug-100056-4-DEBlUIZd7u@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100056-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100056

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So, the change is that previously there was just one significant combination,
Trying 7 -> 8:
    7: r96:SI=r94:SI<<0xb
    8: r95:SI=r96:SI|r94:SI
      REG_DEAD r96:SI
      REG_DEAD r94:SI
Successfully matched this instruction:
(set (reg:SI 95)
    (ior:SI (ashift:SI (reg/v:SI 94 [ i ])
            (const_int 11 [0xb]))
        (reg/v:SI 94 [ i ])))
With the addition of 2 to 2 combination,
Trying 2 -> 7:
    2: r94:SI=zero_extend(x0:QI)
      REG_DEAD x0:QI
    7: r96:SI=r94:SI<<0xb
is replaced with:
(set (reg/v:SI 94 [ i ])
    (zero_extend:SI (reg:QI 0 x0 [ i ])))
and
(set (reg:SI 96)
    (and:SI (ashift:SI (reg:SI 0 x0 [ i ])
            (const_int 11 [0xb]))
        (const_int 522240 [0x7f800])))
and therefore the combination that was successful earlier no longer triggers.
So, I think it would be helpful to have a combiner splitter that would split
Trying 7, 2 -> 8:
    7: r96:SI=x0:SI<<0xb&0x7f800
      REG_DEAD x0:QI
    2: r94:SI=zero_extend(x0:QI)
    8: r95:SI=r96:SI|r94:SI
the zero_extend and
(set (reg:SI 95)
    (ior:SI (ashift:SI (reg/v:SI 94 [ i ])
            (const_int 11 [0xb]))
        (reg/v:SI 94 [ i ])))

  parent reply	other threads:[~2021-04-13 10:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  0:09 [Bug target/100056] New: [9/10/11 Regression] luc.vanoostenryck at gmail dot com
2021-04-13  8:07 ` [Bug target/100056] [9/10/11 Regression] orr + lsl vs. [us]bfiz jakub at gcc dot gnu.org
2021-04-13  8:21 ` rguenth at gcc dot gnu.org
2021-04-13 10:55 ` jakub at gcc dot gnu.org [this message]
2021-04-13 12:34 ` jakub at gcc dot gnu.org
2021-04-13 15:34 ` luc.vanoostenryck at gmail dot com
2021-04-13 15:51 ` luc.vanoostenryck at gmail dot com
2021-04-13 15:55 ` luc.vanoostenryck at gmail dot com
2021-04-13 16:03 ` luc.vanoostenryck at gmail dot com
2021-04-13 18:02 ` jakub at gcc dot gnu.org
2021-04-15  8:48 ` cvs-commit at gcc dot gnu.org
2021-04-15  8:49 ` [Bug target/100056] [9/10 " jakub at gcc dot gnu.org
2021-04-16  3:44 ` luc.vanoostenryck at gmail dot com
2021-06-01  8:20 ` rguenth at gcc dot gnu.org
2022-02-15 16:08 ` rsandifo at gcc dot gnu.org
2022-02-16 10:21 ` cvs-commit at gcc dot gnu.org
2022-05-27  9:45 ` [Bug target/100056] [10 " rguenth at gcc dot gnu.org
2022-06-28 10:44 ` jakub at gcc dot gnu.org
2023-07-07  9:34 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100056-4-DEBlUIZd7u@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).