[Bug libstdc++/100117] New: FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[Bug libstdc++/100117] New: FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

            Bug ID: 100117
           Summary: FAIL testsuite/17_intro/headers/c++1998/49745.cc with
                    trunk glibc
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

I have seen (with r11-7986 , so sorry if it has been fixed already)
FAIL: 17_intro/headers/c++1998/49745.cc (test for excess errors)
which appears only when built against latest glibc 2.34 snapshot and works fine
against glibc 2.33.
libstdc++.log contains:
/builddir/build/BUILD/gcc-11.0.1-20210405/libstdc++-v3/testsuite/17_intro/headers/c++1998/49745.cc:22:
error: 'int truncate' redeclared as different kind of entity
In file included from /usr/include/bits/sigstksz.h:24,
                 from /usr/include/signal.h:315,
                 from
/builddir/build/BUILD/gcc-11.0.1-20210405/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/include/csignal:42,
                 from
/builddir/build/BUILD/gcc-11.0.1-20210405/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/include/x86_64-redhat-linux/bits/stdc++.h:43,
                 from <command-line>:
/usr/include/unistd.h:1005: note: previous declaration 'int truncate(const
char*, __off_t)'

Maybe it would be nice if bits/sigstksz.h didn't include whole unistd.h but
just
bits/confname.h and used some __ prefixed alias with redirection for the
sysconf call?

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[fw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

--- Comment #1 from Florian Weimer <fw at gcc dot gnu.org> ---
This looks like the old C++ _GNU_SOURCE issue.

But I do not really see why <iostream> includes <csignal>. Is this some PCH
test?

Should <stdc++.h> really include all the C headers?

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
<iostream> doesn't include <csignal> AFAIK.
<bits/stdc++.h> is a non-standard header that just includes all standard C++
headers (except for <execution> it seems).
And it is <csignal> that now newly (in glibc 2.34) indirectly includes
<unistd.h> when it didn't before.

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[fw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

--- Comment #3 from Florian Weimer <fw at gcc dot gnu.org> ---
I was looking at the 17_intro/headers/c++1998/49745.cc file contents and can't
make sense of the error message in that context. There's no <csignal> in it.

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=99995

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
<bits/stdc++.h> includes all standard headers, including <csignal>.

Maybe for the purposes of that test, what we should really check is that none
of the C++ headers (i.e. all except <foo.h> and <cfoo>) includes <unistd.h>.

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

Sergei Trofimovich <slyfox at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slyfox at gcc dot gnu.org

--- Comment #5 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Also happens with released glibc-2.34.

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:77963796aef8aa07993c0bc757c15848fab7432a

commit r12-5109-g77963796aef8aa07993c0bc757c15848fab7432a
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Nov 10 11:43:46 2021 +0000

    libstdc++: Fix test for libstdc++ not including <unistd.h> [PR100117]

    The <cxxx> headers for the C library are not under our control, so we
    can't prevent them from including <unistd.h>. Change the PR 49745 test
    to only include the C++ library headers, not the <cxxx> ones.

    To ensure <bits/stdc++.h> isn't included automatically we need to use
    no_pch to disable PCH.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100117
            * testsuite/17_intro/headers/c++1998/49745.cc: Explicitly list
            all C++ headers instead of including <bits/stdc++.h>

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Target Milestone|---                         |9.5
   Last reconfirmed|                            |2021-11-10

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This should be fixed on trunk now.

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:176e55cc28a61b7b246bd9e16ffeaa31367a8985

commit r11-9277-g176e55cc28a61b7b246bd9e16ffeaa31367a8985
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Nov 10 11:43:46 2021 +0000

    libstdc++: Fix test for libstdc++ not including <unistd.h> [PR100117]

    The <cxxx> headers for the C library are not under our control, so we
    can't prevent them from including <unistd.h>. Change the PR 49745 test
    to only include the C++ library headers, not the <cxxx> ones.

    To ensure <bits/stdc++.h> isn't included automatically we need to use
    no_pch to disable PCH.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100117
            * testsuite/17_intro/headers/c++1998/49745.cc: Explicitly list
            all C++ headers instead of including <bits/stdc++.h>

    (cherry picked from commit 77963796aef8aa07993c0bc757c15848fab7432a)

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:436891d97aef6d7a8e107d2d3e02e8ca4c52a51a

commit r10-10571-g436891d97aef6d7a8e107d2d3e02e8ca4c52a51a
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 12 11:12:47 2021 +0100

    libstdc++: Fix test for libstdc++ not including <unistd.h> [PR100117]

    The <cxxx> headers for the C library are not under our control, so we
    can't prevent them from including <unistd.h>. Change the PR 49745 test
    to only include the C++ library headers, not the <cxxx> ones.

    To ensure <bits/stdc++.h> isn't included automatically we need to use
    no_pch to disable PCH.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100117
            * testsuite/17_intro/headers/c++1998/49745.cc: Explicitly list
            all C++ headers instead of including <bits/stdc++.h>

    (cherry picked from commit 77963796aef8aa07993c0bc757c15848fab7432a)

[Bug libstdc++/100117] FAIL testsuite/17_intro/headers/c++1998/49745.cc with trunk glibc

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100117

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|9.5                         |10.4
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for GCC 10.4.