[Bug fortran/100136] New: ICE, regression, using flag -fcheck=pointer

[Bug fortran/100136] New: ICE, regression, using flag -fcheck=pointer

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

            Bug ID: 100136
           Summary: ICE, regression, using flag -fcheck=pointer
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jrfsousa at gmail dot com
  Target Milestone: ---

Created attachment 50623
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50623&action=edit
Fortran code showing problem

Hi All!

ICE using flag -fcheck=pointer.

Seen on:

GNU Fortran (GCC) 11.0.1 20210417 (experimental)

Older versions don't ICE, but don't do any checking either...

Thank you very much.

Best regards,
José Rui

[Bug fortran/100136] [11 Regression] ICE, regression, using flag -fcheck=pointer

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE, regression, using flag |[11 Regression] ICE,
                   |-fcheck=pointer             |regression, using flag
                   |                            |-fcheck=pointer
      Known to fail|                            |11.0
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-04-19
      Known to work|                            |10.3.0
                 CC|                            |anlauf at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org,
                   |                            |pault at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
           Priority|P3                          |P4

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-7661-gc2d7c39fcb8a3cb6.

[Bug fortran/100136] [11 Regression] ICE, regression, using flag -fcheck=pointer

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

--- Comment #2 from anlauf at gcc dot gnu.org ---
We do not properly handle the VALUE attribute.

Reduced testcase:

program p
  implicit none
  class(*), allocatable :: d
  call add_class (d)
contains
  subroutine add_class (d)
    class(*), value :: d
  end subroutine
end program

[Bug fortran/100136] [11/12 Regression] ICE, regression, using flag -fcheck=pointer

[jrfsousa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

--- Comment #3 from José Rui Faustino de Sousa <jrfsousa at gmail dot com> ---
Only handles the ICE...

Patch posted:

https://gcc.gnu.org/pipermail/fortran/2021-April/055949.html

[Bug fortran/100136] [11/12 Regression] ICE, regression, using flag -fcheck=pointer

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.2

[Bug fortran/100136] [11/12 Regression] ICE, regression, using flag -fcheck=pointer

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.2                        |11.3

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.2 is being released, retargeting bugs to GCC 11.3

[Bug fortran/100136] [11/12 Regression] ICE, regression, using flag -fcheck=pointer

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.3                        |11.4

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.3 is being released, retargeting bugs to GCC 11.4.

[Bug fortran/100136] [11/12/13 Regression] ICE, regression, using flag -fcheck=pointer

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code

--- Comment #6 from anlauf at gcc dot gnu.org ---
(In reply to José Rui Faustino de Sousa from comment #3)
> Only handles the ICE...
> 
> Patch posted:
> 
> https://gcc.gnu.org/pipermail/fortran/2021-April/055949.html

Hi Jose,

unfortunately it appears that your patch was never reviewed,
and you did not ping it.

I think the patch is mostly fine, but that it should use
POINTER_TYPE_P (TREE_TYPE (tmp)), so that it reads (adjusted to mainline):

diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc
index 850007fd2e1..e35ea2fc790 100644
--- a/gcc/fortran/trans-expr.cc
+++ b/gcc/fortran/trans-expr.cc
@@ -7220,16 +7220,15 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
              else
                goto end_pointer_check;

+             tmp = parmse.expr;
              if (fsym && fsym->ts.type == BT_CLASS)
                {
-                 tmp = build_fold_indirect_ref_loc (input_location,
-                                                     parmse.expr);
+                 if (POINTER_TYPE_P (TREE_TYPE (tmp)))
+                   tmp = build_fold_indirect_ref_loc (input_location, tmp);
                  tmp = gfc_class_data_get (tmp);
                  if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp)))
                    tmp = gfc_conv_descriptor_data_get (tmp);
                }
-             else
-               tmp = parmse.expr;

              /* If the argument is passed by value, we need to strip the
                 INDIRECT_REF.  */

Are you still working on gfortran?  Or should I pick up your patch and resubmit
for you?

[Bug fortran/100136] [11/12/13 Regression] ICE, regression, using flag -fcheck=pointer

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:20d30e737ad79dc36817e59f1676aa8bc0c6b325

commit r13-2397-g20d30e737ad79dc36817e59f1676aa8bc0c6b325
Author: José Rui Faustino de Sousa <jrfsousa@gmail.com>
Date:   Sun Sep 4 21:53:09 2022 +0200

    Fortran: Fix ICE with -fcheck=pointer [PR100136]

    gcc/fortran/ChangeLog:

            PR fortran/100136
            * trans-expr.cc (gfc_conv_procedure_call): Add handling of pointer
            expressions.

    gcc/testsuite/ChangeLog:

            PR fortran/100136
            * gfortran.dg/PR100136.f90: New test.

[Bug fortran/100136] [11/12/13 Regression] ICE, regression, using flag -fcheck=pointer

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:c1ba36ec779cccf6b54883d676d083df627f6d64

commit r12-8743-gc1ba36ec779cccf6b54883d676d083df627f6d64
Author: José Rui Faustino de Sousa <jrfsousa@gmail.com>
Date:   Sun Sep 4 21:53:09 2022 +0200

    Fortran: Fix ICE with -fcheck=pointer [PR100136]

    gcc/fortran/ChangeLog:

            PR fortran/100136
            * trans-expr.cc (gfc_conv_procedure_call): Add handling of pointer
            expressions.

    gcc/testsuite/ChangeLog:

            PR fortran/100136
            * gfortran.dg/PR100136.f90: New test.

    (cherry picked from commit 20d30e737ad79dc36817e59f1676aa8bc0c6b325)

[Bug fortran/100136] [11/12/13 Regression] ICE, regression, using flag -fcheck=pointer

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:4cd0cc099cf6be818f4af1f88ce11dbfe4022dab

commit r11-10237-g4cd0cc099cf6be818f4af1f88ce11dbfe4022dab
Author: José Rui Faustino de Sousa <jrfsousa@gmail.com>
Date:   Sun Sep 4 21:53:09 2022 +0200

    Fortran: Fix ICE with -fcheck=pointer [PR100136]

    gcc/fortran/ChangeLog:

            PR fortran/100136
            * trans-expr.c (gfc_conv_procedure_call): Add handling of pointer
            expressions.

    gcc/testsuite/ChangeLog:

            PR fortran/100136
            * gfortran.dg/PR100136.f90: New test.

    (cherry picked from commit 20d30e737ad79dc36817e59f1676aa8bc0c6b325)

[Bug fortran/100136] [11/12/13 Regression] ICE, regression, using flag -fcheck=pointer

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100136

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from anlauf at gcc dot gnu.org ---
Thanks for the report and the patch!  Closing.