[Bug target/100208] New: amdgcn fails to build with llvm-mc from llvm12

[Bug target/100208] New: amdgcn fails to build with llvm-mc from llvm12

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

            Bug ID: 100208
           Summary: amdgcn fails to build with llvm-mc from llvm12
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

It fails configuring the target libgcc for the gfx908 multilib like

configure:3566:
/home/abuild/rpmbuild/BUILD/gcc-11.0.1+git10/obj-x86_64-suse-linux/./gcc/xgcc
-B/home/abuild/rpmbuild/BUILD/gcc-11.0.1+git10/obj-x86_64-suse-linux/./gcc/
-nostdinc
-B/home/abuild/rpmbuild/BUILD/gcc-11.0.1+git10/obj-x86_64-suse-linux/amdgcn-amdhsa/gfx908/newlib/
-isystem
/home/abuild/rpmbuild/BUILD/gcc-11.0.1+git10/obj-x86_64-suse-linux/amdgcn-amdhsa/gfx908/newlib/targ-include
-isystem /home/abuild/rpmbuild/BUILD/gcc-11.0.1+git10/newlib/libc/include
-B/usr/amdgcn-amdhsa/bin/ -B/usr/amdgcn-amdhsa/lib/ -isystem
/usr/amdgcn-amdhsa/include -isystem /usr/amdgcn-amdhsa/sys-include 
-march=gfx908 -o conftest -g -O2   conftest.c  >&5
/tmp/ccAA4X08.s:1:17: error: target must match options
        .amdgcn_target "amdgcn-unknown-amdhsa--gfx908+sram-ecc"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
configure:3569: $? = 1
...
configure:3824: error: cannot compute suffix of object files: cannot compile
See `config.log' for more details

The other multilibs seem to configure fine.  It works when using llvm-mc from
llvm11.  The gcc-10 branch also seems fine since it doesn't have this
particular multilib.

[Bug target/100208] amdgcn fails to build with llvm-mc from llvm12

[ams at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

--- Comment #1 from Andrew Stubbs <ams at gcc dot gnu.org> ---
LLVM changed the default parameters, so we either have to change the
expectations in the ".amdgcn_target" string (which is basically an assert), or
set the attributes be want explicitly on the assembler command line.

(Or port binutils to amdgcn, but there's no plan for that.)

[Bug target/100208] amdgcn fails to build with llvm-mc from llvm12

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Stubbs <ams@gcc.gnu.org>:

https://gcc.gnu.org/g:aad32a00b7d2b64ae158b2b167768a9ae3e20f6e

commit r12-2396-gaad32a00b7d2b64ae158b2b167768a9ae3e20f6e
Author: Andrew Stubbs <ams@codesourcery.com>
Date:   Thu Jul 8 15:47:53 2021 +0100

    amdgcn: Add -mxnack and -msram-ecc [PR 100208]

    gcc/ChangeLog:

            PR target/100208
            * config/gcn/gcn-hsa.h (DRIVER_SELF_SPECS): New.
            (ASM_SPEC): Set -mattr for xnack and sram-ecc.
            * config/gcn/gcn-opts.h (enum sram_ecc_type): New.
            * config/gcn/gcn-valu.md: Add a warning comment.
            * config/gcn/gcn.c (gcn_option_override): Add "sorry" for -mxnack.
            (output_file_start): Add xnack and sram-ecc state to
".amdgcn_target".
            * config/gcn/gcn.md: Add a warning comment.
            * config/gcn/gcn.opt: Add -mxnack and -msram-ecc.
            * config/gcn/mkoffload.c (EF_AMDGPU_MACH_AMDGCN_GFX908): Remove
            SRAM-ECC flag.
            (EF_AMDGPU_XNACK): New.
            (EF_AMDGPU_SRAM_ECC): New.
            (elf_flags): New.
            (copy_early_debug_info): Use elf_flags.
            (main): Handle -mxnack and -msram-ecc options.
            * doc/invoke.texi: Document -mxnack and -msram-ecc.

    gcc/testsuite/ChangeLog:

            PR target/100208
            * gcc.target/gcn/sram-ecc-1.c: New test.
            * gcc.target/gcn/sram-ecc-2.c: New test.
            * gcc.target/gcn/sram-ecc-3.c: New test.
            * gcc.target/gcn/sram-ecc-4.c: New test.
            * gcc.target/gcn/sram-ecc-5.c: New test.
            * gcc.target/gcn/sram-ecc-6.c: New test.
            * gcc.target/gcn/sram-ecc-7.c: New test.
            * gcc.target/gcn/sram-ecc-8.c: New test.

[Bug target/100208] amdgcn fails to build with llvm-mc from llvm12

[ams at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

Andrew Stubbs <ams at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Andrew Stubbs <ams at gcc dot gnu.org> ---
I think this issue should be resolved now.

(Other reasons why GCC fails with LLVM 12 still exist).

[Bug target/100208] amdgcn fails to build with llvm-mc from llvm12

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Stubbs <ams@gcc.gnu.org>:

https://gcc.gnu.org/g:1af16666943ef075673501765a13e425e47015cd

commit r12-2569-g1af16666943ef075673501765a13e425e47015cd
Author: Andrew Stubbs <ams@codesourcery.com>
Date:   Tue Jul 27 15:40:21 2021 +0100

    amdgcn: Fix attributes for LLVM-12 [PR 100208]

    This should work for a wider range of LLVM 12 variants now.
    More work required for LLVM 13 though.

    gcc/ChangeLog:

            PR target/100208
            * config.in: Regenerate.
            * config/gcn/gcn-hsa.h (A_FIJI): New define.
            (A_900): New define.
            (A_906): New define.
            (A_908): New define.
            (ASM_SPEC): Use A_FIJI, A_900, A_906 and A_908.
            * config/gcn/gcn.c (output_file_start): Adjust attributes according
            to the assembler capabilities.
            * config/gcn/mkoffload.c (main): Likewise.
            * configure: Regenerate.
            * configure.ac: Add tests for LLVM assembler attribute features.

[Bug target/100208] amdgcn fails to build with llvm-mc from llvm12

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Tobias Burnus
<burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:9552afb2aec54b793d61ce85c93869a2f2a7958f

commit r11-9162-g9552afb2aec54b793d61ce85c93869a2f2a7958f
Author: Andrew Stubbs <ams@codesourcery.com>
Date:   Thu Jul 8 15:47:53 2021 +0100

    amdgcn: Add -mxnack and -msram-ecc [PR 100208]

    gcc/ChangeLog:

            PR target/100208
            * config/gcn/gcn-hsa.h (DRIVER_SELF_SPECS): New.
            (ASM_SPEC): Set -mattr for xnack and sram-ecc.
            * config/gcn/gcn-opts.h (enum sram_ecc_type): New.
            * config/gcn/gcn-valu.md: Add a warning comment.
            * config/gcn/gcn.c (gcn_option_override): Add "sorry" for -mxnack.
            (output_file_start): Add xnack and sram-ecc state to
".amdgcn_target".
            * config/gcn/gcn.md: Add a warning comment.
            * config/gcn/gcn.opt: Add -mxnack and -msram-ecc.
            * config/gcn/mkoffload.c (EF_AMDGPU_MACH_AMDGCN_GFX908): Remove
            SRAM-ECC flag.
            (EF_AMDGPU_XNACK): New.
            (EF_AMDGPU_SRAM_ECC): New.
            (elf_flags): New.
            (copy_early_debug_info): Use elf_flags.
            (main): Handle -mxnack and -msram-ecc options.
            * doc/invoke.texi: Document -mxnack and -msram-ecc.

    gcc/testsuite/ChangeLog:

            PR target/100208
            * gcc.target/gcn/sram-ecc-1.c: New test.
            * gcc.target/gcn/sram-ecc-2.c: New test.
            * gcc.target/gcn/sram-ecc-3.c: New test.
            * gcc.target/gcn/sram-ecc-4.c: New test.
            * gcc.target/gcn/sram-ecc-5.c: New test.
            * gcc.target/gcn/sram-ecc-6.c: New test.
            * gcc.target/gcn/sram-ecc-7.c: New test.
            * gcc.target/gcn/sram-ecc-8.c: New test.

    (cherry picked from commit aad32a00b7d2b64ae158b2b167768a9ae3e20f6e)

[Bug target/100208] amdgcn fails to build with llvm-mc from llvm12

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100208

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Tobias Burnus
<burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:92aed72a73993607b845651630ba8a48f332097c

commit r11-9163-g92aed72a73993607b845651630ba8a48f332097c
Author: Andrew Stubbs <ams@codesourcery.com>
Date:   Tue Jul 27 15:40:21 2021 +0100

    amdgcn: Fix attributes for LLVM-12 [PR 100208]

    This should work for a wider range of LLVM 12 variants now.
    More work required for LLVM 13 though.

    gcc/ChangeLog:

            PR target/100208
            * config.in: Regenerate.
            * config/gcn/gcn-hsa.h (A_FIJI): New define.
            (A_900): New define.
            (A_906): New define.
            (A_908): New define.
            (ASM_SPEC): Use A_FIJI, A_900, A_906 and A_908.
            * config/gcn/gcn.c (output_file_start): Adjust attributes according
            to the assembler capabilities.
            * config/gcn/mkoffload.c (main): Likewise.
            * configure: Regenerate.
            * configure.ac: Add tests for LLVM assembler attribute features.