[Bug fortran/100297] New: FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[Bug fortran/100297] New: FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

            Bug ID: 100297
           Summary: FAIL: gfortran.dg/allocatable_function_1.f90
                    gfortran.dg/reshape_8.f90
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: msebor at gcc dot gnu.org
  Target Milestone: ---

A build of today's trunk of GCC 12 shows the following test failures in the
Fortran test suite:

Running /test/src/gcc/master/gcc/testsuite/gfortran.dg/dg.exp ...
FAIL: gfortran.dg/allocatable_function_1.f90   -O0   scan-tree-dump-times
original "free" 10
FAIL: gfortran.dg/allocatable_function_1.f90   -O1   scan-tree-dump-times
original "free" 10
FAIL: gfortran.dg/allocatable_function_1.f90   -O2   scan-tree-dump-times
original "free" 10
FAIL: gfortran.dg/allocatable_function_1.f90   -O3 -fomit-frame-pointer
-funroll-loops -fpeel-loops -ftracer -finline-functions   scan-tree-dump-times
original "free" 10
FAIL: gfortran.dg/allocatable_function_1.f90   -O3 -g   scan-tree-dump-times
original "free" 10
FAIL: gfortran.dg/allocatable_function_1.f90   -Os   scan-tree-dump-times
original "free" 10
FAIL: gfortran.dg/reshape_8.f90   -O   scan-tree-dump-times original "data" 4

                === gfortran Summary ===

# of expected passes            13
# of unexpected failures        7

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=83904

--- Comment #1 from Martin Sebor <msebor at gcc dot gnu.org> ---
This is on x86_64-linux.  I don't see these failures in the results recently
reported to gcc-testresults.

Pr83904 also reports some failures in the Fortran test suite, including
gfortran.dg/allocatable_function_1.f90

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-04-16
                 CC|                            |anlauf at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from anlauf at gcc dot gnu.org ---
We should adjust the scan strings to avoid collisons with file paths:

diff --git a/gcc/testsuite/gfortran.dg/allocatable_function_1.f90
b/gcc/testsuite/gfortran.dg/allocatable_function_1.f90
index f96ebc499e8..e38953bd777 100644
--- a/gcc/testsuite/gfortran.dg/allocatable_function_1.f90
+++ b/gcc/testsuite/gfortran.dg/allocatable_function_1.f90
@@ -107,4 +107,4 @@ contains
     end function bar

 end program alloc_fun
-! { dg-final { scan-tree-dump-times "free" 10 "original" } }
+! { dg-final { scan-tree-dump-times "__builtin_free " 10 "original" } }

diff --git a/gcc/testsuite/gfortran.dg/reshape_8.f90
b/gcc/testsuite/gfortran.dg/reshape_8.f90
index 01799ac5c19..03861fb26df 100644
--- a/gcc/testsuite/gfortran.dg/reshape_8.f90
+++ b/gcc/testsuite/gfortran.dg/reshape_8.f90
@@ -11,4 +11,4 @@ program test
   a = reshape([1,2,3,4], [2,0])
   print *, a
 end
-! { dg-final { scan-tree-dump-times "data" 4 "original" } }
+! { dg-final { scan-tree-dump-times "\.data" 4 "original" } }

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> ---
"\.data" is the same as ".data", you want either "\\.data" or {\.data}.  But it
still doesn't lower the probability to match a filename by much.

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

--- Comment #4 from anlauf at gcc dot gnu.org ---
(In reply to Andreas Schwab from comment #3)
> "\.data" is the same as ".data", you want either "\\.data" or {\.data}.  But
> it still doesn't lower the probability to match a filename by much.

True.

I've compared the dump generated by gfortran <= 10 vs. >= 11, looked at
PR96624 again and came to the conclusion that the absence of the following
was probably intended:

    (*(integer(kind=4)[0] * restrict) atmp.0.data)[0] = 1;
    (*(integer(kind=4)[0] * restrict) atmp.0.data)[1] = 2;

The following pattern variant succeeds with 11+ and fails with 10-branch:

diff --git a/gcc/testsuite/gfortran.dg/reshape_8.f90
b/gcc/testsuite/gfortran.dg/reshape_8.f90
index 01799ac5c19..56812124cb8 100644
--- a/gcc/testsuite/gfortran.dg/reshape_8.f90
+++ b/gcc/testsuite/gfortran.dg/reshape_8.f90
@@ -11,4 +11,4 @@ program test
   a = reshape([1,2,3,4], [2,0])
   print *, a
 end
-! { dg-final { scan-tree-dump-times "data" 4 "original" } }
+! { dg-final { scan-tree-dump-not "data..0. =" "original" } }

This should be safe enough...

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:6fc8e25cb6b5d720bedd85194b0ad740d75082f4

commit r14-90-g6fc8e25cb6b5d720bedd85194b0ad740d75082f4
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Apr 18 21:24:20 2023 +0200

    testsuite: fix scan-tree-dump patterns [PR83904,PR100297]

    Adjust scan-tree-dump patterns so that they do not accidentally match a
    valid path.

    gcc/testsuite/ChangeLog:

            PR testsuite/83904
            PR fortran/100297
            * gfortran.dg/allocatable_function_1.f90: Use "__builtin_free "
            instead of the naive "free".
            * gfortran.dg/reshape_8.f90: Extend pattern from a simple "data".

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |14.0

--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed.

[Bug fortran/100297] FAIL: gfortran.dg/allocatable_function_1.f90 gfortran.dg/reshape_8.f90

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100297

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:1a023e688186ea4cd284f5d269f2ecde9f80438c

commit r13-7501-g1a023e688186ea4cd284f5d269f2ecde9f80438c
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Apr 18 21:24:20 2023 +0200

    testsuite: fix scan-tree-dump patterns [PR83904,PR100297]

    Adjust scan-tree-dump patterns so that they do not accidentally match a
    valid path.

    gcc/testsuite/ChangeLog:

            PR testsuite/83904
            PR fortran/100297
            * gfortran.dg/allocatable_function_1.f90: Use "__builtin_free "
            instead of the naive "free".
            * gfortran.dg/reshape_8.f90: Extend pattern from a simple "data".

    (cherry picked from commit 6fc8e25cb6b5d720bedd85194b0ad740d75082f4)