[Bug target/100361] New: gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[Bug target/100361] New: gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

            Bug ID: 100361
           Summary: gcc-11 for msp430-elf fails to build:
                    src/c++17/floating_to_chars.cc:107:
                    d2fixed_full_table.h:1283:23: error: size of array
                    ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: slyfox at gcc dot gnu.org
  Target Milestone: ---

gcc-10.3.0 was able to build:

LANG=C msp430-elf-gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/msp430-elf-gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/msp430-elf/10.3.0/lto-wrapper
Target: msp430-elf
Configured with:
/tmp/portage-tmpdir/portage/cross-msp430-elf/gcc-10.3.0/work/gcc-10.3.0/configure
--host=x86_64-pc-linux-gnu --target=msp430-elf --build=x86_64-pc-linux-gnu
--prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/msp430-elf/gcc-bin/10.3.0
--includedir=/usr/lib/gcc/msp430-elf/10.3.0/include
--datadir=/usr/share/gcc-data/msp430-elf/10.3.0
--mandir=/usr/share/gcc-data/msp430-elf/10.3.0/man
--infodir=/usr/share/gcc-data/msp430-elf/10.3.0/info
--with-gxx-include-dir=/usr/lib/gcc/msp430-elf/10.3.0/include/g++-v10
--with-python-dir=/share/gcc-data/msp430-elf/10.3.0/python
--enable-languages=c,c++ --enable-obsolete --enable-secureplt --disable-werror
--with-system-zlib --enable-nls --without-included-gettext
--enable-checking=release --with-bugurl=https://bugs.gentoo.org/
--with-pkgversion='Gentoo 10.3.0 p1' --disable-esp --enable-libstdcxx-time
--enable-poison-system-directories --disable-libstdcxx-time
--with-sysroot=/usr/msp430-elf --disable-bootstrap --with-newlib
--enable-multilib --disable-fixed-point --disable-libgomp --disable-libssp
--disable-libada --disable-systemtap --disable-vtable-verify --disable-libvtv
--with-zstd --enable-lto --without-isl --disable-libsanitizer
--enable-default-pie --enable-default-ssp
Thread model: single
Supported LTO compression algorithms: zlib zstd
gcc version 10.3.0 (Gentoo 10.3.0 p1)

gcc-11 fails as:

Making all in c++17
make[5]: Entering directory
'/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/src/c++17'
/bin/bash ../../libtool --tag CXX --tag disable-shared   --mode=compile
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/./gcc/xgcc
-shared-libgcc
-B/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/./gcc -nostdinc++
-L/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/src
-L/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/src/.libs
-L/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/libsupc++/.libs
-B/usr/msp430-elf/bin/ -B/usr/msp430-elf/lib/ -isystem /usr/msp430-elf/include
-isystem /usr/msp430-elf/sys-include   
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/../libgcc
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/include/msp430-elf
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/include
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/libsupc++
  -std=gnu++17   -fno-implicit-templates  -Wall -Wextra -Wwrite-strings
-Wcast-qual -Wabi=2  -fdiagnostics-show-location=once   -ffunction-sections
-fdata-sections  -frandom-seed=floating_to_chars.lo  -fimplicit-templates -g
-O2  -c -o floating_to_chars.lo
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/floating_to_chars.cc
libtool: compile: 
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/./gcc/xgcc
-shared-libgcc
-B/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/./gcc -nostdinc++
-L/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/src
-L/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/src/.libs
-L/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/libsupc++/.libs
-B/usr/msp430-elf/bin/ -B/usr/msp430-elf/lib/ -isystem /usr/msp430-elf/include
-isystem /usr/msp430-elf/sys-include
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/../libgcc
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/include/msp430-elf
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/build/msp430-elf/libstdc++-v3/include
-I/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/libsupc++
-std=gnu++17 -fno-implicit-templates -Wall -Wextra -Wwrite-strings -Wcast-qual
-Wabi=2 -fdiagnostics-show-location=once -ffunction-sections -fdata-sections
-frandom-seed=floating_to_chars.lo -fimplicit-templates -g -O2 -c
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/floating_to_chars.cc
-o floating_to_chars.o
In file included from
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/floating_to_chars.cc:107:
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/ryu/d2fixed_full_table.h:1283:23:
error: size of array 'POW10_SPLIT_2' exceeds maximum object size '32767'
 1283 | static const uint64_t POW10_SPLIT_2[3133][3] = {
      |                       ^~~~~~~~~~~~~
In file included from
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/floating_to_chars.cc:110:
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/ryu/d2fixed.c:
In function 'int {anonymous}::ryu::d2fixed_buffered_n(double, uint32_t,
char*)':
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/ryu/d2fixed.c:425:50:
error: 'POW10_SPLIT_2' was not declared in this scope; did you mean
'POW10_SPLIT'?
  425 |       uint32_t digits = mulShift_mod1e9(m2 << 8, POW10_SPLIT_2[p], j +
8);
      |                                                  ^~~~~~~~~~~~~
      |                                                  POW10_SPLIT
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/ryu/d2fixed.c:
In function 'int {anonymous}::ryu::d2exp_buffered_n(double, uint32_t, char*,
int*)':
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/libstdc++-v3/src/c++17/ryu/d2fixed.c:601:78:
error: 'POW10_SPLIT_2' was not declared in this scope; did you mean
'POW10_SPLIT'?
  601 |       digits = (p >= POW10_OFFSET_2[idx + 1]) ? 0 : mulShift_mod1e9(m2
<< 8, POW10_SPLIT_2[p], j + 8);
      |                                                                        
     ^~~~~~~~~~~~~
      |                                                                        
     POW10_SPLIT

Configured as:

$ LANG=C ./gcc/xgcc -Bgcc -v
Reading specs from gcc/specs
COLLECT_GCC=./gcc/xgcc
COLLECT_LTO_WRAPPER=gcc/lto-wrapper
Target: msp430-elf
Configured with:
/tmp/portage/cross-msp430-elf/gcc-12.0.0_pre9999/work/gcc-12.0.0_pre9999/configure
--host=x86_64-pc-linux-gnu --target=msp430-elf --build=x86_64-pc-linux-gnu
--prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/msp430-elf/gcc-bin/12.0.0
--includedir=/usr/lib/gcc/msp430-elf/12.0.0/include
--datadir=/usr/share/gcc-data/msp430-elf/12.0.0
--mandir=/usr/share/gcc-data/msp430-elf/12.0.0/man
--infodir=/usr/share/gcc-data/msp430-elf/12.0.0/info
--with-gxx-include-dir=/usr/lib/gcc/msp430-elf/12.0.0/include/g++-v12
--with-python-dir=/share/gcc-data/msp430-elf/12.0.0/python
--enable-languages=c,c++ --enable-obsolete --enable-secureplt --disable-werror
--with-system-zlib --enable-nls --without-included-gettext
--enable-checking=release --with-bugurl=https://bugs.gentoo.org/
--with-pkgversion='Gentoo 12.0.0_pre9999 p1, commit
d8d291f3367230fdfdacc9868b0aa01de1dabb13' --disable-esp --enable-libstdcxx-time
--enable-poison-system-directories --disable-libstdcxx-time
--with-sysroot=/usr/msp430-elf --disable-bootstrap --with-newlib
--enable-multilib --disable-fixed-point --disable-libgomp --disable-libssp
--disable-libada --disable-systemtap --disable-valgrind-annotations
--disable-vtable-verify --disable-libvtv --with-zstd --enable-lto --without-isl
--disable-libsanitizer --enable-default-pie --enable-default-ssp
Thread model: single
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.0 20210430 (experimental) (Gentoo 12.0.0_pre9999 p1, commit
d8d291f3367230fdfdacc9868b0aa01de1dabb13)

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[amylaar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amylaar at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-05-18

--- Comment #1 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
I also see this for 16 bit eSi-RISC targets.  This array can't fit into a 16
bit address space that addresses 8 bit units.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppalka at gcc dot gnu.org

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Patrick, is the table an optimization, or essential? We might be able to avoid
it, but he functions would be much slower.

Maybe we should just disable the floating-point to_chars for 16-bit targets.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #3 from Patrick Palka <ppalka at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #2)
> Patrick, is the table an optimization, or essential? We might be able to
> avoid it, but he functions would be much slower.

The tables are essential for Ryu's d2exp_buffered_n and d2fixed_buffered_n
routines, which we use for fast explicit-precision formatting of float/double.

> 
> Maybe we should just disable the floating-point to_chars for 16-bit targets.

Agreed.. though in theory we could just go through printf as a fallback for
d2exp_buffered_n and d2fixed_buffered_n on these targets.

Btw, we already disable the floating-point to_chars on targets without a
binary64 double.  So is our test for detecting binary64 not accurate enough, or
are these 16-bit targets whose double type really is binary64?

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[amylaar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #4 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
Created attachment 50837
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50837&action=edit
Proposed patch

This patch fixes the problem for eSi-RISC and bootstraps on x86_64-pc-linux-gnu
, with floating_to_chars.o properly built in each stage.

Could you check that this also works for msp430?

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[amylaar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #5 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
(In reply to Patrick Palka from comment #3)

> Btw, we already disable the floating-point to_chars on targets without a
> binary64 double.  So is our test for detecting binary64 not accurate enough,
> or are these 16-bit targets whose double type really is binary64?

At least in the case of eSi-RISC, it is the latter.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
That patch isn't OK, because the declarations in <charconv> would still be
present, but using them would give linker errors.

I think we should just check __SIZE_WIDTH__ < 32 (in that .cc file and in the
header).

If somebody wants to contribute an implementation that doesn't use the tables
and trades off time for space then we can support them, but I don't think
that's a good use of Patrick's time.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[amylaar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50837|0                           |1
        is obsolete|                            |

--- Comment #7 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
Created attachment 50839
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50839&action=edit
Amended patch

This patch also disables the affected tests.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[amylaar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #8 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> ---
Bootstrapped and regression tested on x86_64-pc-linux-gnu.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Nice, thanks, Joern. That patch is OK for trunk and gcc-11 (please remember to
CC the libstdc++ list when you post it to gcc-patches).

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #10 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Amended patch fixes msp430-elf build as well. Thank you!

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Joern Rennecke <amylaar@gcc.gnu.org>:

https://gcc.gnu.org/g:66c5f24788652a49b528f14e23e8121ad0935ace

commit r12-942-g66c5f24788652a49b528f14e23e8121ad0935ace
Author: Joern Rennecke <joern.rennecke@riscy-ip.com>
Date:   Thu May 20 13:21:41 2021 +0100

    libstdc++: Disable floating_to_chars.cc on 16 bit targets

    This patch conditionally disables the compilation of floating_to_chars.cc
    on 16 bit targets, thus fixing a build failure for these targets as
    the POW10_SPLIT_2 array exceeds the maximum object size.

    libstdc++-v3/
            PR libstdc++/100361
            * include/std/charconv (to_chars): Hide the overloads for
            floating-point types for 16 bit targets.
            * src/c++17/floating_to_chars.cc: Don't compile for 16 bit targets.
            * testsuite/20_util/to_chars/double.cc: Run this test only on
            size32plus targets.
            * testsuite/20_util/to_chars/float.cc: Likewise.
            * testsuite/20_util/to_chars/long_double.cc: Likewise.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Joern Rennecke
<amylaar@gcc.gnu.org>:

https://gcc.gnu.org/g:5f772bd9847cdbf6a7a6d856de87cb65472d56f4

commit r11-8446-g5f772bd9847cdbf6a7a6d856de87cb65472d56f4
Author: Joern Rennecke <joern.rennecke@riscy-ip.com>
Date:   Thu May 20 13:21:41 2021 +0100

    libstdc++: Disable floating_to_chars.cc on 16 bit targets

    This patch conditionally disables the compilation of floating_to_chars.cc
    on 16 bit targets, thus fixing a build failure for these targets as
    the POW10_SPLIT_2 array exceeds the maximum object size.

    libstdc++-v3/
            PR libstdc++/100361
            * include/std/charconv (to_chars): Hide the overloads for
            floating-point types for 16 bit targets.
            * src/c++17/floating_to_chars.cc: Don't compile for 16 bit targets.
            * testsuite/20_util/to_chars/double.cc: Run this test only on
            size32plus targets.
            * testsuite/20_util/to_chars/float.cc: Likewise.
            * testsuite/20_util/to_chars/long_double.cc: Likewise.

[Bug libstdc++/100361] gcc-11 for msp430-elf fails to build: src/c++17/floating_to_chars.cc:107: d2fixed_full_table.h:1283:23: error: size of array ‘POW10_SPLIT_2’ exceeds maximum object size ‘32767’

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100361

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.2
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The relevant files don't exist on the gcc-10 branch, so this is fixed in 11.2,
right?

Please reopen if not.