[Bug testsuite/100407] New: New test cases attr-retain-*.c fail after their introduction in r11-7284

[Bug testsuite/100407] New: New test cases attr-retain-*.c fail after their introduction in r11-7284

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

            Bug ID: 100407
           Summary: New test cases attr-retain-*.c fail after their
                    introduction in r11-7284
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:6347f4a0904fce17eedf5c071be6f3c118680290, r11-7284

These attr-retain-*.c test cases fail on powerpc64 BE.

FAIL: gcc.c-torture/compile/attr-retain-1.c   -O0   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O1   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none   scan-assembler .rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O3 -g   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -Os   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O0   scan-assembler
.rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O0   scan-assembler
.rodata.used_rodata2,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O1   scan-assembler
.rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O1   scan-assembler
.rodata.used_rodata2,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O2   scan-assembler
.rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O2   scan-assembler
.rodata.used_rodata2,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none   scan-assembler .rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none   scan-assembler .rodata.used_rodata2,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .rodata.used_rodata2,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O3 -g   scan-assembler
.rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -O3 -g   scan-assembler
.rodata.used_rodata2,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -Os   scan-assembler
.rodata.used_rodata,"aR"
FAIL: gcc.c-torture/compile/attr-retain-2.c   -Os   scan-assembler
.rodata.used_rodata2,"aR"

I thought I saw some other ones earlier but these are the ones failing now in
trunk and gcc 11.

Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Feb 15 11:31:12 2021 -0800

    Add retain attribute to place symbols in SHF_GNU_RETAIN section

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-05-04

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
I tried r12-436 with a cross compiler:

[hjl@gnu-cfl-2 gcc]$ ./xgcc -v
Using built-in specs.
COLLECT_GCC=./xgcc
Target: powerpc64-linux
Configured with: /export/gnu/import/git/gitlab/x86-gcc/configure
--with-demangler-in-ld --target=powerpc64-linux
--prefix=/usr/gcc-12.0.0-powerpc64-linux --with-local-prefix=/usr/local
--with-system-zlib --disable-libcc1 --disable-libcilkrts --disable-libsanitizer
--disable-libmpx --enable-languages=c,c++
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.0 20210504 (experimental) (GCC) 
[hjl@gnu-cfl-2 gcc]$ make check-gcc RUNTESTFLAGS="compile.exp=attr-retain-1.c"
rm -rf testsuite/gcc-parallel
make[1]: Entering directory
'/export/build/gnu/tools-build/gcc-gitlab-cross/build-powerpc64-linux/gcc'
(rootme=`${PWDCMD-pwd}`; export rootme; \
srcdir=`cd /export/gnu/import/git/gitlab/x86-gcc/gcc; ${PWDCMD-pwd}` ; export
srcdir ; \
if [ -n "" ] \
   && [ -n "$GCC_RUNTEST_PARALLELIZE_DIR" ] \
   && [ -f testsuite/gcc-parallel/finished ]; then \
  rm -rf testsuite/gcc; \
else \
  cd testsuite/gcc; \
  rm -f tmp-site.exp; \
  sed '/set tmpdir/ s|testsuite$|testsuite/gcc|' \
        < ../../site.exp > tmp-site.exp; \
  /bin/sh ${srcdir}/../move-if-change tmp-site.exp site.exp; \
  EXPECT=`if [ -f ${rootme}/../expect/expect ] ; then echo
${rootme}/../expect/expect ; else echo expect ; fi` ; export EXPECT ; \
  if [ -f ${rootme}/../expect/expect ] ; then  \
    TCL_LIBRARY=`cd .. ; cd ${srcdir}/../tcl/library ; ${PWDCMD-pwd}` ; \
    export TCL_LIBRARY ; \
  fi ; \
  `if [ -f ${srcdir}/../dejagnu/runtest ] ; then echo
${srcdir}/../dejagnu/runtest ; else echo runtest; fi` --tool gcc
compile.exp=attr-retain-1.c; \
  if [ -n "$GCC_RUNTEST_PARALLELIZE_DIR" ] ; then \
    touch ${rootme}/testsuite/gcc-parallel/finished; \
  fi ; \
fi )
WARNING: Couldn't find the global config file.
Test run by hjl on Tue May  4 05:16:33 2021
Target is powerpc64-unknown-linux-gnu
Host   is x86_64-pc-linux-gnu

                === gcc tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/config/default.exp as
tool-and-target-specific interface file.
WARNING: Assuming target board is the local machine (which is probably wrong).
You may need to set your DEJAGNU environment variable.
Running
/export/gnu/import/git/gitlab/x86-gcc/gcc/testsuite/gcc.c-torture/compile/compile.exp
...

                === gcc Summary ===

# of expected passes            30
/export/build/gnu/tools-build/gcc-gitlab-cross/build-powerpc64-linux/gcc/xgcc 
version 12.0.0 20210504 (experimental) (GCC) 

make[1]: Leaving directory
'/export/build/gnu/tools-build/gcc-gitlab-cross/build-powerpc64-linux/gcc'
[hjl@gnu-cfl-2 gcc]$ 

It works for me.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #2 from seurer at gcc dot gnu.org ---
I got it to fail on the gcc110 gcc farm machine.

g:659cc7d6320aae7ab390b5886f0efed22f78e244, r12-1164
make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32}'
compile.exp=gcc.c-torture/compile/attr-retain-1.c"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O0   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O1   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O3 -g   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -Os   scan-assembler
.rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none   scan-assembler .rodata.*,"aR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .rodata.*,"aR"
# of expected passes            35
# of unexpected failures        7

I did have to use my own binutils (2.36.1) or the test came up as unsupported.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to seurer from comment #2)
> I got it to fail on the gcc110 gcc farm machine.
> 
> g:659cc7d6320aae7ab390b5886f0efed22f78e244, r12-1164
> make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32}'
> compile.exp=gcc.c-torture/compile/attr-retain-1.c"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -O0   scan-assembler
> .rodata.*,"aR"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -O1   scan-assembler
> .rodata.*,"aR"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2   scan-assembler
> .rodata.*,"aR"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -O3 -g   scan-assembler
> .rodata.*,"aR"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -Os   scan-assembler
> .rodata.*,"aR"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none   scan-assembler .rodata.*,"aR"
> FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
> -fno-fat-lto-objects   scan-assembler .rodata.*,"aR"
> # of expected passes		35
> # of unexpected failures	7
> 
> I did have to use my own binutils (2.36.1) or the test came up as
> unsupported.

Does it fail on LE?

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #4 from seurer at gcc dot gnu.org ---
It does not fail on LE.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
I can't reproduce it with GCC master, glibc 2.33 and binutils 2.36 branch.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 50914
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50914&action=edit
attr-retain-1.s

Here is my attr-retain-1.s.  Please upload your attr-retain-1.s.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50914|0                           |1
        is obsolete|                            |

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 50915
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50915&action=edit
attr-retain-1.s

Here is my attr-retain-1.s compiled with -O0.  Please upload yours.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #8 from seurer at gcc dot gnu.org ---
Created attachment 50922
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50922&action=edit
assembler file

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #9 from seurer at gcc dot gnu.org ---
Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.c-torture/compile/attr-retain-1.c
 -fdiagnostics-plain-output  -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
-w -ffat-lto-objects -fno-ident -S  -m32  -o attr-retain-1.s    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.c-torture/compile/attr-retain-1.c
-fdiagnostics-plain-output -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
-w -ffat-lto-objects -fno-ident -S -m32 -o attr-retain-1.s
PASS: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects  (test for excess errors)
PASS: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .text.*,"axR"
PASS: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .bss.*,"awR"
PASS: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .data.*,"awR"
FAIL: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .rodata.*,"aR"
PASS: gcc.c-torture/compile/attr-retain-1.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects   scan-assembler .data.used_foo_sec,"awR"


seurer@gcc1-power7:~/gcc/git/build/gcc-test$
/home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.c-torture/compile/attr-retain-1.c
-fdiagnostics-plain-output -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
-w -ffat-lto-objects -fno-ident -S -m32 -o attr-retain-1.s

seurer@gcc1-power7:~/gcc/git/build/gcc-test$ grep .rodata attr-retain-1.s 
        .string "used_rodata2"
        .string "unused_rodata"
        .string "used_rodata"
        .globl used_rodata2
        .globl unused_rodata
        .globl used_rodata
        .type   unused_rodata, @object
        .size   unused_rodata, 4
unused_rodata:
        .section        .sdata.used_rodata,"awR"
        .type   used_rodata, @object
        .size   used_rodata, 4
used_rodata:
        .section        .sdata.used_rodata2,"awR"
        .type   used_rodata2, @object
        .size   used_rodata2, 4
used_rodata2:

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #10 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to seurer from comment #9)
> 
> seurer@gcc1-power7:~/gcc/git/build/gcc-test$ grep .rodata attr-retain-1.s 
> 	.string	"used_rodata2"
> 	.string	"unused_rodata"
> 	.string	"used_rodata"
> 	.globl used_rodata2
> 	.globl unused_rodata
> 	.globl used_rodata
> 	.type	unused_rodata, @object
> 	.size	unused_rodata, 4
> unused_rodata:
> 	.section	.sdata.used_rodata,"awR"
                        ^^^^^^^^^^^^^^^^^^^^^^^^^
used_rodata is in a writable section.  Is this intentional? -m64 generates

        .section        .rodata.used_rodata,"aR"
        .align 2
        .type   used_rodata, @object
        .size   used_rodata, 4
used_rodata:
        .long   2   

which looks correct.  If it is intentional, test should exclude -m32 for
powerpc64-linux-gnu.

> 	.type	used_rodata, @object
> 	.size	used_rodata, 4
> used_rodata:
> 	.section	.sdata.used_rodata2,"awR"
> 	.type	used_rodata2, @object
> 	.size	used_rodata2, 4
> used_rodata2:

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gcc dot gnu.org

--- Comment #11 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #10)
> (In reply to seurer from comment #9)
> > 
> > seurer@gcc1-power7:~/gcc/git/build/gcc-test$ grep .rodata attr-retain-1.s 
> > 	.string	"used_rodata2"
> > 	.string	"unused_rodata"
> > 	.string	"used_rodata"
> > 	.globl used_rodata2
> > 	.globl unused_rodata
> > 	.globl used_rodata
> > 	.type	unused_rodata, @object
> > 	.size	unused_rodata, 4
> > unused_rodata:
> > 	.section	.sdata.used_rodata,"awR"
>                         ^^^^^^^^^^^^^^^^^^^^^^^^^
> used_rodata is in a writable section.  Is this intentional? -m64 generates
> 
>         .section        .rodata.used_rodata,"aR"
>         .align 2
>         .type   used_rodata, @object
>         .size   used_rodata, 4
> used_rodata:
>         .long   2   
> 
> which looks correct.  If it is intentional, test should exclude -m32 for
> powerpc64-linux-gnu.

Adding Alan for his input here.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |segher at gcc dot gnu.org

--- Comment #12 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #10)
> > unused_rodata:
> > 	.section	.sdata.used_rodata,"awR"

This is symbol *un*used_rodata.

> used_rodata is in a writable section.  Is this intentional? -m64 generates

Does -mno-readonly-in-sdata help?  Does -msdata=none help?

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[amodra at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gmail dot com

--- Comment #13 from Alan Modra <amodra at gmail dot com> ---
All of the following result in the tests passing.
make check-gcc RUNTESTFLAGS="--target_board=unix/-m32/-mno-readonly-in-sdata
compile.exp=attr-retain-1.c"
make check-gcc RUNTESTFLAGS="--target_board=unix/-m32/-mno-sdata
compile.exp=attr-retain-1.c"
make check-gcc RUNTESTFLAGS="--target_board=unix/-m32/-G0
compile.exp=attr-retain-1.c"

The tests just need tweaking for ppc32 using any of the above, I'd choose -G0.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pat Haugen <pthaugen@gcc.gnu.org>:

https://gcc.gnu.org/g:ae3c4e521dd0b66db712639298cd08331d62f315

commit r12-7378-gae3c4e521dd0b66db712639298cd08331d62f315
Author: Pat Haugen <pthaugen@linux.ibm.com>
Date:   Thu Feb 24 15:33:42 2022 -0600

    Fix attr-retain-* tescases for 32-bit PowerPC.

            PR testsuite/100407

    gcc/testsuite/
            * gcc.c-torture/compile/attr-retain-1.c: Add -G0 for 32-bit
PowerPC.
            * gcc.c-torture/compile/attr-retain-2.c: Likewise.

[Bug testsuite/100407] New test cases attr-retain-*.c fail after their introduction in r11-7284

[pthaugen at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100407

pthaugen at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pthaugen at gcc dot gnu.org
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from pthaugen at gcc dot gnu.org ---
Fixed.