* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
@ 2021-05-04 12:49 ` rguenth at gcc dot gnu.org
2021-05-10 12:25 ` marxin at gcc dot gnu.org
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-05-04 12:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hubicka at gcc dot gnu.org
Keywords| |ice-checking
Target Milestone|--- |11.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
2021-05-04 12:49 ` [Bug ipa/100413] " rguenth at gcc dot gnu.org
@ 2021-05-10 12:25 ` marxin at gcc dot gnu.org
2021-07-28 7:06 ` rguenth at gcc dot gnu.org
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-05-10 12:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-05-10
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |marxin at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
I can take a look.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
2021-05-04 12:49 ` [Bug ipa/100413] " rguenth at gcc dot gnu.org
2021-05-10 12:25 ` marxin at gcc dot gnu.org
@ 2021-07-28 7:06 ` rguenth at gcc dot gnu.org
2021-08-13 14:14 ` [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365 marxin at gcc dot gnu.org
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-07-28 7:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|11.2 |11.3
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.2 is being released, retargeting bugs to GCC 11.3
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (2 preceding siblings ...)
2021-07-28 7:06 ` rguenth at gcc dot gnu.org
@ 2021-08-13 14:14 ` marxin at gcc dot gnu.org
2022-01-17 14:57 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-08-13 14:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mjambor at suse dot cz
Assignee|marxin at gcc dot gnu.org |unassigned at gcc dot gnu.org
Summary|[11/12 Regression] ICE: |[11/12 Regression] ICE:
|failed to reclaim unneeded |failed to reclaim unneeded
|function with custom flags |function with custom flags
| |since
| |r11-4267-g0e590b68fa374365
Status|ASSIGNED |NEW
--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
@Martin, can you please take a look? It's again something about clone
materialization starting with r11-4267-g0e590b68fa374365.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (3 preceding siblings ...)
2021-08-13 14:14 ` [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365 marxin at gcc dot gnu.org
@ 2022-01-17 14:57 ` rguenth at gcc dot gnu.org
2022-04-21 7:49 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-17 14:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed|2021-05-10 00:00:00 |2022-1-17
Priority|P3 |P2
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Re-confirmed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (4 preceding siblings ...)
2022-01-17 14:57 ` rguenth at gcc dot gnu.org
@ 2022-04-21 7:49 ` rguenth at gcc dot gnu.org
2022-04-27 14:57 ` jamborm at gcc dot gnu.org
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-04-21 7:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|11.3 |11.4
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.3 is being released, retargeting bugs to GCC 11.4.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (5 preceding siblings ...)
2022-04-21 7:49 ` rguenth at gcc dot gnu.org
@ 2022-04-27 14:57 ` jamborm at gcc dot gnu.org
2022-04-28 9:19 ` jamborm at gcc dot gnu.org
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2022-04-27 14:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |jamborm at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> ---
I'm testing a patch. The problem is that a clone is removed with
cgraph::remove and it leaves behind a dangling clone_of with a body for which
there is now no need.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (6 preceding siblings ...)
2022-04-27 14:57 ` jamborm at gcc dot gnu.org
@ 2022-04-28 9:19 ` jamborm at gcc dot gnu.org
2022-04-29 15:39 ` [Bug ipa/100413] [11/12/13 " cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2022-04-28 9:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> ---
I proposed the aforementioned fix on the mailing list:
https://gcc.gnu.org/pipermail/gcc-patches/2022-April/593732.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12/13 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (7 preceding siblings ...)
2022-04-28 9:19 ` jamborm at gcc dot gnu.org
@ 2022-04-29 15:39 ` cvs-commit at gcc dot gnu.org
2022-04-29 15:54 ` jamborm at gcc dot gnu.org
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-04-29 15:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:27ee75dbe81bb781214c66a9e6a759c08b7deb60
commit r13-48-g27ee75dbe81bb781214c66a9e6a759c08b7deb60
Author: Martin Jambor <mjambor@suse.cz>
Date: Fri Apr 29 17:38:15 2022 +0200
ipa: Release body of clone_of when removing its last clone (PR 100413)
In the PR, the verifier complains that we did not manage to remove the
body of a node and it is right. The node is kept for materialization
of two clones but after one is materialized, the other one is removed
as unneeded (as a part of delete_unreachable_blocks_update_callgraph).
The problem is that the node removal does not check for this situation
and can leave the clone_of node there with a body attached to it even
though there is no use for it any more. This patch does checks for it
and handles the situation in a simlar way that
cgraph_node::materialize_clone does it, except that it also has to be
careful that the removed node itself does not have any clones, which
would still need the clone_of's body. Failing to do that results in a
bootstrap failure.
gcc/ChangeLog:
2022-04-27 Martin Jambor <mjambor@suse.cz>
PR ipa/100413
* cgraph.cc (cgraph_node::remove): Release body of the node this
is clone_of if appropriate.
gcc/testsuite/ChangeLog:
2022-04-27 Martin Jambor <mjambor@suse.cz>
PR ipa/100413
* g++.dg/ipa/pr100413.C: New test.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12/13 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (8 preceding siblings ...)
2022-04-29 15:39 ` [Bug ipa/100413] [11/12/13 " cvs-commit at gcc dot gnu.org
@ 2022-04-29 15:54 ` jamborm at gcc dot gnu.org
2022-05-11 21:29 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2022-04-29 15:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
--- Comment #9 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Now fixed in trunk, I'll backport to 12 and 11 after 12.1 is released.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12/13 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (9 preceding siblings ...)
2022-04-29 15:54 ` jamborm at gcc dot gnu.org
@ 2022-05-11 21:29 ` cvs-commit at gcc dot gnu.org
2022-05-19 12:07 ` cvs-commit at gcc dot gnu.org
2022-05-19 12:08 ` jamborm at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-11 21:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:988fbc636639621dadc5cecbe77aa3f9aefedefb
commit r12-8368-g988fbc636639621dadc5cecbe77aa3f9aefedefb
Author: Martin Jambor <mjambor@suse.cz>
Date: Wed May 11 23:25:40 2022 +0200
ipa: Release body of clone_of when removing its last clone (PR 100413)
In the PR, the verifier complains that we did not manage to remove the
body of a node and it is right. The node is kept for materialization
of two clones but after one is materialized, the other one is removed
as unneeded (as a part of delete_unreachable_blocks_update_callgraph).
The problem is that the node removal does not check for this situation
and can leave the clone_of node there with a body attached to it even
though there is no use for it any more. This patch does checks for it
and handles the situation in a simlar way that
cgraph_node::materialize_clone does it, except that it also has to be
careful that the removed node itself does not have any clones, which
would still need the clone_of's body. Failing to do that results in a
bootstrap failure.
gcc/ChangeLog:
2022-04-27 Martin Jambor <mjambor@suse.cz>
PR ipa/100413
* cgraph.cc (cgraph_node::remove): Release body of the node this
is clone_of if appropriate.
gcc/testsuite/ChangeLog:
2022-04-27 Martin Jambor <mjambor@suse.cz>
PR ipa/100413
* g++.dg/ipa/pr100413.C: New test.
(cherry picked from commit 27ee75dbe81bb781214c66a9e6a759c08b7deb60)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12/13 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (10 preceding siblings ...)
2022-05-11 21:29 ` cvs-commit at gcc dot gnu.org
@ 2022-05-19 12:07 ` cvs-commit at gcc dot gnu.org
2022-05-19 12:08 ` jamborm at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-19 12:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:a03b46b78c82666b39ccada3df533f819e13dcb7
commit r11-10011-ga03b46b78c82666b39ccada3df533f819e13dcb7
Author: Martin Jambor <mjambor@suse.cz>
Date: Thu May 19 14:06:08 2022 +0200
ipa: Release body of clone_of when removing its last clone (PR 100413)
In the PR, the verifier complains that we did not manage to remove the
body of a node and it is right. The node is kept for materialization
of two clones but after one is materialized, the other one is removed
as unneeded (as a part of delete_unreachable_blocks_update_callgraph).
The problem is that the node removal does not check for this situation
and can leave the clone_of node there with a body attached to it even
though there is no use for it any more. This patch does checks for it
and handles the situation in a simlar way that
cgraph_node::materialize_clone does it, except that it also has to be
careful that the removed node itself does not have any clones, which
would still need the clone_of's body. Failing to do that results in a
bootstrap failure.
gcc/ChangeLog:
2022-04-27 Martin Jambor <mjambor@suse.cz>
PR ipa/100413
* cgraph.c (cgraph_node::remove): Release body of the node this
is clone_of if appropriate.
gcc/testsuite/ChangeLog:
2022-04-27 Martin Jambor <mjambor@suse.cz>
PR ipa/100413
* g++.dg/ipa/pr100413.C: New test.
(cherry picked from commit 27ee75dbe81bb781214c66a9e6a759c08b7deb60)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug ipa/100413] [11/12/13 Regression] ICE: failed to reclaim unneeded function with custom flags since r11-4267-g0e590b68fa374365
2021-05-04 10:57 [Bug ipa/100413] New: [11/12 Regression] ICE: failed to reclaim unneeded function with custom flags zsojka at seznam dot cz
` (11 preceding siblings ...)
2022-05-19 12:07 ` cvs-commit at gcc dot gnu.org
@ 2022-05-19 12:08 ` jamborm at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: jamborm at gcc dot gnu.org @ 2022-05-19 12:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100413
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #12 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Fixed, thanks for reporting and sorry that it took so long to address.
^ permalink raw reply [flat|nested] 14+ messages in thread