[Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate
@ 2021-05-11 13:52 acoplan at gcc dot gnu.org
  2021-05-12  6:36 ` [Bug debug/100520] " rguenth at gcc dot gnu.org
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: acoplan at gcc dot gnu.org @ 2021-05-11 13:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

            Bug ID: 100520
           Summary: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure
                    with -fprofile-generate
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
          Assignee: unassigned at gcc dot gnu.org
          Reporter: acoplan at gcc dot gnu.org
  Target Milestone: ---

With GCC 11 and trunk I'm seeing the following -fcompare-debug problem:

$ cat test.c
static int f() {}
$ aarch64-linux-gnu-gcc -c test.c -fcompare-debug -fprofile-generate
aarch64-linux-gnu-gcc: error: test.c: ‘-fcompare-debug’ failure

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug debug/100520] [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
@ 2021-05-12  6:36 ` rguenth at gcc dot gnu.org
  2021-07-28  7:06 ` rguenth at gcc dot gnu.org
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-05-12  6:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.2

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug debug/100520] [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
  2021-05-12  6:36 ` [Bug debug/100520] " rguenth at gcc dot gnu.org
@ 2021-07-28  7:06 ` rguenth at gcc dot gnu.org
  2021-09-20  7:00 ` [Bug debug/100520] [11/12 Regression] " pinskia at gcc dot gnu.org
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-07-28  7:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.2                        |11.3

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.2 is being released, retargeting bugs to GCC 11.3

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug debug/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
  2021-05-12  6:36 ` [Bug debug/100520] " rguenth at gcc dot gnu.org
  2021-07-28  7:06 ` rguenth at gcc dot gnu.org
@ 2021-09-20  7:00 ` pinskia at gcc dot gnu.org
  2021-09-20  7:05 ` pinskia at gcc dot gnu.org
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-20  7:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |10.3.0
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-09-20

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I can even reproduce it on x86_64 also.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug debug/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2021-09-20  7:00 ` [Bug debug/100520] [11/12 Regression] " pinskia at gcc dot gnu.org
@ 2021-09-20  7:05 ` pinskia at gcc dot gnu.org
  2021-09-20  7:12 ` [Bug gcov-profile/100520] " pinskia at gcc dot gnu.org
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-20  7:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
-  __gcov_indirect_call_profiler_v4 (1387117561, f);
+  __gcov_indirect_call_profiler_v4 (983609665, f);

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2021-09-20  7:05 ` pinskia at gcc dot gnu.org
@ 2021-09-20  7:12 ` pinskia at gcc dot gnu.org
  2021-09-27 11:54 ` marxin at gcc dot gnu.org
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-20  7:12 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|aarch64, x86_64             |
           Severity|normal                      |major
          Component|debug                       |gcov-profile
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #3)
> -  __gcov_indirect_call_profiler_v4 (1387117561, f);
> +  __gcov_indirect_call_profiler_v4 (983609665, f);

  tree_uid = build_int_cst
              (gcov_type_node,
               cgraph_node::get (current_function_decl)->profile_id);


profile_id is computed in coverage_compute_profile_id.
Which has:

      chksum = coverage_checksum_string
        (chksum, aux_base_name);


The problem is with -fcompare-debug the aux_base_name is different.
Hmm, this code for coverage_compute_profile_id has not changed.  Maybe the use
of the profile id has changed though.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2021-09-20  7:12 ` [Bug gcov-profile/100520] " pinskia at gcc dot gnu.org
@ 2021-09-27 11:54 ` marxin at gcc dot gnu.org
  2021-11-05 15:01 ` [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108 marxin at gcc dot gnu.org
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-09-27 11:54 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Let me handle it..

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2021-09-27 11:54 ` marxin at gcc dot gnu.org
@ 2021-11-05 15:01 ` marxin at gcc dot gnu.org
  2021-11-05 15:15 ` marxin at gcc dot gnu.org
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-05 15:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12 Regression]          |[11/12 Regression]
                   |‘-fcompare-debug’ failure   |‘-fcompare-debug’ failure
                   |with -fprofile-generate     |with -fprofile-generate
                   |                            |since
                   |                            |r11-627-g1dedc12d186a1108

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with Alexander's 'revamp dump and aux output names'.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2021-11-05 15:01 ` [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108 marxin at gcc dot gnu.org
@ 2021-11-05 15:15 ` marxin at gcc dot gnu.org
  2021-11-08 11:52 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-05 15:15 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
Before the revision:

aux_base_name: pr100520
aux_base_name: pr100520

after it:

aux_base_name: pr100520
aux_base_name: pr100520.gk

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2021-11-05 15:15 ` marxin at gcc dot gnu.org
@ 2021-11-08 11:52 ` cvs-commit at gcc dot gnu.org
  2021-11-08 11:54 ` [Bug gcov-profile/100520] [11 " marxin at gcc dot gnu.org
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-08 11:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:7553bd35c876efaf8ab0b6661a6102822b99e6e3

commit r12-4996-g7553bd35c876efaf8ab0b6661a6102822b99e6e3
Author: Martin Liska <mliska@suse.cz>
Date:   Fri Nov 5 16:50:06 2021 +0100

    gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

            PR gcov-profile/100520

    gcc/ChangeLog:

            * coverage.c (coverage_compute_profile_id): Strip .gk when
            compare debug is used.
            * system.h (endswith): New function.

    gcc/testsuite/ChangeLog:

            * gcc.dg/pr100520.c: New test.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (8 preceding siblings ...)
  2021-11-08 11:52 ` cvs-commit at gcc dot gnu.org
@ 2021-11-08 11:54 ` marxin at gcc dot gnu.org
  2021-11-08 12:26 ` cvs-commit at gcc dot gnu.org
  2021-11-08 12:27 ` marxin at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-08 11:54 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|12.0                        |
      Known to work|                            |12.0
            Summary|[11/12 Regression]          |[11 Regression]
                   |‘-fcompare-debug’ failure   |‘-fcompare-debug’ failure
                   |with -fprofile-generate     |with -fprofile-generate
                   |since                       |since
                   |r11-627-g1dedc12d186a1108   |r11-627-g1dedc12d186a1108

--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed on master so far.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (9 preceding siblings ...)
  2021-11-08 11:54 ` [Bug gcov-profile/100520] [11 " marxin at gcc dot gnu.org
@ 2021-11-08 12:26 ` cvs-commit at gcc dot gnu.org
  2021-11-08 12:27 ` marxin at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-08 12:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:580d66f5a0bdcd88dcdab2d4ace3bbbaae121af3

commit r11-9221-g580d66f5a0bdcd88dcdab2d4ace3bbbaae121af3
Author: Martin Liska <mliska@suse.cz>
Date:   Fri Nov 5 16:50:06 2021 +0100

    gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520]

            PR gcov-profile/100520

    gcc/ChangeLog:

            * coverage.c (coverage_compute_profile_id): Strip .gk when
            compare debug is used.
            * system.h (endswith): New function.

    gcc/testsuite/ChangeLog:

            * gcc.dg/pr100520.c: New test.

    (cherry picked from commit 7553bd35c876efaf8ab0b6661a6102822b99e6e3)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug gcov-profile/100520] [11 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108
  2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
                   ` (10 preceding siblings ...)
  2021-11-08 12:26 ` cvs-commit at gcc dot gnu.org
@ 2021-11-08 12:27 ` marxin at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-08 12:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100520

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-11-08 12:27 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 13:52 [Bug debug/100520] New: [11/12 Regression] aarch64: ‘-fcompare-debug’ failure with -fprofile-generate acoplan at gcc dot gnu.org
2021-05-12  6:36 ` [Bug debug/100520] " rguenth at gcc dot gnu.org
2021-07-28  7:06 ` rguenth at gcc dot gnu.org
2021-09-20  7:00 ` [Bug debug/100520] [11/12 Regression] " pinskia at gcc dot gnu.org
2021-09-20  7:05 ` pinskia at gcc dot gnu.org
2021-09-20  7:12 ` [Bug gcov-profile/100520] " pinskia at gcc dot gnu.org
2021-09-27 11:54 ` marxin at gcc dot gnu.org
2021-11-05 15:01 ` [Bug gcov-profile/100520] [11/12 Regression] ‘-fcompare-debug’ failure with -fprofile-generate since r11-627-g1dedc12d186a1108 marxin at gcc dot gnu.org
2021-11-05 15:15 ` marxin at gcc dot gnu.org
2021-11-08 11:52 ` cvs-commit at gcc dot gnu.org
2021-11-08 11:54 ` [Bug gcov-profile/100520] [11 " marxin at gcc dot gnu.org
2021-11-08 12:26 ` cvs-commit at gcc dot gnu.org
2021-11-08 12:27 ` marxin at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).