[Bug other/100598] New: MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[Bug other/100598] New: MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[markus.boeck02 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

            Bug ID: 100598
           Summary: MinGW Canadian cross toolchain fails to build due to
                    missing BASEVER in genversion.c
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: markus.boeck02 at gmail dot com
  Target Milestone: ---

I am currently unable to build trunk version of gcc due to a compiler error
when compiling the file genversion.c. This happens when crosscompiling a GCC
toolchain for a x86_64-w64-mingw32 host.

The compiler error:
../../gcc/genversion.c: In function ‘int main()’:
../../gcc/genversion.c:37:20: error: ‘BASEVER’ was not declared in this scope
   char basever[] = BASEVER;
                    ^~~~~~~
../../gcc/genversion.c:50:11: error: ‘DEVPHASE’ was not declared in this scope
   phase = DEVPHASE[0];
           ^~~~~~~~
../../gcc/genversion.c:73:39: error: expected ‘)’ before ‘BASEVER’
   printf ("#define version_string \"" BASEVER DATESTAMP DEVPHASE REVISION
"\"\n");
                                       ^~~~~~~
../../gcc/genversion.c:74:42: error: expected ‘)’ before ‘PKGVERSION’
   printf ("#define pkgversion_string \"" PKGVERSION "\"\n\n");
                                          ^~~~~~~~~~
../../gcc/genversion.c:82:39: error: expected ‘)’ before ‘BUGURL’
   printf ("#define bug_report_url \"" BUGURL "\"\n\n");
                                       ^~~~~~
make[2]: *** [build/genversion.o] Error 1
make[2]: *** Waiting for unfinished jobs....


The compile command used in the build is:
g++ -c -DIN_GCC      -DGENERATOR_FILE  -I. -Ibuild -I../../gcc
-I../../gcc/build -I../../gcc/../include  -I../../gcc/../libcpp/include
-I/mnt/c/GCC-Build/NewestLinux/Libraries/include \
        -o build/genversion.o ../../gcc/genversion.c

where g++ is 7.5.0 shipped with Ubuntu 18.04 which I am using as build
environment. 

The configure command used is:
../configure --target=x86_64-w64-mingw32 --host=x86_64-w64-mingw32
--disable-bootstrap --enable-libstdcxx-debug --with-tune=znver1
--prefix=/mnt/c/GCC --with-sysroot=/mnt/c/GCC-Build/NewestLinux
--with-build-sysroot=/mnt/c/GCC-Build/NewestLinux --disable-libstdcxx-pch
--disable-multilib --enable-libgomp --with-cross-host
--with-libiconv-prefix=/mnt/c/GCC-Build/NewestLinux/Libraries
--disable-libstdcxx-verbose --enable-languages=c,c++,fortran,lto,objc,obj-c++,d
--disable-nls --disable-win32-registry --enable-shared --with-gnu-as
--with-gnu-ld --enable-threads=posix --program-suffix=-12
--enable-version-specific-runtime-libs --with-gcc-major-version-only
--enable-__cxa_atexit --enable-plugin --program-prefix=
--enable-checking=release

[Bug other/100598] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2021-05-14
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
It's strange, various macros should be passed to the genversion.c command line:

gcc/Makefile.in:

# genversion.c is run on the build machine to generate version.h
CFLAGS-build/genversion.o += -DBASEVER=$(BASEVER_s) -DDATESTAMP=$(DATESTAMP_s)
\
        -DREVISION=$(REVISION_s) \
        -DDEVPHASE=$(DEVPHASE_s) -DPKGVERSION=$(PKGVERSION_s) \
        -DBUGURL=$(BUGURL_s)

build log:

g++ -c  -DBASEVER="\"12.0.0\"" -DDATESTAMP="\" 20210514\"" -DREVISION="\"\""
-DDEVPHASE="\" (experimental)\"" -DPKGVERSION="\"(GCC) \""
-DBUGURL="\"<https://gcc.gnu.org/bugs/>\"" -g -O2 -DIN_GCC -fPIC   
-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wno-error=format-diag -Wmissing-format-attribute
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H  -DGENERATOR_FILE -fno-PIE
-I. -Ibuild -I/home/marxin/Programming/gcc/gcc
-I/home/marxin/Programming/gcc/gcc/build
-I/home/marxin/Programming/gcc/gcc/../include 
-I/home/marxin/Programming/gcc/gcc/../libcpp/include  \
        -o build/genversion.o /home/marxin/Programming/gcc/gcc/genversion.c

[Bug other/100598] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |burnus at gcc dot gnu.org
             Status|WAITING                     |ASSIGNED
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570371.html

[Bug other/100598] [12 Regression] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
             Target|                            |x86_64-w64-mingw32,powerpc6
                   |                            |4le-gnu-linux
           Keywords|                            |build
            Summary|MinGW Canadian cross        |[12 Regression] MinGW
                   |toolchain fails to build    |Canadian cross toolchain
                   |due to missing BASEVER in   |fails to build due to
                   |genversion.c                |missing BASEVER in
                   |                            |genversion.c
               Host|                            |x86_64-w64-mingw32,powerpc6
                   |                            |4le-gnu-linux
              Build|                            |x86_64-gnu-linux

[Bug other/100598] [12 Regression] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

--- Comment #3 from cqwrteur <unlvsur at live dot com> ---
I've seen the same issues.

[Bug other/100598] [12 Regression] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug other/100598] [12 Regression] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:5116b54e4644cb0d7b99891c76f8f015097f6530

commit r12-872-g5116b54e4644cb0d7b99891c76f8f015097f6530
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue May 18 11:56:05 2021 +0200

    gcc/configure.ac: Fix cross build by using $(CFLAGS-$@) [PR100598]

    BUILD_CFLAGS is set by configure; by default, BUILD_CFLAGS = $(ALL_CFLAGS)
    is used. The latter contains (see gcc/Makefile.in) $(CFLAGS-$@), which is
used
    to pass .o-file specific flags to the compiler.
    For cross builds, BUILD_CFLAGS is constructed in configure{,.ac} and missed
    the $(CFLAGS-$@) - despite the comment above ALL_CFLAGS that configure.ac
    might have to kept in sync.

    gcc/ChangeLog:

            PR other/100598
            * configure: Regenerate.
            * configure.ac (BUILD_CFLAG, BUILD_CXXFLAGS): Add $(CFLAGS-$@).

[Bug other/100598] [12 Regression] MinGW Canadian cross toolchain fails to build due to missing BASEVER in genversion.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100598

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Should be fixed now.