public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dragan.mladjenovic at syrmia dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/100604] New: GCC generates invalid LO_SYM for unaligned global
Date: Fri, 14 May 2021 15:15:38 +0000	[thread overview]
Message-ID: <bug-100604-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100604

            Bug ID: 100604
           Summary: GCC generates invalid LO_SYM for unaligned global
           Product: gcc
           Version: 11.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dragan.mladjenovic at syrmia dot com
  Target Milestone: ---

Created attachment 50814
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50814&action=edit
Reproducer example.

This a bit contrived example that requires -O0. Not sure if it applies to
bitfield extracts in other contexts and optimization levels. I noticed it on
STRICT_ALIGMENT targets w/o extzvmisalign.

$cat unaligned.c
int __attribute__((aligned(2))) bar;

int foo (void)
{
        return bar;
}


$riscv64-elf-gcc  unaligned.c  -S  -o -
        .file   "unaligned.c"
        .option nopic
        .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c2p0"
        .attribute unaligned_access, 0
        .attribute stack_align, 16
        .text
        .globl  bar
        .section        .sbss,"aw",@nobits
        .align  1
        .type   bar, @object
        .size   bar, 4
bar:
        .zero   4
        .text
        .align  1
        .globl  foo
        .type   foo, @function
foo:
        addi    sp,sp,-16
        sd      s0,8(sp)
        addi    s0,sp,16
        lui     a5,%hi(bar)
        lhu     a4,%lo(bar)(a5)
        lhu     a5,%lo(bar+2)(a5)
        slli    a5,a5,16
        or      a5,a5,a4
        slli    a5,a5,32
        srai    a5,a5,32
        sext.w  a5,a5
        mv      a0,a5
        ld      s0,8(sp)
        addi    sp,sp,16
        jr      ra
        .size   foo, .-foo
        .ident  "GCC: (Scratch/experimental build 20210514_1511) 11.1.1
20210503"

$mipsisa64-elf-gcc -O0 unaligned.c -G 0 -mips64r6 -S  -o -
        .file   1 "unaligned.c"
        .section .mdebug.eabi64
        .previous
        .section .gcc_compiled_long64
        .previous
        .nan    2008
        .module fp=64
        .module oddspreg
        .text
        .globl  bar
        .section        .bss,"aw",@nobits
        .align  1
        .type   bar, @object
        .size   bar, 4
bar:
        .space  4
        .text
        .align  2
        .globl  foo
        .set    nomips16
        .set    nomicromips
        .ent    foo
        .type   foo, @function
foo:
        .frame  $fp,8,$31               # vars= 0, regs= 1/0, args= 0, gp= 0
        .mask   0x40000000,0
        .fmask  0x00000000,0
        .set    noreorder
        .set    nomacro
        daddiu  $sp,$sp,-8
        sd      $fp,0($sp)
        move    $fp,$sp
        lui     $2,%hi(bar)
        lhu     $3,%lo(bar)($2)
        dsll    $3,$3,16
        lhu     $2,%lo(bar+2)($2)
        or      $2,$2,$3
        dsll    $2,$2,32
        dsra    $2,$2,32
        sll     $2,$2,0
        move    $sp,$fp
        ld      $fp,0($sp)
        daddiu  $sp,$sp,8
        jrc     $31
        .set    macro
        .set    reorder
        .end    foo
        .size   foo, .-foo
        .ident  "GCC: (Scratch/experimental build 20210514_1405) 11.1.1
20210503"

Notice that %lo(bar)(.*) and %lo(bar+2)(.*) resue same %hi(bar) value.
This can be wrong since bar is 2-byte aligned and might be split between two
different %hi pages.

             reply	other threads:[~2021-05-14 15:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 15:15 dragan.mladjenovic at syrmia dot com [this message]
2021-05-14 19:34 ` [Bug middle-end/100604] " pinskia at gcc dot gnu.org
2021-05-14 21:28 ` dragan.mladjenovic at syrmia dot com
2021-05-17 12:24 ` rguenth at gcc dot gnu.org
2021-05-22 16:21 ` dragan.mladjenovic at syrmia dot com
2023-11-29 18:45 ` pinskia at gcc dot gnu.org
2023-11-29 18:45 ` pinskia at gcc dot gnu.org
2024-04-17 19:31 ` pinskia at gcc dot gnu.org
2024-04-17 19:37 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100604-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).