public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/100604] GCC generates invalid LO_SYM for unaligned global
Date: Mon, 17 May 2021 12:24:47 +0000 [thread overview]
Message-ID: <bug-100604-4-K5p8JMvniF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100604-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100604
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to dragan.mladjenovic from comment #2)
> It seems so. Something like this helps in this case:
>
> diff --git a/gcc/emit-rtl.c b/gcc/emit-rtl.c
> index 07e908624a0..a102a9288c5 100644
> --- a/gcc/emit-rtl.c
> +++ b/gcc/emit-rtl.c
> @@ -2385,7 +2385,7 @@ adjust_address_1 (rtx memref, machine_mode mode,
> poly_int64 offset,
> if (GET_MODE (memref) != BLKmode
> && GET_CODE (addr) == LO_SUM
> && known_in_range_p (offset,
> - 0, (GET_MODE_ALIGNMENT (GET_MODE (memref))
> + 0, (MIN (GET_MODE_ALIGNMENT (GET_MODE
> (memref)), attrs.align)
> / BITS_PER_UNIT)))
> addr = gen_rtx_LO_SUM (address_mode, XEXP (addr, 0),
> plus_constant (address_mode,
>
> Don't know which one to trust. The memref has SImode. Caller wants to create
> HImode one. The attrs.align matches that of HImode.
on a strict-align target if the MEM has SImode it should be aligned to
the SImode alignment. Of course generally you should never look at
GET_MODE_ALIGNMENT but use attrs.align unconditionally (aka MEM_ALIGN).
Now the question is where the HImode aligned MEM:SI comes from for
a strict-alignment target. That said, unconditionally using attrs.align
looks like the correct fix.
next prev parent reply other threads:[~2021-05-17 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 15:15 [Bug middle-end/100604] New: " dragan.mladjenovic at syrmia dot com
2021-05-14 19:34 ` [Bug middle-end/100604] " pinskia at gcc dot gnu.org
2021-05-14 21:28 ` dragan.mladjenovic at syrmia dot com
2021-05-17 12:24 ` rguenth at gcc dot gnu.org [this message]
2021-05-22 16:21 ` dragan.mladjenovic at syrmia dot com
2023-11-29 18:45 ` pinskia at gcc dot gnu.org
2023-11-29 18:45 ` pinskia at gcc dot gnu.org
2024-04-17 19:31 ` pinskia at gcc dot gnu.org
2024-04-17 19:37 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-100604-4-K5p8JMvniF@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).