[Bug fortran/100607] New: ICE with SELECT RANK

[Bug fortran/100607] New: ICE with SELECT RANK

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

            Bug ID: 100607
           Summary: ICE with SELECT RANK
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
  Target Milestone: ---

Created attachment 50815
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50815&action=edit
Fortran testcase

The following program works, if the invalid code is commented.

The invalid part violates (quote from F202x but same in F2018):
  "C1158  A SELECT RANK construct shall not have aselect-rank-case-stmtthat is
RANK ( * )
   if the selector23has the ALLOCATABLE or POINTER attribute."


Hence, the code is invalid. Output is the following

Notes:
- '__tmp_INTEGER_4_rank_m1' error is bogus
- 'cannot be used' error is valid, but should only be printed once
- An ICE is always wrong, of course.



   24 |  rank(*) ! { dg-error "cannot be used with the pointer or allocatable
selector" }
Error: Allocatable array ‘__tmp_INTEGER_4_rank_m1’ at (1) must have a deferred
shape or assumed rank

   24 |  rank(*) ! { dg-error "cannot be used with the pointer or allocatable
selector" }
Error: RANK (*) at (1) cannot be used with the pointer or allocatable selector
at (2)

   24 |  rank(*) ! { dg-error "cannot be used with the pointer or allocatable
selector" }
Error: RANK (*) at (1) cannot be used with the pointer or allocatable selector
at (2)

f951: internal compiler error: in simplify_bound, at fortran/simplify.c:4266
0x619680 simplify_bound
        ../../repos/gcc/gcc/fortran/simplify.c:4266

[Bug fortran/100607] ICE with SELECT RANK

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-05-16
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

[Bug fortran/100607] ICE with SELECT RANK

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #1 from kargl at gcc dot gnu.org ---
I have no idea what the problem is here.  The code cleanly dies if the invalid
code is left in place.  It compiles and runs if the invalid code is removed. 
Perhaps, the bug was fixed in the last year.  Tobias, plaease check.

[Bug fortran/100607] ICE with SELECT RANK

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

[Bug fortran/100607] ICE with SELECT RANK

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |
           Priority|P3                          |P4

--- Comment #2 from kargl at gcc dot gnu.org ---
Remove ice-on-invalid-code as I don't get an ICE.

The following patch suppresses the error message with the temporary variable
and removes duplicated code.  Please commit.

diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 46585879ddc..3462d43f346 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -9909,11 +9909,6 @@ resolve_select_rank (gfc_code *code, gfc_namespace
*old_ns)
                               || gfc_expr_attr (code->expr1).pointer))
        gfc_error ("RANK (*) at %L cannot be used with the pointer or "
                   "allocatable selector at %L", &c->where,
&code->expr1->where);
-
-      if (case_value == -1 && (gfc_expr_attr (code->expr1).allocatable
-                              || gfc_expr_attr (code->expr1).pointer))
-       gfc_error ("RANK (*) at %L cannot be used with the pointer or "
-                  "allocatable selector at %L", &c->where,
&code->expr1->where);
     }

   /* Add EXEC_SELECT to switch on rank.  */
@@ -12948,7 +12943,9 @@ resolve_fl_var_and_proc (gfc_symbol *sym, int mp_flag)

       if (allocatable)
        {
-         if (dimension && as->type != AS_ASSUMED_RANK)
+         if (dimension
+             && as->type != AS_ASSUMED_RANK
+             && !sym->attr.select_rank_temporary)
            {
              gfc_error ("Allocatable array %qs at %L must have a deferred "
                         "shape or assumed rank", sym->name,
&sym->declared_at);

[Bug fortran/100607] ICE with SELECT RANK

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
                 CC|                            |anlauf at gcc dot gnu.org
           Keywords|                            |diagnostic

--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to kargl from comment #2)
> Remove ice-on-invalid-code as I don't get an ICE.
> 
> The following patch suppresses the error message with the temporary variable
> and removes duplicated code.  Please commit.
> 
> diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
> index 46585879ddc..3462d43f346 100644
> --- a/gcc/fortran/resolve.cc
> +++ b/gcc/fortran/resolve.cc
> @@ -9909,11 +9909,6 @@ resolve_select_rank (gfc_code *code, gfc_namespace
> *old_ns)
>  			       || gfc_expr_attr (code->expr1).pointer))
>  	gfc_error ("RANK (*) at %L cannot be used with the pointer or "
>  		   "allocatable selector at %L", &c->where, &code->expr1->where);
> -
> -      if (case_value == -1 && (gfc_expr_attr (code->expr1).allocatable
> -			       || gfc_expr_attr (code->expr1).pointer))
> -	gfc_error ("RANK (*) at %L cannot be used with the pointer or "
> -		   "allocatable selector at %L", &c->where, &code->expr1->where);
>      }
>  
>    /* Add EXEC_SELECT to switch on rank.  */

This is a gem: not dead code, but un-dead code ... ;-)

> @@ -12948,7 +12943,9 @@ resolve_fl_var_and_proc (gfc_symbol *sym, int
> mp_flag)
>  
>        if (allocatable)
>  	{
> -	  if (dimension && as->type != AS_ASSUMED_RANK)
> +	  if (dimension
> +	      && as->type != AS_ASSUMED_RANK
> +	      && !sym->attr.select_rank_temporary)
>  	    {
>  	      gfc_error ("Allocatable array %qs at %L must have a deferred "
>  			 "shape or assumed rank", sym->name, &sym->declared_at);

I remember that spot of code as it was hit by one of Gerhard's testcases
with as == NULL ...

I'll have a look.  The diagnostic indeed was bogus.

[Bug fortran/100607] ICE with SELECT RANK

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #4 from anlauf at gcc dot gnu.org ---
BTW: the "un-dead code" was introduced with r10-2912-g70570ec1927450 .

[Bug fortran/100607] ICE with SELECT RANK

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #5 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Apr 03, 2023 at 08:16:20PM +0000, anlauf at gcc dot gnu.org wrote:
> --- Comment #3 from anlauf at gcc dot gnu.org ---
> (In reply to kargl from comment #2)
> > Remove ice-on-invalid-code as I don't get an ICE.
> > 
> > The following patch suppresses the error message with the temporary variable
> > and removes duplicated code.  Please commit.
> > 
> > diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
> > index 46585879ddc..3462d43f346 100644
> > --- a/gcc/fortran/resolve.cc
> > +++ b/gcc/fortran/resolve.cc
> > @@ -9909,11 +9909,6 @@ resolve_select_rank (gfc_code *code, gfc_namespace
> > *old_ns)
> >  			       || gfc_expr_attr (code->expr1).pointer))
> >  	gfc_error ("RANK (*) at %L cannot be used with the pointer or "
> >  		   "allocatable selector at %L", &c->where, &code->expr1->where);
> > -
> > -      if (case_value == -1 && (gfc_expr_attr (code->expr1).allocatable
> > -			       || gfc_expr_attr (code->expr1).pointer))
> > -	gfc_error ("RANK (*) at %L cannot be used with the pointer or "
> > -		   "allocatable selector at %L", &c->where, &code->expr1->where);
> >      }
> >  
> >    /* Add EXEC_SELECT to switch on rank.  */
> 
> This is a gem: not dead code, but un-dead code ... ;-)
> 

What I haven't concluded yet is if the code was copied
with the intention to edit for another error condition,
e.g., "case_value == -2" or check on code->expr2.

[Bug fortran/100607] ICE with SELECT RANK

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #6 from kargl at gcc dot gnu.org ---
Created attachment 55191
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55191&action=edit
patch that fixes bug

The patch, which was previously submitted, still applies and fixes the bug.

[Bug fortran/100607] ICE with SELECT RANK

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to kargl from comment #6)
> Created attachment 55191 [details]
> patch that fixes bug
> 
> The patch, which was previously submitted, still applies and fixes the bug.

Sure.

Do you have an answer to your own remarks in comment#5?

[Bug fortran/100607] ICE with SELECT RANK

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #8 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Jun 01, 2023 at 07:26:43PM +0000, anlauf at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607
> 
> --- Comment #7 from anlauf at gcc dot gnu.org ---
> (In reply to kargl from comment #6)
> > Created attachment 55191 [details]
> > patch that fixes bug
> > 
> > The patch, which was previously submitted, still applies and fixes the bug.
> 
> Sure.
> 
> Do you have an answer to your own remarks in comment#5?
> 

I've concluded that the bug was reported 2 years agos.
It was fixed by a tentative patch 2 years laters.

'case_value == -1' is for 'rank(*)'.

'case_value == -2' appears to be for non-'rank(*)' cases,
and those are handled in the preceding nested for-loop.

[Bug fortran/100607] ICE with SELECT RANK

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #9 from anlauf at gcc dot gnu.org ---
(In reply to Steve Kargl from comment #8)
> 
> I've concluded that the bug was reported 2 years agos.
> It was fixed by a tentative patch 2 years laters.
> 
> 'case_value == -1' is for 'rank(*)'.
> 
> 'case_value == -2' appears to be for non-'rank(*)' cases,
> and those are handled in the preceding nested for-loop.

Then I can take care of the patch for you.

[Bug fortran/100607] ICE with SELECT RANK

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:fae09dfc0e6bf4cfe35d817558827aea78c6426f

commit r14-1505-gfae09dfc0e6bf4cfe35d817558827aea78c6426f
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Fri Jun 2 19:44:11 2023 +0200

    Fortran: fix diagnostics for SELECT RANK [PR100607]

    gcc/fortran/ChangeLog:

            PR fortran/100607
            * resolve.cc (resolve_select_rank): Remove duplicate error.
            (resolve_fl_var_and_proc): Prevent NULL pointer dereference and
            suppress error message for temporary.

    gcc/testsuite/ChangeLog:

            PR fortran/100607
            * gfortran.dg/select_rank_6.f90: New test.

[Bug fortran/100607] ICE with SELECT RANK

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from anlauf at gcc dot gnu.org ---
Fixed.

[Bug fortran/100607] ICE with SELECT RANK

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #12 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Fri, Jun 02, 2023 at 06:06:59PM +0000, anlauf at gcc dot gnu.org wrote:
> 
> --- Comment #11 from anlauf at gcc dot gnu.org ---
> Fixed.
> 

Thanks for taking care of the commit.

[Bug fortran/100607] ICE with SELECT RANK

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:bedb3eb53308f0bbfacb55b608f23b009504d892

commit r13-7412-gbedb3eb53308f0bbfacb55b608f23b009504d892
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Fri Jun 2 19:44:11 2023 +0200

    Fortran: fix diagnostics for SELECT RANK [PR100607]

    gcc/fortran/ChangeLog:

            PR fortran/100607
            * resolve.cc (resolve_select_rank): Remove duplicate error.
            (resolve_fl_var_and_proc): Prevent NULL pointer dereference and
            suppress error message for temporary.

    gcc/testsuite/ChangeLog:

            PR fortran/100607
            * gfortran.dg/select_rank_6.f90: New test.

    (cherry picked from commit fae09dfc0e6bf4cfe35d817558827aea78c6426f)

[Bug fortran/100607] ICE with SELECT RANK

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:59a264d5d8bb3fb73557aafc21319fd4fa6b1ab4

commit r12-9677-g59a264d5d8bb3fb73557aafc21319fd4fa6b1ab4
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Fri Jun 2 19:44:11 2023 +0200

    Fortran: fix diagnostics for SELECT RANK [PR100607]

    gcc/fortran/ChangeLog:

            PR fortran/100607
            * resolve.cc (resolve_select_rank): Remove duplicate error.
            (resolve_fl_var_and_proc): Prevent NULL pointer dereference and
            suppress error message for temporary.

    gcc/testsuite/ChangeLog:

            PR fortran/100607
            * gfortran.dg/select_rank_6.f90: New test.

    (cherry picked from commit fae09dfc0e6bf4cfe35d817558827aea78c6426f)

[Bug fortran/100607] ICE with SELECT RANK

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100607

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:37fdec3b7feca378693b3f12dbee422752176b24

commit r11-10844-g37fdec3b7feca378693b3f12dbee422752176b24
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Fri Jun 2 19:44:11 2023 +0200

    Fortran: fix diagnostics for SELECT RANK [PR100607]

    gcc/fortran/ChangeLog:

            PR fortran/100607
            * resolve.c (resolve_select_rank): Remove duplicate error.
            (resolve_fl_var_and_proc): Prevent NULL pointer dereference and
            suppress error message for temporary.

    gcc/testsuite/ChangeLog:

            PR fortran/100607
            * gfortran.dg/select_rank_6.f90: New test.

    (cherry picked from commit fae09dfc0e6bf4cfe35d817558827aea78c6426f)