[Bug jit/100613] New: libgccjit should produce dylib on macOS

[Bug jit/100613] New: libgccjit should produce dylib on macOS

[wyuenho at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

            Bug ID: 100613
           Summary: libgccjit should produce dylib on macOS
           Product: gcc
           Version: 11.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: jit
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: wyuenho at gmail dot com
  Target Milestone: ---

Created attachment 50818
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50818&action=edit
Make-lang.in patch to fix library ext on macOS

Compiling GCC with the language jit currently does not produce the correct
share library extension on macOS due to omission in Make-lang.in. The patch to
correct this is provided. You can also find the patch in Macports at
https://raw.githubusercontent.com/macports/macports-ports/master/lang/gcc11/files/patch-Make-lang.in.diff

[Bug jit/100613] libgccjit should produce dylib on macOS

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org,
                   |                            |iains at gcc dot gnu.org
           Keywords|                            |patch

--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
Please send the patch to the gcc-patches mailing list for review; it's likely
to get lost if it's only here.

[Bug jit/100613] libgccjit should produce dylib on macOS

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dmalcolm at gcc dot gnu.org        |iains at gcc dot gnu.org
   Last reconfirmed|                            |2021-08-05
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |11.3
     Ever confirmed|0                           |1

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
I have a preference for setting the correct library name when it is created,
and for setting the library versioning information in the 'usual' Darwin way.

The reason being that I have patches in flight for using "@rpath/....." for the
library names to fix the issues we have with testing on platforms with SIP
enabled (post 10.11).

Patches are under test.

NOTE there are issues with testing too - namely that the testsuite code is
currently making assumptions about support for --export-dynamic (it should
conditionally use -rdynamic IMO) and also that it assumes dejagnu.h is visible
in the default compiler lookup paths (it isn't on Darwin)... then we reach the
obstacle that the dejagnu.h from at least 1.6.2 has an unused variable in C
compilations + the wait function declaration clashes with the system's decl for
'wait'.

When all these things are fixed, we have two more issues that I've not been
able to address yet - namely that we get bad code-gen when "-g" is on the
command line, and that it seems that sometimes we get hanging tests that are
not killed by the testsuite machinery - so that the whole "make check" hangs.

At least I plan to address the issues for which the solution is clear - for the
last two things I think that more understanding of the processes used by the
Jit will be needed.

[Bug jit/100613] libgccjit should produce dylib on macOS

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:08defd9c4e4f8dc428f2f490705ab816af81a03d

commit r12-3008-g08defd9c4e4f8dc428f2f490705ab816af81a03d
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Aug 5 09:55:19 2021 +0100

    Darwin, jit: Fix build [PR100613].

    The generic unix build is not completely suitable for Darwin
    platforms:

     * It is a convention to encode the library versioning in the
       binary and to have only one level of symlink for the installed
       files. This needs to be applied to the installation too.
     * The library needs to be built with its correct install name
       so that two-level library naming works.
     * The extension for shared libraries should be .dylib

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

    PR jit/100613 - libgccjit should produce dylib on macOS

            PR jit/100613

    gcc/jit/ChangeLog:

            * Make-lang.in: Provide clauses for Darwin hosts.

[Bug jit/100613] libgccjit should produce dylib on macOS

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:846d19e44c85c83a50e51867d854f8d98a087a77

commit r11-9857-g846d19e44c85c83a50e51867d854f8d98a087a77
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Aug 5 09:55:19 2021 +0100

    Darwin, jit: Fix build [PR100613].

    The generic unix build is not completely suitable for Darwin
    platforms:

     * It is a convention to encode the library versioning in the
       binary and to have only one level of symlink for the installed
       files. This needs to be applied to the installation too.
     * The library needs to be built with its correct install name
       so that two-level library naming works.
     * The extension for shared libraries should be .dylib

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

    PR jit/100613 - libgccjit should produce dylib on macOS

            PR jit/100613

    gcc/jit/ChangeLog:

            * Make-lang.in: Provide clauses for Darwin hosts.

    (cherry picked from commit 08defd9c4e4f8dc428f2f490705ab816af81a03d)

[Bug jit/100613] libgccjit should produce dylib on macOS

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.3                        |11.4

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.3 is being released, retargeting bugs to GCC 11.4.

[Bug jit/100613] libgccjit should produce dylib on macOS

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:e1f99a4b0563e53a6ea5d03b44d5a4c27699c50b

commit r10-10820-ge1f99a4b0563e53a6ea5d03b44d5a4c27699c50b
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Aug 5 09:55:19 2021 +0100

    Darwin, jit: Fix build [PR100613].

    The generic unix build is not completely suitable for Darwin
    platforms:

     * It is a convention to encode the library versioning in the
       binary and to have only one level of symlink for the installed
       files. This needs to be applied to the installation too.
     * The library needs to be built with its correct install name
       so that two-level library naming works.
     * The extension for shared libraries should be .dylib

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

    PR jit/100613 - libgccjit should produce dylib on macOS

            PR jit/100613

    gcc/jit/ChangeLog:

            * Make-lang.in: Provide clauses for Darwin hosts.

    (cherry picked from commit 08defd9c4e4f8dc428f2f490705ab816af81a03d)

[Bug jit/100613] libgccjit should produce dylib on macOS

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100613

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> ---
so fixed on open branches.