* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
@ 2021-05-24 21:11 ` redi at gcc dot gnu.org
2021-05-24 21:27 ` seurer at gcc dot gnu.org
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-05-24 21:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-05-24
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
And apparently even on x86_64-pc-linux-gnu, though I don't see it:
https://gcc.gnu.org/pipermail/libstdc++/2021-May/052592.html
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
2021-05-24 21:11 ` [Bug testsuite/100748] " redi at gcc dot gnu.org
@ 2021-05-24 21:27 ` seurer at gcc dot gnu.org
2021-05-24 23:47 ` redi at gcc dot gnu.org
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: seurer at gcc dot gnu.org @ 2021-05-24 21:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #2 from seurer at gcc dot gnu.org ---
I do see it failing on at least one powerpc64 LE machine. PR97944 said it used
to fail randomly.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
2021-05-24 21:11 ` [Bug testsuite/100748] " redi at gcc dot gnu.org
2021-05-24 21:27 ` seurer at gcc dot gnu.org
@ 2021-05-24 23:47 ` redi at gcc dot gnu.org
2021-05-25 7:43 ` rguenth at gcc dot gnu.org
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-05-24 23:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I'd better disable it again until I have time to figure it out.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2021-05-24 23:47 ` redi at gcc dot gnu.org
@ 2021-05-25 7:43 ` rguenth at gcc dot gnu.org
2021-09-09 3:06 ` law at gcc dot gnu.org
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-05-25 7:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2021-05-25 7:43 ` rguenth at gcc dot gnu.org
@ 2021-09-09 3:06 ` law at gcc dot gnu.org
2021-09-09 6:35 ` redi at gcc dot gnu.org
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: law at gcc dot gnu.org @ 2021-09-09 3:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #4 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Bernd E. analyzed this in the thread referenced in c#1.
The test links staticly and we're pulling in the weak definition of
pthread_join.
I'm not sure why we're linking statically. Reverting to normal dynamic linking
would likely fix this problem.
If that's not desired, then something like --whole-archive -lpthread
--no-whole-archive in the link line will make this work as long as it appears
before -lc.
Or we could add -Wl,-u,pthread_join to the link line.
Or we could hack up the source per Bernd's patch in that thread.
No strong opinions here. Just trying to get another failure resolved on our
target :-)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2021-09-09 3:06 ` law at gcc dot gnu.org
@ 2021-09-09 6:35 ` redi at gcc dot gnu.org
2021-10-09 0:26 ` redi at gcc dot gnu.org
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-09 6:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
PR 95989 is specifically about static linking.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (5 preceding siblings ...)
2021-09-09 6:35 ` redi at gcc dot gnu.org
@ 2021-10-09 0:26 ` redi at gcc dot gnu.org
2021-10-09 5:07 ` law at gcc dot gnu.org
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-10-09 0:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Status|NEW |ASSIGNED
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (6 preceding siblings ...)
2021-10-09 0:26 ` redi at gcc dot gnu.org
@ 2021-10-09 5:07 ` law at gcc dot gnu.org
2021-10-09 7:07 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: law at gcc dot gnu.org @ 2021-10-09 5:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #6 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Jon -- you might want to sync with the glibc folks. IIUC they're rolled
libpthread into libc in glibc-2.34 which may make this is a non-issue going
forward, which I can certainly live with.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (7 preceding siblings ...)
2021-10-09 5:07 ` law at gcc dot gnu.org
@ 2021-10-09 7:07 ` redi at gcc dot gnu.org
2021-11-09 20:05 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-10-09 7:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes but the point of the test (and the change it is meant to be testing) is to
verify it works before those changes.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (8 preceding siblings ...)
2021-10-09 7:07 ` redi at gcc dot gnu.org
@ 2021-11-09 20:05 ` redi at gcc dot gnu.org
2021-11-10 12:04 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-11-09 20:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think it's exactly those changes which have caused this FAIL. See PR
libstdc++/103133 (which I have a patch for, and which fixes this).
Is everybody seeing this FAIL using glibc 2.34?
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (9 preceding siblings ...)
2021-11-09 20:05 ` redi at gcc dot gnu.org
@ 2021-11-10 12:04 ` cvs-commit at gcc dot gnu.org
2021-11-10 12:08 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-10 12:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:80fe172ba9820199c2bbce5d0611ffca27823049
commit r12-5108-g80fe172ba9820199c2bbce5d0611ffca27823049
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 9 23:45:36 2021 +0000
libstdc++: Disable gthreads weak symbols for glibc 2.34 [PR103133]
Since Glibc 2.34 all pthreads symbols are defined directly in libc not
libpthread, and since Glibc 2.32 we have used __libc_single_threaded to
avoid unnecessary locking in single-threaded programs. This means there
is no reason to avoid linking to libpthread now, and so no reason to use
weak symbols defined in gthr-posix.h for all the pthread_xxx functions.
libstdc++-v3/ChangeLog:
PR libstdc++/100748
PR libstdc++/103133
* config/os/gnu-linux/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
Define for glibc 2.34 and later.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (10 preceding siblings ...)
2021-11-10 12:04 ` cvs-commit at gcc dot gnu.org
@ 2021-11-10 12:08 ` redi at gcc dot gnu.org
2021-11-24 11:52 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2021-11-10 12:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This should be fixed now. Please reopen if not.
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (11 preceding siblings ...)
2021-11-10 12:08 ` redi at gcc dot gnu.org
@ 2021-11-24 11:52 ` cvs-commit at gcc dot gnu.org
2022-08-03 12:30 ` cvs-commit at gcc dot gnu.org
2022-08-03 13:33 ` redi at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-24 11:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:293075002a7eaf1e9d457a1839bcaf83f8626824
commit r11-9301-g293075002a7eaf1e9d457a1839bcaf83f8626824
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 9 23:45:36 2021 +0000
libstdc++: Disable gthreads weak symbols for glibc 2.34 [PR103133]
Since Glibc 2.34 all pthreads symbols are defined directly in libc not
libpthread, and since Glibc 2.32 we have used __libc_single_threaded to
avoid unnecessary locking in single-threaded programs. This means there
is no reason to avoid linking to libpthread now, and so no reason to use
weak symbols defined in gthr-posix.h for all the pthread_xxx functions.
libstdc++-v3/ChangeLog:
PR libstdc++/100748
PR libstdc++/103133
* config/os/gnu-linux/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
Define for glibc 2.34 and later.
(cherry picked from commit 80fe172ba9820199c2bbce5d0611ffca27823049)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (12 preceding siblings ...)
2021-11-24 11:52 ` cvs-commit at gcc dot gnu.org
@ 2022-08-03 12:30 ` cvs-commit at gcc dot gnu.org
2022-08-03 13:33 ` redi at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-08-03 12:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:18eecb8c4a97716d4bc4890b05c91f172fadc7b3
commit r10-10928-g18eecb8c4a97716d4bc4890b05c91f172fadc7b3
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 9 23:45:36 2021 +0000
libstdc++: Disable gthreads weak symbols for glibc 2.34 [PR103133]
Since Glibc 2.34 all pthreads symbols are defined directly in libc not
libpthread, and since Glibc 2.32 we have used __libc_single_threaded to
avoid unnecessary locking in single-threaded programs. This means there
is no reason to avoid linking to libpthread now, and so no reason to use
weak symbols defined in gthr-posix.h for all the pthread_xxx functions.
libstdc++-v3/ChangeLog:
PR libstdc++/100748
PR libstdc++/103133
* config/os/gnu-linux/os_defines.h (_GLIBCXX_GTHREAD_USE_WEAK):
Define for glibc 2.34 and later.
(cherry picked from commit 80fe172ba9820199c2bbce5d0611ffca27823049)
^ permalink raw reply [flat|nested] 16+ messages in thread* [Bug testsuite/100748] [12 regression] 30_threads/jthread/95989.cc fails after r12-843
2021-05-24 20:58 [Bug testsuite/100748] New: [12 regression] 30_threads/jthread/95989.cc fails after r12-843 seurer at gcc dot gnu.org
` (13 preceding siblings ...)
2022-08-03 12:30 ` cvs-commit at gcc dot gnu.org
@ 2022-08-03 13:33 ` redi at gcc dot gnu.org
14 siblings, 0 replies; 16+ messages in thread
From: redi at gcc dot gnu.org @ 2022-08-03 13:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100748
--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 11.3 and 10.5 too.
^ permalink raw reply [flat|nested] 16+ messages in thread