public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/101045] New: config/i386/subst.md: 76: possible cut'n'paste error ?
@ 2021-06-13  8:28 dcb314 at hotmail dot com
  2021-06-14  9:09 ` [Bug target/101045] " marxin at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: dcb314 at hotmail dot com @ 2021-06-13  8:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101045

            Bug ID: 101045
           Summary: config/i386/subst.md: 76: possible cut'n'paste error ?
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I am a novice at Coverity, but it says:

*** CID 1485952:  Incorrect expression  (COPY_PASTE_ERROR)
/root/gcc-coverity/gcc/config/i386/subst.md: 76 in recog_97(rtx_def *, rtx_insn
*, int *)()
70             (match_operand:SUBST_V 1))]
71       "TARGET_AVX512F"
72       [(set (match_dup 0)
73             (vec_merge:SUBST_V
74         (match_dup 1)
75         (match_operand:SUBST_V 2 "nonimm_or_0_operand" "0C")
>>>     CID 1485952:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "pattern1062" in "pattern1062(x2, E_V8DImode, E_V16DImode)" looks like a copy-paste error.
76         (match_operand:<avx512fmaskmode> 3 "register_operand" "Yk")))])

My best guess is that the 3 should be a smaller number. Advice sought.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/101045] config/i386/subst.md: 76: possible cut'n'paste error ?
  2021-06-13  8:28 [Bug target/101045] New: config/i386/subst.md: 76: possible cut'n'paste error ? dcb314 at hotmail dot com
@ 2021-06-14  9:09 ` marxin at gcc dot gnu.org
  2021-06-14  9:34 ` jakub at gcc dot gnu.org
  2021-09-12 23:40 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-06-14  9:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101045

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
@Jakub: Can you please take a look?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/101045] config/i386/subst.md: 76: possible cut'n'paste error ?
  2021-06-13  8:28 [Bug target/101045] New: config/i386/subst.md: 76: possible cut'n'paste error ? dcb314 at hotmail dot com
  2021-06-14  9:09 ` [Bug target/101045] " marxin at gcc dot gnu.org
@ 2021-06-14  9:34 ` jakub at gcc dot gnu.org
  2021-09-12 23:40 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-06-14  9:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101045

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
subst.md is just fine, and it is unclear why Coverity thinks there is any copy
and paste error, this is all generated code and matches what should be
generated.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/101045] config/i386/subst.md: 76: possible cut'n'paste error ?
  2021-06-13  8:28 [Bug target/101045] New: config/i386/subst.md: 76: possible cut'n'paste error ? dcb314 at hotmail dot com
  2021-06-14  9:09 ` [Bug target/101045] " marxin at gcc dot gnu.org
  2021-06-14  9:34 ` jakub at gcc dot gnu.org
@ 2021-09-12 23:40 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-12 23:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101045

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
#line 71 "/home/apinski/src/upstream-gcc-git/gcc/gcc/config/i386/subst.md"
(TARGET_AVX512F))
            return -1;
          return 3191; /* avx512f_alignv8di_mask */

        case E_V4DImode:
          if (pattern334 (x2, E_V4DImode, E_QImode) != 0
              || !(
#line 71 "/home/apinski/src/upstream-gcc-git/gcc/gcc/config/i386/subst.md"
(TARGET_AVX512F) && (
#line 10090 "/home/apinski/src/upstream-gcc-git/gcc/gcc/config/i386/sse.md"
(TARGET_AVX512F) &&
#line 333 "/home/apinski/src/upstream-gcc-git/gcc/gcc/config/i386/sse.md"
(TARGET_AVX512VL))))
            return -1;



Yes this is generated code so having TARGET_AVX512F twice will happen.
Also I am not shocked at coverity also getting the lines wrong with the
expression over multiple lines.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-12 23:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-13  8:28 [Bug target/101045] New: config/i386/subst.md: 76: possible cut'n'paste error ? dcb314 at hotmail dot com
2021-06-14  9:09 ` [Bug target/101045] " marxin at gcc dot gnu.org
2021-06-14  9:34 ` jakub at gcc dot gnu.org
2021-09-12 23:40 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).