[Bug ada/101094] New: [11 regression] 'Enum_Rep returns a unsigned value for the negative representation in gcc-11

[Bug ada/101094] New: [11 regression] 'Enum_Rep returns a unsigned value for the negative representation in gcc-11

[demoonlit at panathenaia dot halfmoon.jp]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

            Bug ID: 101094
           Summary: [11 regression] 'Enum_Rep returns a unsigned value for
                    the negative representation in gcc-11
           Product: gcc
           Version: 11.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: demoonlit at panathenaia dot halfmoon.jp
  Target Milestone: ---

'Enum_Rep returns a unsigned value for the run-time value having the negative
representation in gcc-11.
It also returns just a representation value for the compile-time value.

In gcc-10 or older, it always returns just a representation value.
Is this intentional changed or not?

Test code
---------

with Ada.Text_IO;
with Ada.Integer_Text_IO;
procedure main is
   type T is (Nega, Zero, Posi);
   for T use (Nega => -1, Zero => 0, Posi => 1);
begin
   -- literal
   Ada.Text_IO.Put ("Lite:");
   Ada.Integer_Text_IO.Put (T'Enum_Rep (Nega)); -- "-1"
   Ada.Text_IO.New_Line;
   -- compile-time constant
   declare
      Cons : constant T := Nega;
   begin
      Ada.Text_IO.Put ("Cons:");
      Ada.Integer_Text_IO.Put (T'Enum_Rep (Cons)); -- "-1"
      Ada.Text_IO.New_Line;
   end;
   -- variable
   declare
      Vari : T := T'Value ("Nega");
   begin
      Ada.Text_IO.Put ("Vari:");
      Ada.Integer_Text_IO.Put (T'Enum_Rep (Vari)); -- "255"
      Ada.Text_IO.New_Line;
   end;
   -- parameter
   declare
      procedure Sub1 (Para : T) is
      begin
         Ada.Text_IO.Put ("Para:");
         Ada.Integer_Text_IO.Put (T'Enum_Rep (Para)); -- "255"
         Ada.Text_IO.New_Line;
      end Sub1;
   begin
      Sub1 (Nega);
   end;
end main;

With gcc-10
-----------

$ gnatmake --version
GNATMAKE 10.2.0
Copyright (C) 1995-2020, Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

$ gnatmake main
gcc -c main.adb
gnatbind -x main.ali
gnatlink main.ali

$ ./main
Lite:         -1
Cons:         -1
Vari:         -1
Para:         -1

With gcc-11
-----------

$ gnatmake --version
GNATMAKE 11.1.0
Copyright (C) 1995-2021, Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

$ gnatmake main
gcc -c main.adb
gnatbind -x main.ali
gnatlink main.ali

% ./main
Lite:         -1
Cons:         -1
Vari:        255
Para:        255

Thanks.

[Bug ada/101094] [11/12 regression] 'Enum_Rep returns a unsigned value for the negative representation in gcc-11

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.2
            Summary|[11 regression] 'Enum_Rep   |[11/12 regression]
                   |returns a unsigned value    |'Enum_Rep returns a
                   |for the negative            |unsigned value for the
                   |representation in gcc-11    |negative representation in
                   |                            |gcc-11

[Bug ada/101094] [11/12 regression] 'Enum_Rep returns a unsigned value for the negative representation in gcc-11

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-06-30
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> In gcc-10 or older, it always returns just a representation value.
> Is this intentional changed or not?

No, it's an oversight.

[Bug ada/101094] [11/12 regression] 'Enum_Rep returns a unsigned value for the negative representation in gcc-11

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ebotcazou at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixing.

[Bug ada/101094] [11/12 regression] Enum_Rep returns unsigned value for negative representation

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:cdf4576b201aa81fd853b06242b16e4215ead5a9

commit r12-1961-gcdf4576b201aa81fd853b06242b16e4215ead5a9
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Thu Jul 1 17:57:16 2021 +0200

    Use intermediate integer type with proper signedness

    This is a minor regression present on mainline and 11 branch, whereby the
    value of the Enum_Rep attribute is always unsigned.

    gcc/ada/
            PR ada/101094
            * exp_attr.adb (Get_Integer_Type): Return an integer type with the
            same signedness as the input type.

[Bug ada/101094] [11/12 regression] Enum_Rep returns unsigned value for negative representation

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Eric Botcazou
<ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:3a17c1663a96640874067988ffe36c1d06fb93a1

commit r11-8667-g3a17c1663a96640874067988ffe36c1d06fb93a1
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Thu Jul 1 17:57:16 2021 +0200

    Use intermediate integer type with proper signedness

    This is a minor regression present on mainline and 11 branch, whereby the
    value of the Enum_Rep attribute is always unsigned.

    gcc/ada/
            PR ada/101094
            * exp_attr.adb (Get_Integer_Type): Return an integer type with the
            same signedness as the input type.

[Bug ada/101094] [11/12 regression] Enum_Rep returns unsigned value for negative representation

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101094

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks for reporting the problem.