[Bug c/101171] New: [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[Bug c/101171] New: [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[anbu1024.me at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

            Bug ID: 101171
           Summary: [12 Regression] ICE: tree check: expected class
                    ‘type’, have ‘exceptional’ (error_mark) in
                    c_expr_sizeof_expr, at c/c-typeck.c:3006
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: anbu1024.me at gmail dot com
  Target Milestone: ---

$ cat 34.c 

extern void foo(void);
int x = 0x1234;

int bar()
{
  if (x !=  ( sizeof( (enum t) 0x1234) ) )
    foo();
}

-------------------------------------------------------------------------------

$ gcc-sp12 --version
gcc (GCC) 12.0.0 20210620 (experimental)
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-------------------------------------------------------------------------------

$ gcc-sp12 34.c 
34.c: In function ‘bar’:
34.c:7:29: error: conversion to incomplete type
    7 |   if (x !=  ( sizeof( (enum t) 0x1234) ) )
      |                             ^
34.c:7:29: internal compiler error: tree check: expected class ‘type’, have
‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006
0x7a313c tree_class_check_failed(tree_node const*, tree_code_class, char
const*, int, char const*)
        ../../gcc-12-20210620/gcc/tree.c:8734
0x65d005 tree_class_check(tree_node*, tree_code_class, char const*, int, char
const*)
        ../../gcc-12-20210620/gcc/tree.h:3494
0x65d005 c_expr_sizeof_expr(unsigned int, c_expr)
        ../../gcc-12-20210620/gcc/c/c-typeck.c:3006
0x8c573e c_parser_sizeof_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:8299
0x8c573e c_parser_unary_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:8196
0x8c6309 c_parser_cast_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:8066
0x8c657c c_parser_binary_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:7869
0x8c7835 c_parser_conditional_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:7592
0x8c7e70 c_parser_expr_no_commas
        ../../gcc-12-20210620/gcc/c/c-parser.c:7507
0x8c80f1 c_parser_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:10638
0x8c0853 c_parser_postfix_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:9086
0x8c4b4a c_parser_unary_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:8224
0x8c6309 c_parser_cast_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:8066
0x8c66f4 c_parser_binary_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:7992
0x8c7835 c_parser_conditional_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:7592
0x8c7e70 c_parser_expr_no_commas
        ../../gcc-12-20210620/gcc/c/c-parser.c:7507
0x8c80f1 c_parser_expression
        ../../gcc-12-20210620/gcc/c/c-parser.c:10638
0x8c9655 c_parser_expression_conv
        ../../gcc-12-20210620/gcc/c/c-parser.c:10677
0x8c9655 c_parser_condition
        ../../gcc-12-20210620/gcc/c/c-parser.c:6277
0x8c973b c_parser_paren_condition
        ../../gcc-12-20210620/gcc/c/c-parser.c:6297
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

-------------------------------------------------------------------------------

$ gcc-sp11 --version
gcc (GCC) 11.1.1 20210619
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-------------------------------------------------------------------------------

$ gcc-sp11 34.c 
34.c: In function ‘bar’:
34.c:7:29: error: conversion to incomplete type
    7 |   if (x !=  ( sizeof( (enum t) 0x1234) ) )
      |                             ^

[Bug c/101171] [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |error-recovery,
                   |                            |ice-checking,
                   |                            |ice-on-invalid-code

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Is your GCC 11 compiler checking-enabled?  I doubt it is a regression.

[Bug c/101171] [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-06-23
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |jsm28 at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r10-5922-g3d77686d2eddf76d.

[Bug c/101171] [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[anbu1024.me at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

--- Comment #3 from John X <anbu1024.me at gmail dot com> ---
(In reply to Richard Biener from comment #1)
> Is your GCC 11 compiler checking-enabled?  I doubt it is a regression.

gcc 11 build command:
```
configure --prefix=install_path --enable-languages=c --disable-multilib
```

Platform: Ubuntu 20.04 x64

[Bug c/101171] [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 51057
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51057&action=edit
gcc12-pr101171.patch

Untested fix.

[Bug c/101171] [12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:fdc5522fb04b4a820b28c4d1f16f54897f5978de

commit r12-1790-gfdc5522fb04b4a820b28c4d1f16f54897f5978de
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:55:28 2021 +0200

    c: Fix C cast error-recovery [PR101171]

    The following testcase ICEs during error-recovery, as build_c_cast calls
    note_integer_operands on error_mark_node and that wraps it into
    C_MAYBE_CONST_EXPR which is unexpected and causes ICE later on.
    Seems most other callers of note_integer_operands check early if something
    is error_mark_node and return before calling note_integer_operands on it.

    The following patch fixes it by not calling on error_mark_node, another
    possibility would be to handle error_mark_node in note_integer_operands and
    just return it.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101171
            * c-typeck.c (build_c_cast): Don't call note_integer_operands on
            error_mark_node.

            * gcc.dg/pr101171.c: New test.

[Bug c/101171] [10/11/12 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |10.4
            Summary|[12 Regression] ICE: tree   |[10/11/12 Regression] ICE:
                   |check: expected class       |tree check: expected class
                   |‘type’, have ‘exceptional’  |‘type’, have ‘exceptional’
                   |(error_mark) in             |(error_mark) in
                   |c_expr_sizeof_expr, at      |c_expr_sizeof_expr, at
                   |c/c-typeck.c:3006           |c/c-typeck.c:3006

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug c/101171] [10/11 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6c9eaa1de2c4d600c236bc2d95be66dbc3a27b2e

commit r11-8766-g6c9eaa1de2c4d600c236bc2d95be66dbc3a27b2e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:55:28 2021 +0200

    c: Fix C cast error-recovery [PR101171]

    The following testcase ICEs during error-recovery, as build_c_cast calls
    note_integer_operands on error_mark_node and that wraps it into
    C_MAYBE_CONST_EXPR which is unexpected and causes ICE later on.
    Seems most other callers of note_integer_operands check early if something
    is error_mark_node and return before calling note_integer_operands on it.

    The following patch fixes it by not calling on error_mark_node, another
    possibility would be to handle error_mark_node in note_integer_operands and
    just return it.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101171
            * c-typeck.c (build_c_cast): Don't call note_integer_operands on
            error_mark_node.

            * gcc.dg/pr101171.c: New test.

    (cherry picked from commit fdc5522fb04b4a820b28c4d1f16f54897f5978de)

[Bug c/101171] [10 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11 Regression] ICE:     |[10 Regression] ICE: tree
                   |tree check: expected class  |check: expected class
                   |‘type’, have ‘exceptional’  |‘type’, have ‘exceptional’
                   |(error_mark) in             |(error_mark) in
                   |c_expr_sizeof_expr, at      |c_expr_sizeof_expr, at
                   |c/c-typeck.c:3006           |c/c-typeck.c:3006

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.2 too.

[Bug c/101171] [10 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doko at debian dot org

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 97892 has been marked as a duplicate of this bug. ***

[Bug c/101171] [10 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |changochen1 at gmail dot com

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 93574 has been marked as a duplicate of this bug. ***

[Bug c/101171] [10 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ca1771b4efc555a0499975f75a5158b72722cfa0

commit r10-10626-gca1771b4efc555a0499975f75a5158b72722cfa0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:55:28 2021 +0200

    c: Fix C cast error-recovery [PR101171]

    The following testcase ICEs during error-recovery, as build_c_cast calls
    note_integer_operands on error_mark_node and that wraps it into
    C_MAYBE_CONST_EXPR which is unexpected and causes ICE later on.
    Seems most other callers of note_integer_operands check early if something
    is error_mark_node and return before calling note_integer_operands on it.

    The following patch fixes it by not calling on error_mark_node, another
    possibility would be to handle error_mark_node in note_integer_operands and
    just return it.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101171
            * c-typeck.c (build_c_cast): Don't call note_integer_operands on
            error_mark_node.

            * gcc.dg/pr101171.c: New test.

    (cherry picked from commit fdc5522fb04b4a820b28c4d1f16f54897f5978de)

[Bug c/101171] [10 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:be5f5f6ea368e2b8b9a0012ecbe2e83aeabdf714

commit r9-10083-gbe5f5f6ea368e2b8b9a0012ecbe2e83aeabdf714
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:55:28 2021 +0200

    c: Fix C cast error-recovery [PR101171]

    The following testcase ICEs during error-recovery, as build_c_cast calls
    note_integer_operands on error_mark_node and that wraps it into
    C_MAYBE_CONST_EXPR which is unexpected and causes ICE later on.
    Seems most other callers of note_integer_operands check early if something
    is error_mark_node and return before calling note_integer_operands on it.

    The following patch fixes it by not calling on error_mark_node, another
    possibility would be to handle error_mark_node in note_integer_operands and
    just return it.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101171
            * c-typeck.c (build_c_cast): Don't call note_integer_operands on
            error_mark_node.

            * gcc.dg/pr101171.c: New test.

    (cherry picked from commit fdc5522fb04b4a820b28c4d1f16f54897f5978de)

[Bug c/101171] [10 Regression] ICE: tree check: expected class ‘type’, have ‘exceptional’ (error_mark) in c_expr_sizeof_expr, at c/c-typeck.c:3006

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101171

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.