[Bug c/101176] New: valgrind error for c-c++-common/builtin-has-attribute.c

[Bug c/101176] New: valgrind error for c-c++-common/builtin-has-attribute.c

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

            Bug ID: 101176
           Summary: valgrind error for
                    c-c++-common/builtin-has-attribute.c
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

For the gcc testsuite file c-c++-common/builtin-has-attribute.c
and a recent build of gcc trunk with valgrind, I get:

./c-c++-common/builtin-has-attribute.c:31:32: error: ‘foobar’ undeclared (first 
use in this function)
   31 |   b = __builtin_has_attribute (foobar, aligned);  /* { dg-error
".foobar
. \(undeclared|was not declared\)" } */
      |                                ^~~~~~
==104199== Use of uninitialised value of size 8
==104199==    at 0x16EDF70: htab_find_slot_with_hash (hashtab.c:654)
==104199==    by 0x169B7CD: get_combined_adhoc_loc(line_maps*, unsigned int,
sou
rce_range, void*) (line-map.c:208)

Since this valgrind error is for C code with errors in it, I think
this is reduced priority.

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-06-23
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 51058
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51058&action=edit
gcc12-pr101176.patch

Untested fix.

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:178fb8df9315f2f8f45b7fe5faf11a9c2912cc28

commit r12-1791-g178fb8df9315f2f8f45b7fe5faf11a9c2912cc28
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:58:02 2021 +0200

    c: Fix up c_parser_has_attribute_expression [PR101176]

    This function keeps src_range member of the result uninitialized, which at
    least under valgrind can show up later when those uninitialized
location_t's
    can make it into the IL or location_t hash tables.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101176
            * c-parser.c (c_parser_has_attribute_expression): Set source range
for
            the result.

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.  Guess it needs fixing in 9/10/11 too.

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:72ff4a04bb33795fe5b6d5863a66cac5293559b6

commit r11-8767-g72ff4a04bb33795fe5b6d5863a66cac5293559b6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:58:02 2021 +0200

    c: Fix up c_parser_has_attribute_expression [PR101176]

    This function keeps src_range member of the result uninitialized, which at
    least under valgrind can show up later when those uninitialized
location_t's
    can make it into the IL or location_t hash tables.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101176
            * c-parser.c (c_parser_has_attribute_expression): Set source range
for
            the result.

    (cherry picked from commit 178fb8df9315f2f8f45b7fe5faf11a9c2912cc28)

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:930520db8e2d01fd8cf064c0ae2f61b683248762

commit r10-10627-g930520db8e2d01fd8cf064c0ae2f61b683248762
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:58:02 2021 +0200

    c: Fix up c_parser_has_attribute_expression [PR101176]

    This function keeps src_range member of the result uninitialized, which at
    least under valgrind can show up later when those uninitialized
location_t's
    can make it into the IL or location_t hash tables.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101176
            * c-parser.c (c_parser_has_attribute_expression): Set source range
for
            the result.

    (cherry picked from commit 178fb8df9315f2f8f45b7fe5faf11a9c2912cc28)

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d8e3b3434dd68cea757bee2fedfc72e94ab0804c

commit r9-10084-gd8e3b3434dd68cea757bee2fedfc72e94ab0804c
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 24 15:58:02 2021 +0200

    c: Fix up c_parser_has_attribute_expression [PR101176]

    This function keeps src_range member of the result uninitialized, which at
    least under valgrind can show up later when those uninitialized
location_t's
    can make it into the IL or location_t hash tables.

    2021-06-24  Jakub Jelinek  <jakub@redhat.com>

            PR c/101176
            * c-parser.c (c_parser_has_attribute_expression): Set source range
for
            the result.

    (cherry picked from commit 178fb8df9315f2f8f45b7fe5faf11a9c2912cc28)

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug c/101176] valgrind error for c-c++-common/builtin-has-attribute.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101176

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.5