[Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h

[Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h

[kip at thevertigo dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

            Bug ID: 101228
           Summary: #include <execution> triggers Intel TBB warning for
                    tbb/task.h
           Product: gcc
           Version: 11.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: kip at thevertigo dot com
  Target Milestone: ---

I've managed to reproduce this issue on two different machines, one amd64 and
the other ppc64le. Both were using g++-11 (Ubuntu 11.1.0-1ubuntu1~21.04)
11.1.0.

Here is a minimal:

#include <algorithm>
#include <execution>

using namespace std;

int main()
{
    vector<long int> Container(3'000'000);
    iota(begin(Container), end(Container), 1);

    sort(execution::par, begin(Container), end(Container));

    return 0;
}

Compiling raises the following pragma in header generated warning:

$ g++-11 test.cpp -o test -Wall -Werror -std=c++17 -ltbb && ./test
In file included from /usr/include/c++/11/pstl/parallel_backend_tbb.h:26,
                 from /usr/include/c++/11/pstl/parallel_backend.h:20,
                 from /usr/include/c++/11/pstl/algorithm_impl.h:22,
                 from /usr/include/c++/11/pstl/glue_execution_defs.h:50,
                 from /usr/include/c++/11/execution:32,
                 from test.cpp:4:
/usr/include/tbb/task.h:21:139: note: ‘#pragma message: TBB Warning: tbb/task.h
is deprecated. For details, please see Deprecated Features appendix in the TBB
reference manual.’
   21 | ("TBB Warning: tbb/task.h is deprecated. For details, please see
Deprecated Features appendix in the TBB reference manual.")
      |                                                                        
                                                   ^

Compiling again with #define TBB_SUPPRESS_DEPRECATED_MESSAGES 1 prepended to
the beginning and the warning disappears.

This appears to have crept in some how with the 11 series. The <execution>
header is indirectly including some deprecated Intel header from the TBB
library.

[Bug libstdc++/101228] #include <execution> triggers Intel TBB warning for tbb/task.h

[kip at thevertigo dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #1 from Kip Warner <kip at thevertigo dot com> ---
Suggestion: Maybe a unit test that includes all the standard STL headers, does
nothing with them, and that's expected to emit no warnings would mitigate
problems like this occurring in the future.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|#include <execution>        |tbb/task.h is Deprecated in
                   |triggers Intel TBB warning  |newer TBB.
                   |for tbb/task.h              |
   Last reconfirmed|                            |2021-06-27
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
tbb/task.h just got deprecated last year and after parallel_backend_tbb.h was
added to GCC.


https://github.com/oneapi-src/oneTBB/issues/243

It depends on the version of TBB that is installed really.  Looks like Ubuntu
11.1.0 is using a much newer version.  You really should file a bug with Ubuntu
about this issue since you are getting both GCC and TBB from them.  We won't
fixing Ubuntu's compiler even with this bug filed by the way.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[kip at thevertigo dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #3 from Kip Warner <kip at thevertigo dot com> ---
Thanks Andrew. I've opened an issue downstream:

https://bugs.launchpad.net/gcc/+bug/1933775

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
<execution> requires TBB, as documented:
https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017

"Note 3: The Parallel Algorithms have an external dependency on Intel TBB 2018
or later. If the <execution> header is included then -ltbb must be used to link
to TBB."

If you use the parallel algos (or just include their headers) then the TBB
headers are included. That's by design, they don't work otherwise. We can't do
anythign about the fact that Intel deprecated their own API shortly after using
contributing the PSTL headers to GCC, which depend on that API.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Matthias Klose <doko at debian dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doko at debian dot org

--- Comment #5 from Matthias Klose <doko at debian dot org> ---
No, the gcc packages don't depend on any tbb package.  Probably tbb needs an
update to a new upstream version in the distro.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
There's no easy solution. Intel contributed the PSTL headers with a dependency
on TBB task.h header, then deprecated that header in a later TBB release. You
need to either use an older TBB, or suppress the warning.

There is a plan to add an OpenMP backend to PSTL, which will remove the TBB
dependency, but it's not ready yet.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[pilarlatiesa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Pilar Latiesa <pilarlatiesa at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pilarlatiesa at gmail dot com

--- Comment #7 from Pilar Latiesa <pilarlatiesa at gmail dot com> ---

This appears to be fixed upstream: https://reviews.llvm.org/D87380

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|MOVED                       |---
             Status|RESOLVED                    |NEW
                 CC|                            |rodgertq at gcc dot gnu.org

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Tom, it looks like that fix landed upstream after our last sync. Should we use
it?

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[rodgertq at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Thomas Rodgers <rodgertq at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rodgertq at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #9 from Thomas Rodgers <rodgertq at gcc dot gnu.org> ---
Yes (I already reviewed it when it arrived upstream). It is probably also safe
to backport to GCC-11 since there's no ABI or ABI stability concerns. I will
have a go at applying *just* this patch (I don't want to commit to trying a
full rebase against upstream at this point).

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[pilarlatiesa at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #10 from Pilar Latiesa <pilarlatiesa at gmail dot com> ---
I believe this was fixed for 11.2

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |11.1.0

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, it was fixed by r11-4187 but the problem is still present on the gcc-10
branch.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[hicham at mouline dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

hicham at mouline dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hicham at mouline dot org

--- Comment #12 from hicham at mouline dot org ---
I see this warning still in g++ (GCC) 12.2.1 20220819 (Red Hat 12.2.1-2)  with
tbb-2020.3-9.fc35.x86_64

In file included from /usr/include/c++/12/pstl/parallel_backend_tbb.h:26,
                 from /usr/include/c++/12/pstl/parallel_backend.h:20,
                 from /usr/include/c++/12/pstl/algorithm_impl.h:22,
                 from /usr/include/c++/12/pstl/glue_execution_defs.h:50,
                 from /usr/include/c++/12/execution:32,
                 from 4.cpp:8:
/usr/include/tbb/task.h:21:139: note: ‘#pragma message: TBB Warning: tbb/task.h
is deprecated. For details, please see Deprecated Features appendix in the TBB
reference manual.’
   21 | #pragma message("TBB Warning: tbb/task.h is deprecated. For details,
please see Deprecated Features appendix in the TBB reference manual.")

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[kerukuro at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

kerukuro <kerukuro at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kerukuro at gmail dot com

--- Comment #13 from kerukuro <kerukuro at gmail dot com> ---
Yes, this issue is not fixed.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #14 from Jonathan Wakely <redi at gcc dot gnu.org> ---
N.B. you can use -DTBB_SUPPRESS_DEPRECATED_MESSAGES=1 to suppress the warning.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #15 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #11)
> Yes, it was fixed by r11-4187 but the problem is still present on the gcc-10
> branch.

I think that commit simply makes it possible to use oneTBB, which doesn't give
a warning. But if you use TBB 2020.3 or older, then you still get a warning.

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #16 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Maybe we could do something like this:

--- a/libstdc++-v3/include/pstl/parallel_backend_tbb.h
+++ b/libstdc++-v3/include/pstl/parallel_backend_tbb.h
@@ -15,6 +15,11 @@

 #include "parallel_backend_utils.h"

+#ifndef TBB_SUPPRESS_DEPRECATED_MESSAGES
+# define TBB_SUPPRESS_DEPRECATED_MESSAGES 1
+# define _GLIBCXX_UNDEF_SUPPRESS
+#endif
+
 // Bring in minimal required subset of Intel TBB
 #include <tbb/blocked_range.h>
 #include <tbb/parallel_for.h>
@@ -25,6 +30,11 @@
 #include <tbb/tbb_allocator.h>
 #include <tbb/task.h>

+#ifdef _GLIBCXX_UNDEF_SUPPRESS
+# undef TBB_SUPPRESS_DEPRECATED_MESSAGES
+# undef _GLIBCXX_UNDEF_SUPPRESS
+#endif
+
 #if TBB_INTERFACE_VERSION < 10000
 #    error Intel(R) Threading Building Blocks 2018 is required; older versions
are not supported.
 #endif

[Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228

--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:c608b57f77a47179899666940c3b8b6a2e5435b2

commit r14-9550-gc608b57f77a47179899666940c3b8b6a2e5435b2
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Feb 29 17:13:49 2024 +0000

    libstdc++: Suppress deprecation messages from <tbb/task.h> [PR101228]

    libstdc++-v3/ChangeLog:

            PR libstdc++/101228
            * include/pstl/parallel_backend_tbb.h
(TBB_SUPPRESS_DEPRECATED_MESSAGES):
            Define before including <tbb/task.h> then undef afterwards.