[Bug modula2/101388] New: Unconditional use of __MAX_BAUD

[Bug modula2/101388] New: Unconditional use of __MAX_BAUD

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

            Bug ID: 101388
           Summary: Unconditional use of __MAX_BAUD
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: gaiusmod2 at gmail dot com
  Target Milestone: ---
            Target: *-*-solaris2.11

Building the devel/modula-2 branch on Solaris 11 fails with undefined
references
to __MAX_BAUD in two places:

/vol/gcc/src/git/modula-2/gcc/m2/mc-boot-ch/Gtermios.c: In function
'termios_GetFlag':
/vol/gcc/src/git/modula-2/gcc/m2/mc-boot-ch/Gtermios.c:872:27: error:
'__MAX_BAUD' undeclared (first use in this function)
       *b = ((t->c_cflag & __MAX_BAUD) == __MAX_BAUD);
                           ^~~~~~~~~~

/vol/gcc/src/git/modula-2/gcc/m2/gm2-libs-ch/termios.c: In function
'termios_GetFlag':
/vol/gcc/src/git/modula-2/gcc/m2/gm2-libs-ch/termios.c:877:27: error:
'__MAX_BAUD' undeclared (first use in this function)
  877 |       *b = ((t->c_cflag & __MAX_BAUD) == __MAX_BAUD);
      |                           ^~~~~~~~~~
__MAX_BAUD seems to be Linux/glibc specific, but the current problem is
obviously
cause by a wrong guard which checks for defined(MAX) instead of
defined(__MAX_BAUD).

Correcting this lets the build continue.

[Bug modula2/101388] Unconditional use of __MAX_BAUD

[gaiusmod2 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

--- Comment #1 from Gaius Mulley <gaiusmod2 at gmail dot com> ---
"ro at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> writes:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388
>
>             Bug ID: 101388
>            Summary: Unconditional use of __MAX_BAUD
>            Product: gcc
>            Version: 12.0
>             Status: UNCONFIRMED
>           Severity: normal
>           Priority: P3
>          Component: modula2
>           Assignee: unassigned at gcc dot gnu.org
>           Reporter: ro at gcc dot gnu.org
>                 CC: gaiusmod2 at gmail dot com
>   Target Milestone: ---
>             Target: *-*-solaris2.11
>
> Building the devel/modula-2 branch on Solaris 11 fails with undefined
> references
> to __MAX_BAUD in two places:
>
> /vol/gcc/src/git/modula-2/gcc/m2/mc-boot-ch/Gtermios.c: In function
> 'termios_GetFlag':
> /vol/gcc/src/git/modula-2/gcc/m2/mc-boot-ch/Gtermios.c:872:27: error:
> '__MAX_BAUD' undeclared (first use in this function)
>        *b = ((t->c_cflag & __MAX_BAUD) == __MAX_BAUD);
>                            ^~~~~~~~~~
>
> /vol/gcc/src/git/modula-2/gcc/m2/gm2-libs-ch/termios.c: In function
> 'termios_GetFlag':
> /vol/gcc/src/git/modula-2/gcc/m2/gm2-libs-ch/termios.c:877:27: error:
> '__MAX_BAUD' undeclared (first use in this function)
>   877 |       *b = ((t->c_cflag & __MAX_BAUD) == __MAX_BAUD);
>       |                           ^~~~~~~~~~
> __MAX_BAUD seems to be Linux/glibc specific, but the current problem is
> obviously
> cause by a wrong guard which checks for defined(MAX) instead of
> defined(__MAX_BAUD).
>
> Correcting this lets the build continue.

many thanks for the report - now fixed in the git repro,


regards,
Gaius

[Bug modula2/101388] Unconditional use of __MAX_BAUD

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug modula2/101388] Unconditional use of __MAX_BAUD

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 51458
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51458&action=edit
Missed part of patch

[Bug modula2/101388] Unconditional use of __MAX_BAUD

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2021-09-14
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
When I tried a fresh build on i386-pc-solaris2.11 yesterday, it turned out that
the fix hadn't been complete:

/vol/gcc/src/git/modula-2/gcc/m2/gm2-libs-ch/termios.c: In function
'termios_GetFlag':
/vol/gcc/src/git/modula-2/gcc/m2/gm2-libs-ch/termios.c:877:27: error:
'__MAX_BAUD' undeclared (first use in this function)
  877 |       *b = ((t->c_cflag & __MAX_BAUD) == __MAX_BAUD);
      |                           ^~~~~~~~~~

I'm attaching the patch that allowed me to finish the build.

[Bug modula2/101388] Unconditional use of __MAX_BAUD

[gaiusmod2 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

--- Comment #5 from Gaius Mulley <gaiusmod2 at gmail dot com> ---
Many thanks - I've applied the patch to the git repro.  Fixed now I believe.

[Bug modula2/101388] Unconditional use of __MAX_BAUD

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101388

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Marking as resolved as the patch has been applied.