[Bug modula2/101391] New: Unresolved reference to module getopt

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug modula2/101391] New: Unresolved reference to module getopt
@ 2021-07-09 12:27 ro at gcc dot gnu.org
  2021-08-13 16:19 ` [Bug modula2/101391] " gaiusmod2 at gmail dot com
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: ro at gcc dot gnu.org @ 2021-07-09 12:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

            Bug ID: 101391
           Summary: Unresolved reference to module getopt
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---

Created attachment 51123
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51123&action=edit
Mechanical patch

The next build error from the devel/modula-2 branch occured like this:

/vol/gcc/src/git/modula-2/libgm2/libm2pim/../../gcc/m2/gm2-libs/GetOpt.mod:213:11:
error: the file containing the definition module ‘getopt’ cannot be found
  213 | END GetOpt.
      |           ^
make[5]: *** [Makefile:950: GetOpt.lo] Error 1
make[5]: Leaving directory
'/var/gcc/gcc-12.0.0-20210708/11.4-gm2/i386-pc-solaris2.11/libgm2/libm2pim'

The module has been renamed to cgetopt since.  I'm attaching a patch for
gcc/m2/gm2-libs/GetOpt.mod for correct this.

While the Makefile.am's reflect the new name, the corresponding Makefile.in's
haven't been regenerated.

On top of that, the current files have been generated with automake 1.16.1,
while gcc requires automake 1.15.1 as documented in install.text.  To get
around
this, one first needs to regenerate aclocal.m4 with aclocal 1.15.1 in order to
be able rerun automake.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
@ 2021-08-13 16:19 ` gaiusmod2 at gmail dot com
  2021-08-14  9:42 ` gaiusmod2 at gmail dot com
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: gaiusmod2 at gmail dot com @ 2021-08-13 16:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

Gaius Mulley <gaiusmod2 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaiusmod2 at gmail dot com

--- Comment #1 from Gaius Mulley <gaiusmod2 at gmail dot com> ---
Now fixed in the gcc git repro thanks for the patch.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
  2021-08-13 16:19 ` [Bug modula2/101391] " gaiusmod2 at gmail dot com
@ 2021-08-14  9:42 ` gaiusmod2 at gmail dot com
  2021-09-14 10:02 ` ro at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: gaiusmod2 at gmail dot com @ 2021-08-14  9:42 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

--- Comment #2 from Gaius Mulley <gaiusmod2 at gmail dot com> ---
Thanks for mentioning the automake version discrepancy - which is also fixed in
git using 1.15.1.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
  2021-08-13 16:19 ` [Bug modula2/101391] " gaiusmod2 at gmail dot com
  2021-08-14  9:42 ` gaiusmod2 at gmail dot com
@ 2021-09-14 10:02 ` ro at gcc dot gnu.org
  2021-09-14 10:03 ` ro at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ro at gcc dot gnu.org @ 2021-09-14 10:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-09-14
     Ever confirmed|0                           |1

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> ---
(In reply to Gaius Mulley from comment #1)
> Now fixed in the gcc git repro thanks for the patch.

Unfortunately, the patch wasn't enough: while I now could finish a build on 
x86_64-pc-linux-gnu, every m2 link test failed like this:

/vol/gcc/bin/gld-2.35:
/var/scratch/gcc/gcc-12.0.0-20210913/5.4.0-gm2/x86_64-pc-linux-gnu/./libgm2/libm2pim/.libs/libm2pim.so:
undefined reference to `cgetopt_optopt'
/vol/gcc/bin/gld-2.35:
/var/scratch/gcc/gcc-12.0.0-20210913/5.4.0-gm2/x86_64-pc-linux-gnu/./libgm2/libm2pim/.libs/libm2pim.so:
undefined reference to `cgetopt_opterr'
/vol/gcc/bin/gld-2.35:
/var/scratch/gcc/gcc-12.0.0-20210913/5.4.0-gm2/x86_64-pc-linux-gnu/./libgm2/libm2pim/.libs/libm2pim.so:
undefined reference to `cgetopt_getopt_long_only'
/vol/gcc/bin/gld-2.35:
/var/scratch/gcc/gcc-12.0.0-20210913/5.4.0-gm2/x86_64-pc-linux-gnu/./libgm2/libm2pim/.libs/libm2pim.so:
undefined reference to `cgetopt_getopt'
/vol/gcc/bin/gld-2.35:
/var/scratch/gcc/gcc-12.0.0-20210913/5.4.0-gm2/x86_64-pc-linux-gnu/./libgm2/libm2pim/.libs/libm2pim.so:
undefined reference to `cgetopt_getopt_long'
/vol/gcc/bin/gld-2.35:
/var/scratch/gcc/gcc-12.0.0-20210913/5.4.0-gm2/x86_64-pc-linux-gnu/./libgm2/libm2pim/.libs/libm2pim.so:
undefined reference to `cgetopt_optarg'
collect2: error: ld returned 1 exit status
compiler exited with status 1
FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation,  -g
UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution,  -g 
(link failed)

There are undefined references to

  cgetopt_getopt
  cgetopt_getopt_long
  cgetopt_getopt_long_only
  cgetopt_optarg
  cgetopt_opterr
  cgetopt_optopt

and libm2pim.so has those instead, defined in cgetopt.o:

0000000000020590 T getopt_getopt
00000000000205f0 T getopt_getopt_long
0000000000020650 T getopt_getopt_long_only
00000000000335c8 B getopt_optarg
00000000000335bc B getopt_opterr
00000000000335c0 B getopt_optind
00000000000335b8 B getopt_optopt

The attached new patch fixes this, too, and gives way more reasonable test
results:

                === gm2 Summary ===

# of expected passes            23067
# of unexpected failures        99
# of unresolved testcases       78

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2021-09-14 10:02 ` ro at gcc dot gnu.org
@ 2021-09-14 10:03 ` ro at gcc dot gnu.org
  2021-10-25 11:36 ` ro at gcc dot gnu.org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ro at gcc dot gnu.org @ 2021-09-14 10:03 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 51457
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51457&action=edit
Additonal patch providing cgetopt_*

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2021-09-14 10:03 ` ro at gcc dot gnu.org
@ 2021-10-25 11:36 ` ro at gcc dot gnu.org
  2022-01-20 17:33 ` gaius at gcc dot gnu.org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ro at gcc dot gnu.org @ 2021-10-25 11:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> ---
It would be good if the additional patch could be applied, otherwise 2000+
tests
fail to link.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2021-10-25 11:36 ` ro at gcc dot gnu.org
@ 2022-01-20 17:33 ` gaius at gcc dot gnu.org
  2022-01-20 22:03 ` ro at CeBiTec dot Uni-Bielefeld.DE
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-01-20 17:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

--- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Comment on attachment 51457
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51457
Additonal patch providing cgetopt_*

All done - thanks for the patch and apologies for the delay in applying.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2022-01-20 17:33 ` gaius at gcc dot gnu.org
@ 2022-01-20 22:03 ` ro at CeBiTec dot Uni-Bielefeld.DE
  2022-01-28 16:52 ` gaius at gcc dot gnu.org
  2022-04-23 12:02 ` gaius at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2022-01-20 22:03 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
> Comment on attachment 51457
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51457
> Additonal patch providing cgetopt_*
>
> All done - thanks for the patch and apologies for the delay in applying.

Excellent, thanks a lot.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2022-01-20 22:03 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2022-01-28 16:52 ` gaius at gcc dot gnu.org
  2022-04-23 12:02 ` gaius at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-01-28 16:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

--- Comment #8 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Is it okay to close this PR as I've git committed some regression tests to
check that cgetopt and (other modules) are present and visible to the linker?

https://gcc.gnu.org/pipermail/gcc-cvs/2022-January/359926.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug modula2/101391] Unresolved reference to module getopt
  2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2022-01-28 16:52 ` gaius at gcc dot gnu.org
@ 2022-04-23 12:02 ` gaius at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-04-23 12:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101391

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Gaius Mulley <gaius at gcc dot gnu.org> ---
I'm closing this PR as I believe it to be fixed and there are additional
regression tests to specifically catch the original link problem.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-04-23 12:02 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 12:27 [Bug modula2/101391] New: Unresolved reference to module getopt ro at gcc dot gnu.org
2021-08-13 16:19 ` [Bug modula2/101391] " gaiusmod2 at gmail dot com
2021-08-14  9:42 ` gaiusmod2 at gmail dot com
2021-09-14 10:02 ` ro at gcc dot gnu.org
2021-09-14 10:03 ` ro at gcc dot gnu.org
2021-10-25 11:36 ` ro at gcc dot gnu.org
2022-01-20 17:33 ` gaius at gcc dot gnu.org
2022-01-20 22:03 ` ro at CeBiTec dot Uni-Bielefeld.DE
2022-01-28 16:52 ` gaius at gcc dot gnu.org
2022-04-23 12:02 ` gaius at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).