[Bug driver/101447] New: Remove legacy external declarations in toplev.h

[Bug driver/101447] New: Remove legacy external declarations in toplev.h

[ashimida at linux dot alibaba.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101447

            Bug ID: 101447
           Summary: Remove legacy external declarations in toplev.h
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: driver
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ashimida at linux dot alibaba.com
  Target Milestone: ---

External declarations in ./gcc/toplev.h is no longer used in newest version of
gcc and should be cleaned up to avoid misunderstandings :

+extern unsigned int min_align_loops_log;
+extern unsigned int min_align_jumps_log;
+extern unsigned int min_align_labels_log;
+extern unsigned int min_align_functions_log;

The history FYI:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e6de53356769e13178975c18b4ce019a800ea946;hp=118f2d8bc3e6804996ca2953b86454ec950054bf

[Bug driver/101447] Remove legacy external declarations in toplev.h

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101447

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-07-14
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, they are declared and never defined.

If you submit a patch to gcc-patches I imagine it will be approved easily.

[Bug driver/101447] Remove legacy external declarations in toplev.h

[ashimida at linux dot alibaba.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101447

--- Comment #2 from ashimida <ashimida at linux dot alibaba.com> ---
(In reply to Jonathan Wakely from comment #1)
> Yes, they are declared and never defined.
> 
> If you submit a patch to gcc-patches I imagine it will be approved easily.

Thanks,I will submit this patch later.

[Bug driver/101447] Remove legacy external declarations in toplev.h

[ashimida at linux dot alibaba.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101447

--- Comment #3 from ashimida <ashimida at linux dot alibaba.com> ---
Submitted at https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575252.html

[Bug driver/101447] Remove legacy external declarations in toplev.h

[ashimida at linux dot alibaba.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101447

ashimida <ashimida at linux dot alibaba.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from ashimida <ashimida at linux dot alibaba.com> ---
Submitted at https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575252.html

[Bug driver/101447] Remove legacy external declarations in toplev.h

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101447

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jeff Law <law@gcc.gnu.org>:

https://gcc.gnu.org/g:bf6d414415e14e13be16abf23375160733567d20

commit r12-2512-gbf6d414415e14e13be16abf23375160733567d20
Author: Ashimida <ashimida@linux.alibaba.com>
Date:   Mon Jul 26 10:38:50 2021 -0400

    Remove legacy external declarations in toplev.h [PR101447]

    gcc/
            PR driver/101447
            * toplev.h (min_align_loops_log): Remove declaration.
            (min_align_jumps_log, min_align_labels_log): Likewise.
            (min_align_functions_log): Likewise.