* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
@ 2021-07-17 22:30 ` ams at gcc dot gnu.org
2021-07-19 6:30 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ams at gcc dot gnu.org @ 2021-07-17 22:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
Andrew Stubbs <ams at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2021-07-17
--- Comment #1 from Andrew Stubbs <ams at gcc dot gnu.org> ---
A new warning has been added that falsely identifies any access to a hardcoded
constant address as bogus. This has affected a few targets, including GCN
libgomp. See pr101374.
There's some discussion what to do about it. E.g.
https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574880.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
2021-07-17 22:30 ` [Bug target/101484] " ams at gcc dot gnu.org
@ 2021-07-19 6:30 ` rguenth at gcc dot gnu.org
2021-07-19 8:27 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-07-19 6:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |msebor at gcc dot gnu.org
Target Milestone|--- |12.0
Priority|P3 |P1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
2021-07-17 22:30 ` [Bug target/101484] " ams at gcc dot gnu.org
2021-07-19 6:30 ` rguenth at gcc dot gnu.org
@ 2021-07-19 8:27 ` cvs-commit at gcc dot gnu.org
2021-07-20 7:20 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-07-19 8:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Schwinge <tschwinge@gcc.gnu.org>:
https://gcc.gnu.org/g:9f2bc5077debef2b046b6c10d38591ac324ad8b5
commit r12-2392-g9f2bc5077debef2b046b6c10d38591ac324ad8b5
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Fri Jul 16 19:12:02 2021 +0200
[gcn] Work-around libgomp 'error: array subscript 0 is outside array bounds
of â__lds struct gomp_thread * __lds[0]â [-Werror=array-bounds]' [PR101484]
... seen as of commit a110855667782dac7b674d3e328b253b3b3c919b "Correct
handling of variable offset minus constant in -Warray-bounds [PR100137]".
Awaiting a different solution, of course.
libgomp/
PR target/101484
* config/gcn/team.c: Apply '-Werror=array-bounds' work-around.
* libgomp.h [__AMDGCN__]: Likewise.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
` (2 preceding siblings ...)
2021-07-19 8:27 ` cvs-commit at gcc dot gnu.org
@ 2021-07-20 7:20 ` cvs-commit at gcc dot gnu.org
2022-01-26 13:46 ` marxin at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-07-20 7:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Schwinge <tschwinge@gcc.gnu.org>:
https://gcc.gnu.org/g:8168338684fc2bed576bb09202c63b3e9e678d92
commit r12-2408-g8168338684fc2bed576bb09202c63b3e9e678d92
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Mon Jul 19 23:11:38 2021 +0200
[gcn] Work-around libgomp 'error: array subscript 0 is outside array bounds
of â__lds struct gomp_thread * __lds[0]â [-Werror=array-bounds]' some more
[PR101484]
With yesterday's commit 9f2bc5077debef2b046b6c10d38591ac324ad8b5 "[gcn]
Work-around libgomp 'error: array subscript 0 is outside array bounds of
â__lds struct gomp_thread * __lds[0]â [-Werror=array-bounds]'
[PR101484]",
I did defuse the "unexpected" '-Werror=array-bounds' diagnostics that we
see
as of commit a110855667782dac7b674d3e328b253b3b3c919b "Correct handling of
variable offset minus constant in -Warray-bounds [PR100137]". However,
these
'#pragma GCC diagnostic [...]' directives cause some code generation
changes
(that seems unexpected, problematic!), which results in a lot (ten
thousands)
of 'GCN team arena exhausted' run-time diagnostics, also leading to a few
FAILs:
PASS: libgomp.c/../libgomp.c-c++-common/for-11.c (test for excess
errors)
[-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/for-11.c execution
test
PASS: libgomp.c/../libgomp.c-c++-common/for-12.c (test for excess
errors)
[-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/for-12.c execution
test
PASS: libgomp.c/../libgomp.c-c++-common/for-3.c (test for excess
errors)
[-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/for-3.c execution
test
PASS: libgomp.c/../libgomp.c-c++-common/for-5.c (test for excess
errors)
[-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/for-5.c execution
test
PASS: libgomp.c/../libgomp.c-c++-common/for-6.c (test for excess
errors)
[-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/for-6.c execution
test
PASS: libgomp.c/../libgomp.c-c++-common/for-9.c (test for excess
errors)
[-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/for-9.c execution
test
Same for 'libgomp.c++'.
It remains to be analyzed how '#pragma GCC diagnostic [...]' directives can
cause code generation changes; for now I'm working around the "unexpected"
'-Werror=array-bounds' diagnostics differently.
Overall, still awaiting a different solution, of course.
libgomp/
PR target/101484
* configure.tgt [amdgcn*-*-*] (XCFLAGS): Add
'-Wno-error=array-bounds'.
* config/gcn/team.c: Remove '-Werror=array-bounds' work-around.
* libgomp.h [__AMDGCN__]: Likewise.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
` (3 preceding siblings ...)
2021-07-20 7:20 ` cvs-commit at gcc dot gnu.org
@ 2022-01-26 13:46 ` marxin at gcc dot gnu.org
2022-01-26 13:57 ` doko at debian dot org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-01-26 13:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Can we close this as fixed?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
` (4 preceding siblings ...)
2022-01-26 13:46 ` marxin at gcc dot gnu.org
@ 2022-01-26 13:57 ` doko at debian dot org
2022-03-21 15:54 ` tschwinge at gcc dot gnu.org
2022-03-21 16:32 ` jakub at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: doko at debian dot org @ 2022-01-26 13:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
Matthias Klose <doko at debian dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #5 from Matthias Klose <doko at debian dot org> ---
yes, that builds now
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
` (5 preceding siblings ...)
2022-01-26 13:57 ` doko at debian dot org
@ 2022-03-21 15:54 ` tschwinge at gcc dot gnu.org
2022-03-21 16:32 ` jakub at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2022-03-21 15:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org,
| |tschwinge at gcc dot gnu.org
--- Comment #6 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #4)
> Can we close this as fixed?
(In reply to Matthias Klose from comment #5)
> yes, that builds now
..., but "fixed" only if you qualify as a proper fix the
'-Wno-error=array-bounds' that I added... .-\
For the record: I thought it was worth a quick try, but Jakub's recent commit
r12-7713-g32ca611c42658948f1b8883994796f35e8b4e74d "Allow (void *) 0xdeadbeef
accesses without warnings [PR99578]" does not resolve this issue here.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug target/101484] [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload)
2021-07-17 9:58 [Bug target/101484] New: [12 Regression] trunk 20210717 ftbfs for amdgcn-amdhsa (gcn offload) doko at debian dot org
` (6 preceding siblings ...)
2022-03-21 15:54 ` tschwinge at gcc dot gnu.org
@ 2022-03-21 16:32 ` jakub at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-03-21 16:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101484
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
If it is some special memory address space, would be nice if
targetm.addr_space.zero_address_valid returns true about it.
And in that case, if such a change doesn't fix it, pointer-query.cc or whatever
should take it into account.
^ permalink raw reply [flat|nested] 9+ messages in thread