public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101511] [12 Regression] ice in query_relation, at value-relation.cc:879
Date: Mon, 19 Jul 2021 20:59:40 +0000	[thread overview]
Message-ID: <bug-101511-4-ZyImF4BJsQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101511-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101511

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org

--- Comment #3 from Andrew Macleod <amacleod at redhat dot com> ---
The new relation code is dominance based,  in the interest of efficiency, it
can currently miss the odd equivalence if things are processed in a
non-dominance order.

Its not incorrect, it just may lead to a missed opportunity.

This testcase triggers an assert which checks for this situation.  There are
numerous UNDEFINED values, and we end up register an equivalences:

 Registering value_relation (Error_18 == _4) (bb4) at Error_18 = _4 + Error_13;
 Registering value_relation (Error_13 == _4) (bb2) at Error_13 = _4 + Error_9;

Not we register the bb4 equivalence first,  and then alter register the one in
bb2.

As a result, we don't currently update post dominated blocks, so we dont
combine these into Error_18, Error_13 and _4 in bb4.
When we later check for an equivalence between we detect this anomaly.
There is nothing incorrect in allowing it, and we'll do so for now.  
Eventually, when its flushed out better, we'll change this back to an assert.

  parent reply	other threads:[~2021-07-19 20:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 13:54 [Bug c++/101511] New: " dcb314 at hotmail dot com
2021-07-19 14:03 ` [Bug c++/101511] " dcb314 at hotmail dot com
2021-07-19 14:23 ` [Bug tree-optimization/101511] [12 Regression] " rguenth at gcc dot gnu.org
2021-07-19 15:25 ` dcb314 at hotmail dot com
2021-07-19 20:59 ` amacleod at redhat dot com [this message]
2021-07-22 12:53 ` cvs-commit at gcc dot gnu.org
2021-07-22 13:05 ` marxin at gcc dot gnu.org
2021-07-22 13:06 ` amacleod at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101511-4-ZyImF4BJsQ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).