public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong
@ 2021-07-20 13:05 hewillk at gmail dot com
2021-07-20 23:10 ` [Bug libstdc++/101527] " hewillk at gmail dot com
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: hewillk at gmail dot com @ 2021-07-20 13:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
Bug ID: 101527
Summary: The implementation of std::common_iterator::operator==
seems to be wrong
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: hewillk at gmail dot com
Target Milestone: ---
Libstdc++'s implementation of common_iterator is similar to MSVC-STL, it
defines operator== inside the class and declares template common_iterator class
as a friend.
But according to the description of [class.friend#10]: "Friendship is neither
inherited nor transitive." this will cause the following valid codes to be
rejected:
std::common_iterator<int*, std::unreachable_sentinel_t> it1;
std::common_iterator<const int*, std::unreachable_sentinel_t> it2;
it1 == it2;
https://godbolt.org/z/15ao981Wb
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator::operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
@ 2021-07-20 23:10 ` hewillk at gmail dot com
2021-07-21 9:53 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: hewillk at gmail dot com @ 2021-07-20 23:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
--- Comment #1 from 康桓瑋 <hewillk at gmail dot com> ---
(In reply to 康桓瑋 from comment #0)
> But according to the description of [class.friend#10]: "Friendship is
> neither inherited nor transitive." this will cause the following valid codes
> to be rejected:
This is the implementation divergence of CWG1699.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator::operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
2021-07-20 23:10 ` [Bug libstdc++/101527] " hewillk at gmail dot com
@ 2021-07-21 9:53 ` redi at gcc dot gnu.org
2021-07-21 15:17 ` hewillk at gmail dot com
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2021-07-21 9:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I find it surprising, but the CWG consensus seems to be that a friend defined
inline in the class body is "a member declaration of the befriended class".
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator::operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
2021-07-20 23:10 ` [Bug libstdc++/101527] " hewillk at gmail dot com
2021-07-21 9:53 ` redi at gcc dot gnu.org
@ 2021-07-21 15:17 ` hewillk at gmail dot com
2022-04-10 18:00 ` [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== " hewillk at gmail dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: hewillk at gmail dot com @ 2021-07-21 15:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
--- Comment #3 from 康桓瑋 <hewillk at gmail dot com> ---
(In reply to Jonathan Wakely from comment #2)
> I find it surprising, but the CWG consensus seems to be that a friend
> defined inline in the class body is "a member declaration of the befriended
> class".
Hey Jonathan, I just found out that std::counted_iterator also has the same
friend access issue.
#include <iterator>
int main() {
std::counted_iterator<int*> it1;
std::counted_iterator<const int*> it2;
return it1 == it2;
}
https://godbolt.org/z/jGT5jhbWz
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
` (2 preceding siblings ...)
2021-07-21 15:17 ` hewillk at gmail dot com
@ 2022-04-10 18:00 ` hewillk at gmail dot com
2022-04-14 19:20 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: hewillk at gmail dot com @ 2022-04-10 18:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
--- Comment #4 from 康桓瑋 <hewillk at gmail dot com> ---
MSVC has fixed this issue through
https://github.com/microsoft/STL/pull/2066/commits.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
` (3 preceding siblings ...)
2022-04-10 18:00 ` [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== " hewillk at gmail dot com
@ 2022-04-14 19:20 ` redi at gcc dot gnu.org
2022-05-06 8:30 ` jakub at gcc dot gnu.org
2023-05-08 12:22 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2022-04-14 19:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Last reconfirmed| |2022-04-14
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
` (4 preceding siblings ...)
2022-04-14 19:20 ` redi at gcc dot gnu.org
@ 2022-05-06 8:30 ` jakub at gcc dot gnu.org
2023-05-08 12:22 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-05-06 8:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|12.0 |12.2
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== seems to be wrong
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
` (5 preceding siblings ...)
2022-05-06 8:30 ` jakub at gcc dot gnu.org
@ 2023-05-08 12:22 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-05-08 12:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101527
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|12.3 |12.4
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 12.3 is being released, retargeting bugs to GCC 12.4.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-05-08 12:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 13:05 [Bug libstdc++/101527] New: The implementation of std::common_iterator::operator== seems to be wrong hewillk at gmail dot com
2021-07-20 23:10 ` [Bug libstdc++/101527] " hewillk at gmail dot com
2021-07-21 9:53 ` redi at gcc dot gnu.org
2021-07-21 15:17 ` hewillk at gmail dot com
2022-04-10 18:00 ` [Bug libstdc++/101527] The implementation of std::common_iterator and std::counted_iterator's operator== " hewillk at gmail dot com
2022-04-14 19:20 ` redi at gcc dot gnu.org
2022-05-06 8:30 ` jakub at gcc dot gnu.org
2023-05-08 12:22 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).