public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hewillk at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/101739] New: Some function parameters in <ranges> missing uglify
Date: Tue, 03 Aug 2021 06:32:35 +0000	[thread overview]
Message-ID: <bug-101739-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101739

            Bug ID: 101739
           Summary: Some function parameters in <ranges> missing uglify
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hewillk at gmail dot com
  Target Milestone: ---

Hey, Patrick, I found that you uglify some function parameters in yesterday’s
r12-2676 to prevent user-defined macros from polluting names.

There are also some function parameters missing uglifying in <ranges>, it will
be more friendly to users if they are underlined:



--- include/std/ranges
+++ include/std/ranges
@@ -1994,8 +1994,8 @@ namespace views::__adaptor
       take_view() requires default_initializable<_Vp> = default;

       constexpr
-      take_view(_Vp base, range_difference_t<_Vp> __count)
-       : _M_count(std::move(__count)), _M_base(std::move(base))
+      take_view(_Vp __base, range_difference_t<_Vp> __count)
+       : _M_count(std::move(__count)), _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -2180,8 +2180,8 @@ namespace views::__adaptor
        = default;

       constexpr
-      take_while_view(_Vp base, _Pred __pred)
-       : _M_pred(std::move(__pred)), _M_base(std::move(base))
+      take_while_view(_Vp __base, _Pred __pred)
+       : _M_pred(std::move(__pred)), _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -3782,8 +3782,8 @@ namespace views::__adaptor
       elements_view() requires default_initializable<_Vp> = default;

       constexpr explicit
-      elements_view(_Vp base)
-       : _M_base(std::move(base))
+      elements_view(_Vp __base)
+       : _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -3903,14 +3903,14 @@ namespace views::__adaptor
          _Iterator() requires default_initializable<iterator_t<_Base>> =
default;

          constexpr explicit
-         _Iterator(iterator_t<_Base> current)
-           : _M_current(std::move(current))
+         _Iterator(iterator_t<_Base> __current)
+           : _M_current(std::move(__current))
          { }

          constexpr
-         _Iterator(_Iterator<!_Const> i)
+         _Iterator(_Iterator<!_Const> __i)
            requires _Const && convertible_to<iterator_t<_Vp>,
iterator_t<_Base>>
-           : _M_current(std::move(i._M_current))
+           : _M_current(std::move(__i._M_current))
          { }

          constexpr const iterator_t<_Base>&



Thank you again for your great contribution to <ranges>. :)

             reply	other threads:[~2021-08-03  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  6:32 hewillk at gmail dot com [this message]
2021-08-31 17:05 ` [Bug libstdc++/101739] " redi at gcc dot gnu.org
2021-08-31 17:20 ` hewillk at gmail dot com
2021-08-31 18:24 ` redi at gcc dot gnu.org
2021-09-01 11:52 ` hewillk at gmail dot com
2021-09-01 12:32 ` redi at gcc dot gnu.org
2023-04-12 16:17 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101739-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).