public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
@ 2021-08-06 20:11 pinskia at gcc dot gnu.org
  2021-08-06 21:50 ` [Bug tree-optimization/101805] " pinskia at gcc dot gnu.org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-06 20:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

            Bug ID: 101805
           Summary: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> ->
                    a & b
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Take:
int maxbool(bool ab, bool bb)
{
  int a = ab;
  int b = bb;
  int c;
  c = (a > b)?a : b;
  return c;
}
int minbool(bool ab, bool bb)
{
  int a = ab;
  int b = bb;
  int c;
  c = (a < b)?a : b;
  return c;
}
---- CUT ----
These two should be optimized to just:
int maxbool_or(bool ab, bool bb)
{
  int c = ab | bb;
  return c;
}
int minbool_and(bool ab, bool bb)
{
  int c = ab & bb;
  return c;
}
------ CUT----

GCC, ICC, clang nor MSVC do this optimization.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
@ 2021-08-06 21:50 ` pinskia at gcc dot gnu.org
  2021-08-14  0:21 ` pinskia at gcc dot gnu.org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-06 21:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
   Last reconfirmed|                            |2021-08-06
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Mine.


#if GIMPLE
(match gimple_truth SSA_NAME@0
 (if (get_nonzero_bits (@0) == 1)))

(simplify
 (min gimple_truth@0 gimple_truth@1)
 (bit_and @0 @1))

(simplify
 (max gimple_truth@0 gimple_truth@1)
 (bit_ior @0 @1))
#endif

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
  2021-08-06 21:50 ` [Bug tree-optimization/101805] " pinskia at gcc dot gnu.org
@ 2021-08-14  0:21 ` pinskia at gcc dot gnu.org
  2022-02-21  3:26 ` pinskia at gcc dot gnu.org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-14  0:21 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2021-August/
                   |                            |577394.html
           Keywords|                            |patch

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch submitted here:
https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577394.html

Note it depends on
https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577393.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
  2021-08-06 21:50 ` [Bug tree-optimization/101805] " pinskia at gcc dot gnu.org
  2021-08-14  0:21 ` pinskia at gcc dot gnu.org
@ 2022-02-21  3:26 ` pinskia at gcc dot gnu.org
  2022-11-27  7:04 ` pinskia at gcc dot gnu.org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-02-21  3:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2022-02-21  3:26 ` pinskia at gcc dot gnu.org
@ 2022-11-27  7:04 ` pinskia at gcc dot gnu.org
  2023-05-15 21:51 ` pinskia at gcc dot gnu.org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-27  7:04 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note improvements to evrp does change the IR for -O2 for the C++ front-end.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2022-11-27  7:04 ` pinskia at gcc dot gnu.org
@ 2023-05-15 21:51 ` pinskia at gcc dot gnu.org
  2023-05-16  1:38 ` pinskia at gcc dot gnu.org
  2023-05-16  3:53 ` pinskia at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-05-15 21:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |
                URL|https://gcc.gnu.org/piperma |
                   |il/gcc-patches/2021-August/ |
                   |577394.html                 |

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
About to submit an updated version of this patch.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2023-05-15 21:51 ` pinskia at gcc dot gnu.org
@ 2023-05-16  1:38 ` pinskia at gcc dot gnu.org
  2023-05-16  3:53 ` pinskia at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-05-16  1:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2023-May/618
                   |                            |645.html

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Updated patch:
https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618645.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug tree-optimization/101805] Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b
  2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2023-05-16  1:38 ` pinskia at gcc dot gnu.org
@ 2023-05-16  3:53 ` pinskia at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-05-16  3:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101805

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed by r14-868-gb06cfb62229f17eca59fa4aabf853d7e17e2327b (I typed the wrong
bug # in the commit message).

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-05-16  3:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 20:11 [Bug tree-optimization/101805] New: Max<bool0,bool1> -> bool0 | bool1 Min<bool0, bool1> -> a & b pinskia at gcc dot gnu.org
2021-08-06 21:50 ` [Bug tree-optimization/101805] " pinskia at gcc dot gnu.org
2021-08-14  0:21 ` pinskia at gcc dot gnu.org
2022-02-21  3:26 ` pinskia at gcc dot gnu.org
2022-11-27  7:04 ` pinskia at gcc dot gnu.org
2023-05-15 21:51 ` pinskia at gcc dot gnu.org
2023-05-16  1:38 ` pinskia at gcc dot gnu.org
2023-05-16  3:53 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).