public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
@ 2021-08-16 12:42 jamborm at gcc dot gnu.org
2021-08-16 13:24 ` [Bug target/101935] [12 Regression] " rguenth at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2021-08-16 12:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
Bug ID: 101935
Summary: 538.imagick_r LTO -Ofast regression on Zen2 and
Kabylake caused by r12-2666-g29f0e955c97
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: jamborm at gcc dot gnu.org
CC: hjl at gcc dot gnu.org
Blocks: 26163
Target Milestone: ---
Host: x86_64-linux
Target: x86_64-linux
When compiled with -flto -Ofast -march=native, the benchmark
538.imagick_r is about 28% slower on AMD zen2 machines (see
https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=287.507.0 )
and about 18% slower on Intel Kabylake (see
https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=11.507.0 )
I have independently reproduced the regression on a zen2-based desktop
and bisected it down to commit r12-2666-g29f0e955c97 (x86: Update
piecewise move and store).
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26163
[Bug 26163] [meta-bug] missed optimization in SPEC (2k17, 2k and 2k6 and 95)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/101935] [12 Regression] 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
@ 2021-08-16 13:24 ` rguenth at gcc dot gnu.org
2021-08-20 8:14 ` crazylht at gmail dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-08-16 13:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |missed-optimization
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/101935] [12 Regression] 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
2021-08-16 13:24 ` [Bug target/101935] [12 Regression] " rguenth at gcc dot gnu.org
@ 2021-08-20 8:14 ` crazylht at gmail dot com
2021-08-20 8:16 ` marxin at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: crazylht at gmail dot com @ 2021-08-20 8:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
We can reproduce it on our local znver2 and skylake client.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/101935] [12 Regression] 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
2021-08-16 13:24 ` [Bug target/101935] [12 Regression] " rguenth at gcc dot gnu.org
2021-08-20 8:14 ` crazylht at gmail dot com
@ 2021-08-20 8:16 ` marxin at gcc dot gnu.org
2021-08-26 12:46 ` hjl.tools at gmail dot com
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-08-20 8:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2021-08-20
Status|UNCONFIRMED |NEW
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/101935] [12 Regression] 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
` (2 preceding siblings ...)
2021-08-20 8:16 ` marxin at gcc dot gnu.org
@ 2021-08-26 12:46 ` hjl.tools at gmail dot com
2021-09-13 11:56 ` cvs-commit at gcc dot gnu.org
2021-09-15 15:57 ` marxin at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2021-08-26 12:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |hjl.tools at gmail dot com
--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 51359
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51359&action=edit
A patch
We are testing this.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/101935] [12 Regression] 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
` (3 preceding siblings ...)
2021-08-26 12:46 ` hjl.tools at gmail dot com
@ 2021-09-13 11:56 ` cvs-commit at gcc dot gnu.org
2021-09-15 15:57 ` marxin at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-13 11:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:
https://gcc.gnu.org/g:5b01bfeb8703c264ad402b77741f06f41d7fceac
commit r12-3485-g5b01bfeb8703c264ad402b77741f06f41d7fceac
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Thu Aug 26 05:31:50 2021 -0700
x86: Add TARGET_AVX256_[MOVE|STORE]_BY_PIECES
1. Add TARGET_AVX256_MOVE_BY_PIECES to perform move by-pieces operation
with 256-bit AVX instructions.
2. Add TARGET_AVX256_STORE_BY_PIECES to perform move and store by-pieces
operations with 256-bit AVX instructions.
They are enabled only for Intel Alder Lake and Intel processors with
AVX512.
gcc/
PR target/101935
* config/i386/i386.h (TARGET_AVX256_MOVE_BY_PIECES): New.
(TARGET_AVX256_STORE_BY_PIECES): Likewise.
(MOVE_MAX): Check TARGET_AVX256_MOVE_BY_PIECES and
TARGET_AVX256_STORE_BY_PIECES instead of
TARGET_AVX256_SPLIT_UNALIGNED_LOAD and
TARGET_AVX256_SPLIT_UNALIGNED_STORE.
(STORE_MAX_PIECES): Check TARGET_AVX256_STORE_BY_PIECES instead
of TARGET_AVX256_SPLIT_UNALIGNED_STORE.
* config/i386/x86-tune.def (X86_TUNE_AVX256_MOVE_BY_PIECES): New.
(X86_TUNE_AVX256_STORE_BY_PIECES): Likewise.
gcc/testsuite/
PR target/101935
* g++.target/i386/pr80566-1.C: Add
-mtune-ctrl=avx256_store_by_pieces.
* gcc.target/i386/pr100865-4a.c: Likewise.
* gcc.target/i386/pr100865-10a.c: Likewise.
* gcc.target/i386/pr90773-20.c: Likewise.
* gcc.target/i386/pr90773-21.c: Likewise.
* gcc.target/i386/pr90773-22.c: Likewise.
* gcc.target/i386/pr90773-23.c: Likewise.
* g++.target/i386/pr80566-2.C: Add
-mtune-ctrl=avx256_move_by_pieces.
* gcc.target/i386/eh_return-1.c: Likewise.
* gcc.target/i386/pr90773-26.c: Likewise.
* gcc.target/i386/pieces-memcpy-12.c: Replace -mtune=haswell
with -mtune-ctrl=avx256_move_by_pieces.
* gcc.target/i386/pieces-memcpy-15.c: Likewise.
* gcc.target/i386/pieces-memset-2.c: Replace -mtune=haswell
with -mtune-ctrl=avx256_store_by_pieces.
* gcc.target/i386/pieces-memset-5.c: Likewise.
* gcc.target/i386/pieces-memset-11.c: Likewise.
* gcc.target/i386/pieces-memset-14.c: Likewise.
* gcc.target/i386/pieces-memset-20.c: Likewise.
* gcc.target/i386/pieces-memset-23.c: Likewise.
* gcc.target/i386/pieces-memset-29.c: Likewise.
* gcc.target/i386/pieces-memset-30.c: Likewise.
* gcc.target/i386/pieces-memset-33.c: Likewise.
* gcc.target/i386/pieces-memset-34.c: Likewise.
* gcc.target/i386/pieces-memset-44.c: Likewise.
* gcc.target/i386/pieces-memset-37.c: Replace -mtune=generic
with -mtune-ctrl=avx256_store_by_pieces.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug target/101935] [12 Regression] 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
` (4 preceding siblings ...)
2021-09-13 11:56 ` cvs-commit at gcc dot gnu.org
@ 2021-09-15 15:57 ` marxin at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-09-15 15:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101935
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Martin Jambor from comment #0)
> When compiled with -flto -Ofast -march=native, the benchmark
> 538.imagick_r is about 28% slower on AMD zen2 machines (see
> https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=287.507.0 )
> and about 18% slower on Intel Kabylake (see
> https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=11.507.0 )
Both testers are back regarding the speed. Thus I'm closing this issue..
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-15 15:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 12:42 [Bug target/101935] New: 538.imagick_r LTO -Ofast regression on Zen2 and Kabylake caused by r12-2666-g29f0e955c97 jamborm at gcc dot gnu.org
2021-08-16 13:24 ` [Bug target/101935] [12 Regression] " rguenth at gcc dot gnu.org
2021-08-20 8:14 ` crazylht at gmail dot com
2021-08-20 8:16 ` marxin at gcc dot gnu.org
2021-08-26 12:46 ` hjl.tools at gmail dot com
2021-09-13 11:56 ` cvs-commit at gcc dot gnu.org
2021-09-15 15:57 ` marxin at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).