[Bug target/102035] New: arm/m-profile/cmse add mitigation for CVE-2021-35465

[Bug target/102035] New: arm/m-profile/cmse add mitigation for CVE-2021-35465

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

            Bug ID: 102035
           Summary: arm/m-profile/cmse add mitigation for CVE-2021-35465
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rearnsha at gcc dot gnu.org
  Target Milestone: ---

Arm recently published a CVE (CVE-2021-35465) relating to the armv8-m/armv8.1-m
CMSE extension.

GCC needs to implement a mitigation for this erratum when targetting affected
products.

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rearnsha at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2021-08-24

--- Comment #1 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Mine

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Earnshaw <rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:3929bca9ca95de9d35e82ae8828b188029e3eb70

commit r12-3112-g3929bca9ca95de9d35e82ae8828b188029e3eb70
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 11 16:02:05 2021 +0100

    arm: Add command-line option for enabling CVE-2021-35465 mitigation
[PR102035]

    Add a new option, -mfix-cmse-cve-2021-35465 and document it.  Enable it
    automatically for cortex-m33, cortex-m35p and cortex-m55.

    gcc:
            PR target/102035
            * config/arm/arm.opt (mfix-cmse-cve-2021-35465): New option.
            * doc/invoke.texi (Arm Options): Document it.
            * config/arm/arm-cpus.in (quirk_vlldm): New feature bit.
            (ALL_QUIRKS): Add quirk_vlldm.
            (cortex-m33): Add quirk_vlldm.
            (cortex-m35p, cortex-m55): Likewise.
            * config/arm/arm.c (arm_option_override): Enable fix_vlldm if
            targetting an affected CPU and not explicitly controlled on
            the command line.

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Earnshaw <rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:574e7950bd6b34e9e2cacce18c802b45505d1d0a

commit r12-3113-g574e7950bd6b34e9e2cacce18c802b45505d1d0a
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 18 17:16:25 2021 +0100

    arm: add erratum mitigation to __gnu_cmse_nonsecure_call [PR102035]

    Add the recommended erratum mitigation sequence to
    __gnu_cmse_nonsecure_call for use on Armv8-m.main devices. Since this
    is in the library code we cannot know in advance whether the core we
    are running on will be affected by this, so always enable it.

    libgcc:
            PR target/102035
            * config/arm/cmse_nonsecure_call.S (__gnu_cmse_nonsecure_call):
            Add vlldm erratum work-around.

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Earnshaw <rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:30461cf8dba3d3adb15a125e4da48800eb2b9b8f

commit r12-3114-g30461cf8dba3d3adb15a125e4da48800eb2b9b8f
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 18 17:18:37 2021 +0100

    arm: fix vlldm erratum for Armv8.1-m [PR102035]

    For Armv8.1-m we generate code that emits VLLDM directly and do not
    rely on support code in the library, so emit the mitigation directly
    as well, when required.  In this case, we can use the compiler options
    to determine when to apply the fix and when it is safe to omit it.

    gcc:
            PR target/102035
            * config/arm/arm.md (attribute arch): Add fix_vlldm.
            (arch_enabled): Use it.
            * config/arm/vfp.md (lazy_store_multiple_insn): Add alternative to
            use when erratum mitigation is needed.

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Earnshaw <rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:809330ab8450261e05919b472783bf15e4b000f7

commit r12-3115-g809330ab8450261e05919b472783bf15e4b000f7
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Tue Jul 6 15:10:18 2021 +0100

    arm: Add tests for VLLDM mitigation [PR102035]

    New tests for the erratum mitigation.

    gcc/testsuite:
            PR target/102035
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-13a.c: New test.
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-8a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp-sp/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp-sp/cmse-8a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-13a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-8a.c: Likewise.

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:80e7c4638444790e4bcc871220a279e84d9ce299

commit r11-8902-g80e7c4638444790e4bcc871220a279e84d9ce299
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 11 16:02:05 2021 +0100

    arm: Add command-line option for enabling CVE-2021-35465 mitigation
[PR102035]

    Add a new option, -mfix-cmse-cve-2021-35465 and document it.  Enable it
    automatically for cortex-m33, cortex-m35p and cortex-m55.

    gcc:
            PR target/102035
            * config/arm/arm.opt (mfix-cmse-cve-2021-35465): New option.
            * doc/invoke.texi (Arm Options): Document it.
            * config/arm/arm-cpus.in (quirk_vlldm): New feature bit.
            (ALL_QUIRKS): Add quirk_vlldm.
            (cortex-m33): Add quirk_vlldm.
            (cortex-m35p, cortex-m55): Likewise.
            * config/arm/arm.c (arm_option_override): Enable fix_vlldm if
            targetting an affected CPU and not explicitly controlled on
            the command line.
    (cherry picked from commit 3929bca9ca95de9d35e82ae8828b188029e3eb70)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:2539763c89a6777502f16457269e2c31d6d95b67

commit r11-8903-g2539763c89a6777502f16457269e2c31d6d95b67
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 18 17:16:25 2021 +0100

    arm: add erratum mitigation to __gnu_cmse_nonsecure_call [PR102035]

    Add the recommended erratum mitigation sequence to
    __gnu_cmse_nonsecure_call for use on Armv8-m.main devices. Since this
    is in the library code we cannot know in advance whether the core we
    are running on will be affected by this, so always enable it.

    libgcc:
            PR target/102035
            * config/arm/cmse_nonsecure_call.S (__gnu_cmse_nonsecure_call):
            Add vlldm erratum work-around.
    (cherry picked from commit 574e7950bd6b34e9e2cacce18c802b45505d1d0a)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:8933c1b66a6b7a66b8843e21c8cb6c0679fc2d09

commit r11-8904-g8933c1b66a6b7a66b8843e21c8cb6c0679fc2d09
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 18 17:18:37 2021 +0100

    arm: fix vlldm erratum for Armv8.1-m [PR102035]

    For Armv8.1-m we generate code that emits VLLDM directly and do not
    rely on support code in the library, so emit the mitigation directly
    as well, when required.  In this case, we can use the compiler options
    to determine when to apply the fix and when it is safe to omit it.

    gcc:
            PR target/102035
            * config/arm/arm.md (attribute arch): Add fix_vlldm.
            (arch_enabled): Use it.
            * config/arm/vfp.md (lazy_store_multiple_insn): Add alternative to
            use when erratum mitigation is needed.
    (cherry picked from commit 30461cf8dba3d3adb15a125e4da48800eb2b9b8f)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:41ccd2b32415d55f2f97b8afb01f4cde87de9028

commit r11-8905-g41ccd2b32415d55f2f97b8afb01f4cde87de9028
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Tue Jul 6 15:10:18 2021 +0100

    arm: Add tests for VLLDM mitigation [PR102035]

    New tests for the erratum mitigation.

    gcc/testsuite:
            PR target/102035
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-13a.c: New test.
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-8a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp-sp/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp-sp/cmse-8a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-13a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-8a.c: Likewise.

    (cherry picked from commit 809330ab8450261e05919b472783bf15e4b000f7)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:a3e0dafd46cbbb76ec890d66d33ce59cdeb595bd

commit r10-10064-ga3e0dafd46cbbb76ec890d66d33ce59cdeb595bd
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 11 16:02:05 2021 +0100

    arm: Add command-line option for enabling CVE-2021-35465 mitigation
[PR102035]

    Add a new option, -mfix-cmse-cve-2021-35465 and document it.  Enable it
    automatically for cortex-m33, cortex-m35p and cortex-m55.

    gcc:
            PR target/102035
            * config/arm/arm.opt (mfix-cmse-cve-2021-35465): New option.
            * doc/invoke.texi (Arm Options): Document it.
            * config/arm/arm-cpus.in (quirk_vlldm): New feature bit.
            (ALL_QUIRKS): Add quirk_vlldm.
            (cortex-m33): Add quirk_vlldm.
            (cortex-m35p, cortex-m55): Likewise.
            * config/arm/arm.c (arm_option_override): Enable fix_vlldm if
            targetting an affected CPU and not explicitly controlled on
            the command line.
    (cherry picked from commit 3929bca9ca95de9d35e82ae8828b188029e3eb70)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:a6db929252f4945710b010ca04f12af7d0f8b410

commit r10-10065-ga6db929252f4945710b010ca04f12af7d0f8b410
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 18 17:16:25 2021 +0100

    arm: add erratum mitigation to __gnu_cmse_nonsecure_call [PR102035]

    Add the recommended erratum mitigation sequence to
    __gnu_cmse_nonsecure_call for use on Armv8-m.main devices. Since this
    is in the library code we cannot know in advance whether the core we
    are running on will be affected by this, so always enable it.

    libgcc:
            PR target/102035
            * config/arm/cmse_nonsecure_call.S (__gnu_cmse_nonsecure_call):
            Add vlldm erratum work-around.
    (cherry picked from commit 574e7950bd6b34e9e2cacce18c802b45505d1d0a)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:08ecab2cce4cbe9a31148cad088473c8af5dbd29

commit r10-10066-g08ecab2cce4cbe9a31148cad088473c8af5dbd29
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Fri Jun 18 17:18:37 2021 +0100

    arm: fix vlldm erratum for Armv8.1-m [PR102035]

    For Armv8.1-m we generate code that emits VLLDM directly and do not
    rely on support code in the library, so emit the mitigation directly
    as well, when required.  In this case, we can use the compiler options
    to determine when to apply the fix and when it is safe to omit it.

    gcc:
            PR target/102035
            * config/arm/arm.md (attribute arch): Add fix_vlldm.
            (arch_enabled): Use it.
            * config/arm/vfp.md (lazy_store_multiple_insn): Add alternative to
            use when erratum mitigation is needed.
    (cherry picked from commit 30461cf8dba3d3adb15a125e4da48800eb2b9b8f)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Earnshaw
<rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:95e694f7d23bdfc93291f2700b1e6221e4546567

commit r10-10067-g95e694f7d23bdfc93291f2700b1e6221e4546567
Author: Richard Earnshaw <rearnsha@arm.com>
Date:   Tue Jul 6 15:10:18 2021 +0100

    arm: Add tests for VLLDM mitigation [PR102035]

    New tests for the erratum mitigation.

    gcc/testsuite:
            PR target/102035
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-13a.c: New test.
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/soft/cmse-8a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp-sp/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp-sp/cmse-8a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-13a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-7a.c: Likewise.
            * gcc.target/arm/cmse/mainline/8_1m/softfp/cmse-8a.c: Likewise.

    (cherry picked from commit 809330ab8450261e05919b472783bf15e4b000f7)

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #14 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Fixed on all relevant branches.

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5

[Bug target/102035] arm/m-profile/cmse add mitigation for CVE-2021-35465

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102035

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |10.4