[Bug d/102185] New: d: STRING_CSTs converted back into StringExp include null pointer in length

[Bug d/102185] New: d: STRING_CSTs converted back into StringExp include null pointer in length

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102185

            Bug ID: 102185
           Summary: d: STRING_CSTs converted back into StringExp include
                    null pointer in length
           Product: gcc
           Version: 11.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ibuclaw at gdcproject dot org
  Target Milestone: ---

---
version (D_HardFloat)
{
    // prints 5LU instead of 4LU
    pragma(msg, __traits(getTargetInfo, "floatAbi").length);

    // static assert  ("hard\x00" == "hard") is false
    static assert(__traits(getTargetInfo, "floatAbi") == "hard");
}

[Bug d/102185] d: STRING_CSTs converted back into StringExp include null pointer in length

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102185

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:53a4def0dc1aac39d592a0d20e9ec16e8b5574ac

commit r12-3465-g53a4def0dc1aac39d592a0d20e9ec16e8b5574ac
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Fri Sep 3 09:34:00 2021 +0200

    d: Don't include terminating null pointer in string expression conversion
(PR102185)

    This gets re-added by the ExprVisitor when lowering StringExp back into a
    STRING_CST during the code generator pass.

            PR d/102185

    gcc/d/ChangeLog:

            * d-builtins.cc (d_eval_constant_expression): Don't include
            terminating null pointer in string expression conversion.

    gcc/testsuite/ChangeLog:

            * gdc.dg/pr102185.d: New test.

[Bug d/102185] d: STRING_CSTs converted back into StringExp include null pointer in length

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102185

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:09a2049123e242aaf8a4bbfa8eb3ce92901b6f4e

commit r11-8982-g09a2049123e242aaf8a4bbfa8eb3ce92901b6f4e
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Fri Sep 3 09:34:00 2021 +0200

    d: Don't include terminating null pointer in string expression conversion
(PR102185)

    This gets re-added by the ExprVisitor when lowering StringExp back into a
    STRING_CST during the code generator pass.

            PR d/102185

    gcc/d/ChangeLog:

            * d-builtins.cc (d_eval_constant_expression): Don't include
            terminating null pointer in string expression conversion.

    gcc/testsuite/ChangeLog:

            * gdc.dg/pr102185.d: New test.

    (cherry picked from commit 53a4def0dc1aac39d592a0d20e9ec16e8b5574ac)

[Bug d/102185] d: STRING_CSTs converted back into StringExp include null pointer in length

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102185

Iain Buclaw <ibuclaw at gdcproject dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Fix committed.

[Bug d/102185] d: STRING_CSTs converted back into StringExp include null pointer in length

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102185

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> ---
The test fails on riscv because it doesn't handle floatABI == "double".