[Bug target/102230] New: ICE in classify_argument, at config/i386/i386.c:2474

[Bug target/102230] New: ICE in classify_argument, at config/i386/i386.c:2474

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102230

            Bug ID: 102230
           Summary: ICE in classify_argument, at config/i386/i386.c:2474
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: x86_64-unknown-linux-gnu

gcc-12.0.0-alpha20210905 snapshot (g:a827909537cf085e5673ca7816b7bd7151d89fc5)
ICEs when compiling the following testcase, reduced from
gcc/testsuite/gcc.target/arm/armv8_2-fp16-arith-2.c:

typedef _Float16 float16x4_t __attribute__ ((vector_size (8)));

float16x4_t
test_float16x4_t (float16x4_t a)
{
  return a;
}

% x86_64-unknown-linux-gnu-gcc-12.0.0 -c nyecizge.c
nyecizge.c: In function 'test_float16x4_t':
nyecizge.c:5:1: internal compiler error: in classify_argument, at
config/i386/i386.c:2474
    5 | {
      | ^
0x78253f classify_argument
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/config/i386/i386.c:2474
0x120239a examine_argument
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/config/i386/i386.c:2493
0x12058ff ix86_return_in_memory
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/config/i386/i386.c:4186
0xb2d715 aggregate_value_p(tree_node const*, tree_node const*)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/function.c:2119
0xb321ca allocate_struct_function(tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/function.c:4845
0x84f23c store_parm_decls()
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/c/c-decl.c:10128
0x8af40f c_parser_declaration_or_fndef
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/c/c-parser.c:2506
0x8b7a53 c_parser_external_declaration
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/c/c-parser.c:1780
0x8b84bb c_parser_translation_unit
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/c/c-parser.c:1653
0x8b84bb c_parse_file()
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/c/c-parser.c:22581
0x919b3d c_common_parse_file()
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210905/work/gcc-12-20210905/gcc/c-family/c-opts.c:1236

[Bug target/102230] ICE in classify_argument, at config/i386/i386.c:2474

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102230

--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
It relies on https://gcc.gnu.org/pipermail/gcc-patches/2021-August/576496.html
which is not committed yet.

[Bug target/102230] ICE in classify_argument, at config/i386/i386.c:2474

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102230

--- Comment #2 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Hongtao.liu from comment #1)
> It relies on
> https://gcc.gnu.org/pipermail/gcc-patches/2021-August/576496.html which is
> not committed yet.

I realize it's 64-bit vector which will be supported later.

[Bug target/102230] ICE in classify_argument, at config/i386/i386.c:2474

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102230

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hongyu Wang <hongyuw@gcc.gnu.org>:

https://gcc.gnu.org/g:eea10afef71e1947e3a3fde2a44839054ab91967

commit r12-3914-geea10afef71e1947e3a3fde2a44839054ab91967
Author: Hongyu Wang <hongyu.wang@intel.com>
Date:   Thu Jul 15 13:31:24 2021 +0800

    AVX512FP16: Support basic 64/32bit vector type and operation.

    For 32bit target, V4HF vector is parsed same as __m64 type, V2HF
    is parsed by stack and returned from GPR since it is not specified
    by ABI.

    gcc/ChangeLog:

            PR target/102230
            * config/i386/i386.h (VALID_AVX512FP16_REG_MODE): Add
            V2HF mode check.
            (VALID_SSE2_REG_VHF_MODE): Add V4HFmode and V2HFmode.
            (VALID_MMX_REG_MODE): Add V4HFmode.
            (SSE_REG_MODE_P): Replace VALID_AVX512FP16_REG_MODE with
            vector mode condition.
            * config/i386/i386.c (classify_argument): Parse V4HF/V2HF
            via sse regs.
            (function_arg_32): Add V4HFmode.
            (function_arg_advance_32): Likewise.
            * config/i386/i386.md (mode): Add V4HF/V2HF.
            (MODE_SIZE): Likewise.
            * config/i386/mmx.md (MMXMODE): Add V4HF mode.
            (V_32): Add V2HF mode.
            (VHF_32_64): New mode iterator.
            (*mov<mode>_internal): Adjust sse alternatives to support
            V4HF mode move.
            (*mov<mode>_internal): Adjust sse alternatives to support
            V2HF mode move.
            (<insn><mode>3): New define_insn for add/sub/mul/div.

    gcc/testsuite/ChangeLog:

            PR target/102230
            * gcc.target/i386/avx512fp16-floatvnhf.c: Remove xfail.
            * gcc.target/i386/avx512fp16-trunc-extendvnhf.c: Ditto.
            * gcc.target/i386/avx512fp16-truncvnhf.c: Ditto.
            * gcc.target/i386/avx512fp16-64-32-vecop-1.c: New test.
            * gcc.target/i386/avx512fp16-64-32-vecop-2.c: Ditto.
            * gcc.target/i386/pr102230.c: Ditto.

[Bug target/102230] ICE in classify_argument, at config/i386/i386.c:2474

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102230

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |12.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 12.