[Bug bootstrap/102242] New: [11 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[Bug bootstrap/102242] New: [11 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[gerald at pfeifer dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

            Bug ID: 102242
           Summary: [11 regression] analyzer/engine.cc built with clang:
                    /usr/include/c++/v1/typeinfo:346:5: error: no member
                    named 'fancy_abort'
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gerald at pfeifer dot com
  Target Milestone: ---

Only with clang as bootstrap compiler:

  In file included from
/scratch/tmp/gerald/GCC-HEAD/gcc/analyzer/engine.cc:69:
  In file included from /usr/include/c++/v1/memory:653:
  /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort' 
    in name space 'std::__1'; did you mean simply 'fancy_abort'?
    _VSTD::abort();
    ^~~~~~~
  /usr/include/c++/v1/__config:782:15: note: expanded from macro '_VSTD'
  #define _VSTD std::_LIBCPP_ABI_NAMESPACE
                ^
  /scratch/tmp/gerald/GCC-HEAD/gcc/system.h:777:13: note: 'fancy_abort'
declared here
  extern void fancy_abort (const char *, int, const char *)
              ^

I am pretty sure this is caused by

  gcc/analyzer/ChangeLog:
       PR analyzer/99260
       * analyzer.h (class custom_edge_info): New class, adapted from
       exploded_edge::custom_info_t.  Make member functions const.
       Make update_model return bool, converting edge param from
       reference to a pointer, and adding a ctxt param.
       (class path_context): New class.
       * call-info.cc: New file.
       * call-info.h: New file.
       * engine.cc: Include "analyzer/call-info.h" and <memory>.

and think I have an idea how to tackle this. Prototype patch in testing...

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at gcc dot gnu.org

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Sorry about the breakage.

I think I need to #define INCLUDE_UNIQUE_PTR before including system.h, rather
than manually including <memory>.  Was that what your patch does?

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-09-08
     Ever confirmed|0                           |1
   Target Milestone|---                         |12.0
           Keywords|                            |build

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[gerald at pfeifer dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

--- Comment #3 from Gerald Pfeifer <gerald at pfeifer dot com> ---
(In reply to David Malcolm from comment #1)
> Sorry about the breakage.

That's what my nightly testers are here for to catch. :)

> I think I need to #define INCLUDE_UNIQUE_PTR before including system.h,
> rather than manually including <memory>.  Was that what your patch does?

In my patch, which passed bootstrap in the meantime, I added

    #ifdef INCLUDE_MEMORY
    # include <memory>
    #endif

to gcc/system.h and defined INCLUDE_MEMORY early in analyzer/engine.cc.

Your patch sounds a little lighter and in fact more portable, so happy if
you want to go with it.

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu.org

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
maxim has posted the (IMO obvious) patch here:

https://gcc.gnu.org/pipermail/gcc-patches/2021-September/579159.html

as noted any platform that might be bootstrapped using clang is affected.

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gerald Pfeifer <gerald@gcc.gnu.org>:

https://gcc.gnu.org/g:745781d24cd7562202687cfbe05597ee673d4537

commit r12-3598-g745781d24cd7562202687cfbe05597ee673d4537
Author: Maxim Blinov <maxim.blinov@embecosm.com>
Date:   Fri Sep 17 00:32:58 2021 +0200

    analyzer: Fix bootstrap with clang

    gcc/analyzer/ChangeLog:
            PR bootstrap/102242
            * engine.cc (INCLUDE_UNIQUE_PTR): Define.

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[gerald at pfeifer dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

Gerald Pfeifer <gerald at pfeifer dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |gerald at pfeifer dot com
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Gerald Pfeifer <gerald at pfeifer dot com> ---
Passed testing on my regular tester that flagged this issue last night.

[Bug bootstrap/102242] [12 regression] analyzer/engine.cc built with clang: /usr/include/c++/v1/typeinfo:346:5: error: no member named 'fancy_abort'

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102242

--- Comment #7 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for taking care of this.